René's URL Explorer Experiment


Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities · GitHub

Open Graph Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities

X Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities

Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was assumed before. So we might need a deprecation cycle (we can emit warnings where we will raise exceptions / change equality behaviour). Or maybe people even find the change to be too large to even be considered? What do people think?

Open Graph Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ...

X Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ...

Opengraph URL: https://github.com/python-quantities/python-quantities/pull/147

X: @github

direct link

Domain: www.github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:49c350bd-9155-84d2-0ff6-4b21f5afff3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB002:1CEAED:1DA7EE0:271EC3C:696AFC59
html-safe-noncedf6b59587cbf4c9a6fbc09f6f0858833b54fe2295a6f0b98dec19037daef407c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDAyOjFDRUFFRDoxREE3RUUwOjI3MUVDM0M6Njk2QUZDNTkiLCJ2aXNpdG9yX2lkIjoiNzQyOTk1MzU4ODg1NjI5MDM5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac41c32b7dafde2a9a3e74ae8d4a18d068e06121ef28de765b38c8187201d00c58
hovercard-subject-tagpull_request:165576969
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-quantities/python-quantities/pull/147/files
twitter:imagehttps://avatars.githubusercontent.com/u/485936?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/485936?s=400&v=4
og:image:altThis fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-quantities/python-quantities git https://github.com/python-quantities/python-quantities.git
octolytics-dimension-user_id222003
octolytics-dimension-user_loginpython-quantities
octolytics-dimension-repository_id560911
octolytics-dimension-repository_nwopython-quantities/python-quantities
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id560911
octolytics-dimension-repository_network_root_nwopython-quantities/python-quantities
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://www.github.com/python-quantities/python-quantities/pull/147/files#start-of-content
https://www.github.com/
Sign in https://www.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-quantities%2Fpython-quantities%2Fpull%2F147%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://www.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-quantities%2Fpython-quantities%2Fpull%2F147%2Ffiles
Sign up https://www.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-quantities%2Fpython-quantities
Reloadhttps://www.github.com/python-quantities/python-quantities/pull/147/files
Reloadhttps://www.github.com/python-quantities/python-quantities/pull/147/files
Reloadhttps://www.github.com/python-quantities/python-quantities/pull/147/files
python-quantities https://www.github.com/python-quantities
python-quantitieshttps://www.github.com/python-quantities/python-quantities
Notifications https://www.github.com/login?return_to=%2Fpython-quantities%2Fpython-quantities
Fork 77 https://www.github.com/login?return_to=%2Fpython-quantities%2Fpython-quantities
Star 216 https://www.github.com/login?return_to=%2Fpython-quantities%2Fpython-quantities
Code https://www.github.com/python-quantities/python-quantities
Issues 73 https://www.github.com/python-quantities/python-quantities/issues
Pull requests 4 https://www.github.com/python-quantities/python-quantities/pulls
Actions https://www.github.com/python-quantities/python-quantities/actions
Projects 0 https://www.github.com/python-quantities/python-quantities/projects
Wiki https://www.github.com/python-quantities/python-quantities/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://www.github.com/python-quantities/python-quantities/security
Please reload this pagehttps://www.github.com/python-quantities/python-quantities/pull/147/files
Insights https://www.github.com/python-quantities/python-quantities/pulse
Code https://www.github.com/python-quantities/python-quantities
Issues https://www.github.com/python-quantities/python-quantities/issues
Pull requests https://www.github.com/python-quantities/python-quantities/pulls
Actions https://www.github.com/python-quantities/python-quantities/actions
Projects https://www.github.com/python-quantities/python-quantities/projects
Wiki https://www.github.com/python-quantities/python-quantities/wiki
Security https://www.github.com/python-quantities/python-quantities/security
Insights https://www.github.com/python-quantities/python-quantities/pulse
Sign up for GitHub https://www.github.com/signup?return_to=%2Fpython-quantities%2Fpython-quantities%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://www.github.com/login?return_to=%2Fpython-quantities%2Fpython-quantities%2Fissues%2Fnew%2Fchoose
bjodahhttps://www.github.com/bjodah
python-quantities:masterhttps://www.github.com/python-quantities/python-quantities/tree/master
bjodah:fix-equalityhttps://www.github.com/bjodah/python-quantities/tree/fix-equality
Conversation 2 https://www.github.com/python-quantities/python-quantities/pull/147
Commits 2 https://www.github.com/python-quantities/python-quantities/pull/147/commits
Checks 0 https://www.github.com/python-quantities/python-quantities/pull/147/checks
Files changed https://www.github.com/python-quantities/python-quantities/pull/147/files
Please reload this pagehttps://www.github.com/python-quantities/python-quantities/pull/147/files
Change comparison of Quantity (to fix gh-146) https://www.github.com/python-quantities/python-quantities/pull/147/files#top
Show all changes 2 commits https://www.github.com/python-quantities/python-quantities/pull/147/files
dcaecba Change comparison of Quantity (to fix gh-146) bjodah Jan 28, 2018 https://www.github.com/python-quantities/python-quantities/pull/147/commits/dcaecbafb586d6b48dd2ca7779f6036deb6b947b
f6a5a26 Re-add xfail marker for test_fix bjodah Jan 29, 2018 https://www.github.com/python-quantities/python-quantities/pull/147/commits/f6a5a261c7ec135bc96b70083108910fd7658906
Clear filters https://www.github.com/python-quantities/python-quantities/pull/147/files
Please reload this pagehttps://www.github.com/python-quantities/python-quantities/pull/147/files
Please reload this pagehttps://www.github.com/python-quantities/python-quantities/pull/147/files
quantity.py https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-d25eb3952bb1ac5423fb2c77934fe2971993175f625859b33c4a1ae157917153
test_comparison.py https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
test_umath.py https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-31cbd6f48067a2766bb66bc475ac88f21ffbb2d6982ae756aaa21a7200423881
umath.py https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-cd76d3e7018a9efec5c9c3ec27b4589aa9f05ea09a9e7a5a071b3d38f666e5b2
quantities/quantity.pyhttps://www.github.com/python-quantities/python-quantities/pull/147/files#diff-d25eb3952bb1ac5423fb2c77934fe2971993175f625859b33c4a1ae157917153
View file https://www.github.com/python-quantities/python-quantities/blob/f6a5a261c7ec135bc96b70083108910fd7658906/quantities/quantity.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://www.github.com/python-quantities/python-quantities/pull/147/{{ revealButtonHref }}
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-d25eb3952bb1ac5423fb2c77934fe2971993175f625859b33c4a1ae157917153
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-d25eb3952bb1ac5423fb2c77934fe2971993175f625859b33c4a1ae157917153
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-d25eb3952bb1ac5423fb2c77934fe2971993175f625859b33c4a1ae157917153
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-d25eb3952bb1ac5423fb2c77934fe2971993175f625859b33c4a1ae157917153
quantities/tests/test_comparison.pyhttps://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
View file https://www.github.com/python-quantities/python-quantities/blob/f6a5a261c7ec135bc96b70083108910fd7658906/quantities/tests/test_comparison.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://www.github.com/python-quantities/python-quantities/pull/147/{{ revealButtonHref }}
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-7578f0c3936acacd0fa04e666297118f7401b1562b9ccdbc1961e94b4cef8ceb
quantities/tests/test_umath.pyhttps://www.github.com/python-quantities/python-quantities/pull/147/files#diff-31cbd6f48067a2766bb66bc475ac88f21ffbb2d6982ae756aaa21a7200423881
View file https://www.github.com/python-quantities/python-quantities/blob/f6a5a261c7ec135bc96b70083108910fd7658906/quantities/tests/test_umath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://www.github.com/python-quantities/python-quantities/pull/147/{{ revealButtonHref }}
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-31cbd6f48067a2766bb66bc475ac88f21ffbb2d6982ae756aaa21a7200423881
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-31cbd6f48067a2766bb66bc475ac88f21ffbb2d6982ae756aaa21a7200423881
quantities/umath.pyhttps://www.github.com/python-quantities/python-quantities/pull/147/files#diff-cd76d3e7018a9efec5c9c3ec27b4589aa9f05ea09a9e7a5a071b3d38f666e5b2
View file https://www.github.com/python-quantities/python-quantities/blob/f6a5a261c7ec135bc96b70083108910fd7658906/quantities/umath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://www.github.com/python-quantities/python-quantities/pull/147/{{ revealButtonHref }}
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-cd76d3e7018a9efec5c9c3ec27b4589aa9f05ea09a9e7a5a071b3d38f666e5b2
https://www.github.com/python-quantities/python-quantities/pull/147/files#diff-cd76d3e7018a9efec5c9c3ec27b4589aa9f05ea09a9e7a5a071b3d38f666e5b2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.