Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities · GitHub
Open Graph Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities
X Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities
Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was assumed before. So we might need a deprecation cycle (we can emit warnings where we will raise exceptions / change equality behaviour). Or maybe people even find the change to be too large to even be considered? What do people think?
Open Graph Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ...
X Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ...
Opengraph URL: https://github.com/python-quantities/python-quantities/pull/147
X: @github
Domain: www.github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:ea8e5e81-4c40-94d4-891a-d21fa04f2a90 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C7FC:26BEF2:5BD78:73A1D:696AFBAE |
| html-safe-nonce | f2c4503a844315850e71f5be476b1b3937bfbd4cb186bb9912317e406b4b15cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0ZDOjI2QkVGMjo1QkQ3ODo3M0ExRDo2OTZBRkJBRSIsInZpc2l0b3JfaWQiOiI4MzE2MjM0NzM2MjI0MzY5NTgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 04948bbd2af590aad74fd2b7880af35e47563f63a341aa27fc6ea52596586e48 |
| hovercard-subject-tag | pull_request:165576969 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-quantities/python-quantities/pull/147/checks |
| twitter:image | https://avatars.githubusercontent.com/u/485936?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/485936?s=400&v=4 |
| og:image:alt | This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python-quantities/python-quantities git https://github.com/python-quantities/python-quantities.git |
| octolytics-dimension-user_id | 222003 |
| octolytics-dimension-user_login | python-quantities |
| octolytics-dimension-repository_id | 560911 |
| octolytics-dimension-repository_nwo | python-quantities/python-quantities |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 560911 |
| octolytics-dimension-repository_network_root_nwo | python-quantities/python-quantities |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width