Title: Improve the usage of Sysfs in the interaction with EV3Dev · Issue #765 · ev3dev-lang-java/ev3dev-lang-java · GitHub
Open Graph Title: Improve the usage of Sysfs in the interaction with EV3Dev · Issue #765 · ev3dev-lang-java/ev3dev-lang-java
X Title: Improve the usage of Sysfs in the interaction with EV3Dev · Issue #765 · ev3dev-lang-java/ev3dev-lang-java
Description: In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this iteration: Moving from static methods, t...
Open Graph Description: In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this ...
X Description: In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this ...
Opengraph URL: https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/765
X: @github
Domain: www.github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve the usage of Sysfs in the interaction with EV3Dev","articleBody":"In the previous Issue:\r\nhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/748\r\n\r\nWe improved the performance with current architecture, the usage of `Sysfs`. `Sysfs` in the current form, is a stateless class with static methods. \r\n\r\nIdeas to improve in this iteration:\r\n\r\n- [ ] Moving from static methods, to instance methods\r\n- [ ] Add `setSysfs` to `Mock` Sysfs to improve testing. Using `Guava`, it could be possible to expose only for testing with the annotation `@VisibleForTesting` but I don´t want to increase the weight of the jar in 2mb.\r\n\r\n@dwalend, what other ideas, do you have?\r\n@JakubVanek, what other ideas, do you have? \r\n\r\nIn your opinion, what state is necessary to maintain in `Sysfs` and have some kind of concurrency protection?\r\n\r\n**Criterias for PR:**\r\n- Branch: `sysfs_perf2`\r\n- Code pass Checkstyle: `gradle checkstyleMain` \r\n- Benchmarks: `JMH`\r\n- Complexity: Reduced\r\n- Number of changes: Minimum\r\n- Tests: Every new class, requiere Unit Tests. Review how to add Concurrency tests to avoid concurrency issues.\r\n\r\nWe will analyse for the classes: \r\n\r\n- [ ] ev3dev.sensors.Battery;\r\n- [ ] ev3dev.actuators.ev3.EV3Led;\r\n- [ ] ev3dev.actuators.lego.motors.EV3LargeRegulatedMotor;\r\n\r\nWe will begin with Battery, an easy case and later, we will tackle a complex case like a Motor.\r\n\r\n\r\n\r\nJuan Antonio","author":{"url":"https://github.com/jabrena","@type":"Person","name":"jabrena"},"datePublished":"2020-12-27T22:45:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":83},"url":"https://github.com/765/ev3dev-lang-java/issues/765"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e449e32b-7ee7-36e4-b7b4-17770e1b4cf2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C054:108162:8FF270:C52011:6A62E9FC |
| html-safe-nonce | 13cd24194949623f3d5f6860e45ee391b8db6feabb76cf8564005417fd1b739b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDU0OjEwODE2Mjo4RkYyNzA6QzUyMDExOjZBNjJFOUZDIiwidmlzaXRvcl9pZCI6IjYyNTUxNTc0NDUzNDM5MTI5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 96fba691174e9e7063411cdf5410d08065929f59933366fcc8acec7d4abca347 |
| hovercard-subject-tag | issue:775121808 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ev3dev-lang-java/ev3dev-lang-java/765/issue_layout |
| twitter:image | https://opengraph.githubassets.com/12222777da8861f4c8cd5ac6e5811389b09f0863cda6ae7aede4e0b6431d872a/ev3dev-lang-java/ev3dev-lang-java/issues/765 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12222777da8861f4c8cd5ac6e5811389b09f0863cda6ae7aede4e0b6431d872a/ev3dev-lang-java/ev3dev-lang-java/issues/765 |
| og:image:alt | In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jabrena |
| hostname | github.com |
| expected-hostname | github.com |
| None | df33b1b61ee7b9a0af988199bfc3503c9c1acafb1f1d40e1f140ea7c84f890dd |
| turbo-cache-control | no-preview |
| go-import | github.com/ev3dev-lang-java/ev3dev-lang-java git https://github.com/ev3dev-lang-java/ev3dev-lang-java.git |
| octolytics-dimension-user_id | 17526590 |
| octolytics-dimension-user_login | ev3dev-lang-java |
| octolytics-dimension-repository_id | 45205585 |
| octolytics-dimension-repository_nwo | ev3dev-lang-java/ev3dev-lang-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45205585 |
| octolytics-dimension-repository_network_root_nwo | ev3dev-lang-java/ev3dev-lang-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d41cd1bdb290013455c0ac430fa755621733f5eb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width