Title: Feature: Add open close parentheses for attribute suggestions that are methods by rybarczykj · Pull Request #840 · bpython/bpython · GitHub
Open Graph Title: Feature: Add open close parentheses for attribute suggestions that are methods by rybarczykj · Pull Request #840 · bpython/bpython
X Title: Feature: Add open close parentheses for attribute suggestions that are methods by rybarczykj · Pull Request #840 · bpython/bpython
Description: TLDR: Parenthesis on attribute suggestions so it's clear which attributes are methods Slight modification to how parentheses are autofilled Sorry for the bad quality gifs. I should stop using GIPHY for this. Native function completion Current behavior: open parenthesis in suggestion and autofill. You have to type something after the paren before you can see the method signature. My proposal: open AND close parens in suggestion, no parens in autofill. Now typing the open paren shows the method signature. This might mess with some people's muscle memory since it changes what's autofilled. Attributute completion Current behavior: no parens in suggestion or autofill. You can't tell what is a method or otherwise. My proposal: open close parens in suggestion, no parens in autofill. Very clear which attrs are methods. Since this only changes the infobox, it shouldn't mess with anyone's muscle memory. If this seems worth implementing, I'll need to fix some tests. Right now, tests expect matches that look like "math.cos" or "any(", but they'll be getting matches that look like "math.cos()" and "any()". Also I'm not sure if I implemented this the best way. The way I did it, the actual match string is altered to have parens. Maybe it's better to leave the match as-is, but add parenthesis only on the front end. This would require some passing around of information. Feedback appreciated.
Open Graph Description: TLDR: Parenthesis on attribute suggestions so it's clear which attributes are methods Slight modification to how parentheses are autofilled Sorry for the bad quality gifs. I should stop using...
X Description: TLDR: Parenthesis on attribute suggestions so it's clear which attributes are methods Slight modification to how parentheses are autofilled Sorry for the bad quality gifs. I should stop u...
Opengraph URL: https://github.com/bpython/bpython/pull/840
X: @github
Domain: www.github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:667ecf24-aaeb-d372-036b-91f614fed7a0 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 82E4:1C20BB:553CB1:748CF1:696DEB29 |
| html-safe-nonce | 428062d071e8e8f12fba26525c1d8f5d329265ac812392591e87aff489499821 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkU0OjFDMjBCQjo1NTNDQjE6NzQ4Q0YxOjY5NkRFQjI5IiwidmlzaXRvcl9pZCI6IjMxMDY4MDA1Mzk5MTE3MTE1MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | caf3882d7f5d3bb06d32250c717ba96b7749ea32bd499a6178def2c50fbd08ff |
| hovercard-subject-tag | pull_request:464204021 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/bpython/bpython/pull/840/checks |
| twitter:image | https://avatars.githubusercontent.com/u/48132522?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/48132522?s=400&v=4 |
| og:image:alt | TLDR: Parenthesis on attribute suggestions so it's clear which attributes are methods Slight modification to how parentheses are autofilled Sorry for the bad quality gifs. I should stop using... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064 |
| turbo-cache-control | no-preview |
| go-import | github.com/bpython/bpython git https://github.com/bpython/bpython.git |
| octolytics-dimension-user_id | 8071396 |
| octolytics-dimension-user_login | bpython |
| octolytics-dimension-repository_id | 21508865 |
| octolytics-dimension-repository_nwo | bpython/bpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21508865 |
| octolytics-dimension-repository_network_root_nwo | bpython/bpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7e5ae23c70136152637ceee8d6faceb35596ec46 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width