René's URL Explorer Experiment


Title: runtime checkable protocols potential raising error with custom getattribute · Issue #105134 · python/cpython · GitHub

Open Graph Title: runtime checkable protocols potential raising error with custom getattribute · Issue #105134 · python/cpython

X Title: runtime checkable protocols potential raising error with custom getattribute · Issue #105134 · python/cpython

Description: Bug report I'm unsure if this is more tensorflow bug or python bug but it does trace to this pr and error message traces to cpython source. I've also commented on issue in tensorflow side here. # typing 3.9/3.10 produces no error, typing...

Open Graph Description: Bug report I'm unsure if this is more tensorflow bug or python bug but it does trace to this pr and error message traces to cpython source. I've also commented on issue in tensorflow side here. # t...

X Description: Bug report I'm unsure if this is more tensorflow bug or python bug but it does trace to this pr and error message traces to cpython source. I've also commented on issue in tensorflow side h...

Opengraph URL: https://github.com/python/cpython/issues/105134

X: @github

direct link

Domain: togithub.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"runtime checkable protocols potential raising error with custom getattribute","articleBody":"# Bug report\r\nI'm unsure if this is more tensorflow bug or python bug but it does trace to this [pr](https://github.com/python/cpython/pull/103034) and error message traces to cpython source. I've also commented on issue in tensorflow side [here](https://github.com/tensorflow/tensorflow/issues/60687).\r\n\r\n```python\r\n# typing 3.9/3.10 produces no error, typing_extensions will trigger it.\r\nfrom typing_extensions import Protocol, runtime_checkable\r\n\r\nfrom tensorflow.python.trackable.data_structures import _DictWrapper\r\n\r\n\r\n@runtime_checkable\r\nclass Foo(Protocol):\r\n    def bar(self) -> None:\r\n        ...\r\n\r\n\r\nisinstance(_DictWrapper(), Foo)\r\n```\r\n\r\nWith typing extensions an error message is produced of,\r\n\r\n```python\r\nTraceback (most recent call last):\r\n  File \"/Users/pa-loaner/Snapchat/Dev/training-platform/scratch/runtime_protocol_custom_dict.py\", line 12, in \u003cmodule>\r\n    isinstance(_DictWrapper(), Foo)\r\n  File \"/Users/pa-loaner/Snapchat/Dev/.venvs/tf212/lib/python3.9/site-packages/typing_extensions.py\", line 604, in __instancecheck__\r\n    val = inspect.getattr_static(instance, attr)\r\n  File \"/Users/pa-loaner/.pyenv/versions/3.9.16/lib/python3.9/inspect.py\", line 1711, in getattr_static\r\n    instance_result = _check_instance(obj, attr)\r\n  File \"/Users/pa-loaner/.pyenv/versions/3.9.16/lib/python3.9/inspect.py\", line 1654, in _check_instance\r\n    instance_dict = object.__getattribute__(obj, \"__dict__\")\r\nTypeError: this __dict__ descriptor does not support '_DictWrapper' objects\r\n```\r\n# Your environment\r\n\r\nI've tested on cpython 3.9.16 and 3.10.10 where using typing works.  I'd suspect 3.11 will work as well. Using typing_extensions 4.6 triggers error with inspect.getattr_static usage. Reported here instead of typing extensions as adding getattr static there was backport from here. I'd expect this to reproduce on 3.12 although installing tf on 3.12 is likely tricky and easier to test with typing extensions. The _DictWrapper class is [here](https://github.com/tensorflow/tensorflow/blob/f8066222ad6b2edbf1ee359fda66f2b43473dbe7/tensorflow/python/trackable/data_structures.py#L782) and is like a subclass of `__dict__` with a custom getattribute to do some extra tracking of elements.\r\n\r\nI used latest version of tensorflow (2.12). The underlying error message comes from this [line](https://github.com/python/cpython/blob/f90d3f68db720bd6d0deda8cc0030339ccd43858/Objects/typeobject.c#L2871). As this can be triggered in attribute access unsure whether it should be TypeError vs AttributeError. If it was attribute error getattr static would catch it and be fine. If it needs to be type error then it's unclear to me whether tensorflow class is breaking some assumption or if getattr static should also catch type errors [here](https://github.com/python/cpython/blob/f90d3f68db720bd6d0deda8cc0030339ccd43858/Lib/inspect.py#L1794). In particular it's interesting that `object.__getattribute__` can raise TypeError and inspect.getattr_static can fail.\r\n\r\nI'll try to look tomorrow if I can make a more self contained example that doesn't require tensorflow.","author":{"url":"https://github.com/hmc-cs-mdrissi","@type":"Person","name":"hmc-cs-mdrissi"},"datePublished":"2023-05-31T07:33:44Z","url":"https://github.com/python/cpython/issues/105134"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4f4f30d4-8b56-ad6e-1549-c0266c7aaa58
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8D6E:3A60CF:3611C:4A74A:6AFE1DC0
html-safe-nonce840730f21a9d6963dc07291b2b264cccb6deffa5f1922fe75877811291fd3847
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDZFOjNBNjBDRjozNjExQzo0QTc0QTo2QUZFMURDMCIsInZpc2l0b3JfaWQiOiI2MjEwMTE3MDk1MDk5NjA0NDE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdec6978ce7fbc54f22da2dc943aa9724cb18818d441c944035903966a134f90b
hovercard-subject-tagissue:1733567623
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/105134/issue_layout
twitter:imagehttps://opengraph.githubassets.com/857e08b7619a4262341d769abfe1a5b8d96da4a472c600d1974ccb516b61f24a/python/cpython/issues/105134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/857e08b7619a4262341d769abfe1a5b8d96da4a472c600d1974ccb516b61f24a/python/cpython/issues/105134
og:image:altBug report I'm unsure if this is more tensorflow bug or python bug but it does trace to this pr and error message traces to cpython source. I've also commented on issue in tensorflow side here. # t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehmc-cs-mdrissi
hostnamegithub.com
expected-hostnamegithub.com
Noned0525ab1464526bf4532a5551aa348cf100dff75ef808a96fc67a08b1d946aa9
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefef3993a71fa20f7be8e167132fbf9619bc66e12
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://togithub.com/python/cpython/issues/105134#start-of-content
https://togithub.com/
Sign inhttps://togithub.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F105134
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://togithub.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F105134
Sign uphttps://togithub.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://togithub.com/python/cpython/issues/105134
Reloadhttps://togithub.com/python/cpython/issues/105134
Reloadhttps://togithub.com/python/cpython/issues/105134
pythonhttps://togithub.com/python
cpythonhttps://togithub.com/python/cpython
Codehttps://togithub.com/python/cpython
Issues5k+ (5k+)https://togithub.com/python/cpython/issues
Pull requests2.4k (2.4k)https://togithub.com/python/cpython/pulls
Actionshttps://togithub.com/python/cpython/actions
Projectshttps://togithub.com/python/cpython/projects
Security and qualityhttps://togithub.com/python/cpython/security
Insightshttps://togithub.com/python/cpython/insights
https://togithub.com/python/cpython
New issuehttps://togithub.com/login?return_to=https://github.com/python/cpython/issues/105134
New issuehttps://togithub.com/login?return_to=https://github.com/python/cpython/issues/105134
runtime checkable protocols potential raising error with custom getattributehttps://togithub.com/python/cpython/issues/105134#top
https://togithub.com/AlexWaygood
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
3.13only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/hmc-cs-mdrissi
hmc-cs-mdrissihttps://github.com/hmc-cs-mdrissi
on May 31, 2023https://github.com/python/cpython/issues/105134#issue-1733567623
prhttps://github.com/python/cpython/pull/103034
herehttps://github.com/tensorflow/tensorflow/issues/60687
herehttps://github.com/tensorflow/tensorflow/blob/f8066222ad6b2edbf1ee359fda66f2b43473dbe7/tensorflow/python/trackable/data_structures.py#L782
linehttps://github.com/python/cpython/blob/f90d3f68db720bd6d0deda8cc0030339ccd43858/Objects/typeobject.c#L2871
herehttps://github.com/python/cpython/blob/f90d3f68db720bd6d0deda8cc0030339ccd43858/Lib/inspect.py#L1794
hmc-cs-mdrissihttps://togithub.com/hmc-cs-mdrissi
type-bugAn unexpected behavior, bug, or errorhttps://togithub.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on May 31, 2023https://github.com/python/cpython/issues/105134#event-9386423631
AlexWaygoodhttps://togithub.com/AlexWaygood
topic-typinghttps://togithub.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
on May 31, 2023https://github.com/python/cpython/issues/105134#event-9386476764
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1569665497
AlexWaygoodhttps://togithub.com/AlexWaygood
stdlibStandard Library Python modules in the Lib/ directoryhttps://togithub.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
3.12only security fixeshttps://togithub.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
3.13only security fixeshttps://togithub.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
on May 31, 2023https://github.com/python/cpython/issues/105134#event-9386530999
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#event-9386531267
https://togithub.com/hmc-cs-mdrissi
hmc-cs-mdrissihttps://togithub.com/hmc-cs-mdrissi
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1569675419
wrapthttps://github.com/GrahamDumpleton/wrapt
ObjectProxyhttps://github.com/GrahamDumpleton/wrapt/blob/980e4b451c2b3cdef1d32c9ae10d97894dd3735e/src/wrapt/wrappers.py#L73
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1569964741
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1570015683
#103193https://github.com/python/cpython/issues/103193
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1570050453
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1570156880
https://github.com/AlexWaygood/getattr-static-reprohttps://github.com/AlexWaygood/getattr-static-repro
@carljmhttps://github.com/carljm
@JelleZijlstrahttps://github.com/JelleZijlstra
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1570167632
this __dict__ descriptor does not support '_DictWrapper' objects \ since version 1.15.0 GrahamDumpleton/wrapt#231https://github.com/GrahamDumpleton/wrapt/issues/231
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1570206348
@carljmhttps://github.com/carljm
https://togithub.com/JelleZijlstra
JelleZijlstrahttps://togithub.com/JelleZijlstra
on May 31, 2023https://github.com/python/cpython/issues/105134#issuecomment-1570509373
https://togithub.com/carljm
carljmhttps://togithub.com/carljm
on Jun 2, 2023https://github.com/python/cpython/issues/105134#issuecomment-1574386861
https://togithub.com/carljm
carljmhttps://togithub.com/carljm
on Jun 20, 2023https://github.com/python/cpython/issues/105134#issuecomment-1599591833
https://togithub.com/AlexWaygood
AlexWaygoodhttps://togithub.com/AlexWaygood
on Jun 20, 2023https://github.com/python/cpython/issues/105134#issuecomment-1599595150
@carljmhttps://github.com/carljm
AlexWaygoodhttps://togithub.com/AlexWaygood
not plannedhttps://togithub.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jun 20, 2023https://github.com/python/cpython/issues/105134#event-9584816245
Sign up for freehttps://togithub.com/signup?return_to=https://github.com/python/cpython/issues/105134
Sign in to commenthttps://togithub.com/login?return_to=https://github.com/python/cpython/issues/105134
AlexWaygoodhttps://togithub.com/AlexWaygood
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
3.13only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.