Title: _idna_encode checks for non-ASCII characters incorrectly · Issue #2901 · urllib3/urllib3 · GitHub
Open Graph Title: _idna_encode checks for non-ASCII characters incorrectly · Issue #2901 · urllib3/urllib3
X Title: _idna_encode checks for non-ASCII characters incorrectly · Issue #2901 · urllib3/urllib3
Description: _idna_encode checks for non-ASCII characters incorrectly From src/urllib3/util/url.py: if name and any([ord(x) > 128 for x in name]): try: import idna Since the ASCII range ends at chr(127), the comparison should use >= rather than >.
Open Graph Description: _idna_encode checks for non-ASCII characters incorrectly From src/urllib3/util/url.py: if name and any([ord(x) > 128 for x in name]): try: import idna Since the ASCII range ends at chr(127), the co...
X Description: _idna_encode checks for non-ASCII characters incorrectly From src/urllib3/util/url.py: if name and any([ord(x) > 128 for x in name]): try: import idna Since the ASCII range ends at chr(127), the...
Opengraph URL: https://github.com/urllib3/urllib3/issues/2901
X: @github
Domain: redirect.github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"_idna_encode checks for non-ASCII characters incorrectly","articleBody":"### _idna_encode checks for non-ASCII characters incorrectly\r\nFrom `src/urllib3/util/url.py`:\r\n```python3\r\nif name and any([ord(x) \u003e 128 for x in name]):\r\n try:\r\n import idna\r\n```\r\nSince the ASCII range ends at `chr(127)`, the comparison should use `\u003e=` rather than `\u003e`.","author":{"url":"https://github.com/kenballus","@type":"Person","name":"kenballus"},"datePublished":"2023-01-26T02:59:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/2901/urllib3/issues/2901"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e0716857-4434-25fe-8cf0-3f83a92e6038 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D54A:26E27C:210FDB0:2B9993D:6996A889 |
| html-safe-nonce | 7da16ff8b7db0e8160c621770a3d3203fb6ebfe9dfc69a8a4dc298f3e30f053a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTRBOjI2RTI3QzoyMTBGREIwOjJCOTk5M0Q6Njk5NkE4ODkiLCJ2aXNpdG9yX2lkIjoiMzQxMzc2NzMzMjkzNzc3MTE0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e3b38b5fdd09f30604102cfa5dffc64cfb153e877061152f98f026b3af72e65e |
| hovercard-subject-tag | issue:1557560943 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/urllib3/urllib3/2901/issue_layout |
| twitter:image | https://opengraph.githubassets.com/00b945159d38f7d98a6abb54b05a1d3909df1178d5e271ff9fc62f5a233cd602/urllib3/urllib3/issues/2901 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/00b945159d38f7d98a6abb54b05a1d3909df1178d5e271ff9fc62f5a233cd602/urllib3/urllib3/issues/2901 |
| og:image:alt | _idna_encode checks for non-ASCII characters incorrectly From src/urllib3/util/url.py: if name and any([ord(x) > 128 for x in name]): try: import idna Since the ASCII range ends at chr(127), the co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kenballus |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/urllib3/urllib3 git https://github.com/urllib3/urllib3.git |
| octolytics-dimension-user_id | 26825299 |
| octolytics-dimension-user_login | urllib3 |
| octolytics-dimension-repository_id | 2410676 |
| octolytics-dimension-repository_nwo | urllib3/urllib3 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2410676 |
| octolytics-dimension-repository_network_root_nwo | urllib3/urllib3 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f514dad261e3ac9cceca6fa432a562be2927d949 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width