René's URL Explorer Experiment


Title: gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations by JelleZijlstra · Pull Request #138953 · python/cpython · GitHub

Open Graph Title: gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations by JelleZijlstra · Pull Request #138953 · python/cpython

X Title: gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations by JelleZijlstra · Pull Request #138953 · python/cpython

Description: This issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...

Open Graph Description: This issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...

X Description: This issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...

Opengraph URL: https://github.com/python/cpython/pull/138953

X: @github

direct link

Domain: redirect.github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:acf57e08-b226-05ae-7c1b-365f1e87c1bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EA2:37ADE8:2905283:3614B8E:696B2B09
html-safe-nonce45ced311f76c2f0ffa0de677aacf17eae492d545f538593b17d84502549f3a16
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUEyOjM3QURFODoyOTA1MjgzOjM2MTRCOEU6Njk2QjJCMDkiLCJ2aXNpdG9yX2lkIjoiODc3NDA4ODEzMjY5NzcyOTgwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdc31d5f9a13923ebdba8ce39b99d3d44f1c2aec8f59cd12497b1718ff3569f92
hovercard-subject-tagpull_request:2830508129
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/138953/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57717d82871571ede894288ae25a369016637f5102c1ffb2bdf59faff83d6764/python/cpython/pull/138953
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57717d82871571ede894288ae25a369016637f5102c1ffb2bdf59faff83d6764/python/cpython/pull/138953
og:image:altThis issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/python/cpython/pull/138953#start-of-content
https://redirect.github.com/
Sign in https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138953
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138953
Sign up https://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://redirect.github.com/python/cpython/pull/138953
Reloadhttps://redirect.github.com/python/cpython/pull/138953
Reloadhttps://redirect.github.com/python/cpython/pull/138953
python https://redirect.github.com/python
cpythonhttps://redirect.github.com/python/cpython
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
Notifications https://redirect.github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://redirect.github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://redirect.github.com/login?return_to=%2Fpython%2Fcpython
Code https://redirect.github.com/python/cpython
Issues 5k+ https://redirect.github.com/python/cpython/issues
Pull requests 2.1k https://redirect.github.com/python/cpython/pulls
Actions https://redirect.github.com/python/cpython/actions
Projects 31 https://redirect.github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://redirect.github.com/python/cpython/security
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
Insights https://redirect.github.com/python/cpython/pulse
Code https://redirect.github.com/python/cpython
Issues https://redirect.github.com/python/cpython/issues
Pull requests https://redirect.github.com/python/cpython/pulls
Actions https://redirect.github.com/python/cpython/actions
Projects https://redirect.github.com/python/cpython/projects
Security https://redirect.github.com/python/cpython/security
Insights https://redirect.github.com/python/cpython/pulse
Sign up for GitHub https://redirect.github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://redirect.github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://redirect.github.com/python/cpython/pull/138953#issue-comment-box
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
python:mainhttps://redirect.github.com/python/cpython/tree/main
JelleZijlstra:generictdhttps://redirect.github.com/JelleZijlstra/cpython/tree/generictd
gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations https://redirect.github.com/python/cpython/pull/138953#top
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
python:mainhttps://redirect.github.com/python/cpython/tree/main
JelleZijlstra:generictdhttps://redirect.github.com/JelleZijlstra/cpython/tree/generictd
Conversation 8 https://redirect.github.com/python/cpython/pull/138953
Commits 2 https://redirect.github.com/python/cpython/pull/138953/commits
Checks 51 https://redirect.github.com/python/cpython/pull/138953/checks
Files changed https://redirect.github.com/python/cpython/pull/138953/files
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://github.co/hiddenchars
https://redirect.github.com/python/cpython/pull/{{ revealButtonHref }}
https://redirect.github.com/JelleZijlstra
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
Sep 15, 2025https://redirect.github.com/python/cpython/pull/138953#issue-3419350436
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
#137227https://github.com/python/cpython/pull/137227
#138949https://github.com/python/cpython/issues/138949
ForwardRef.evaluate() mishandles type_params #137226https://github.com/python/cpython/issues/137226
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/JelleZijlstra
pythongh-137226https://github.com/python/cpython/issues/137226
: Fix get_type_hints() on generic TypedDict with strin…https://redirect.github.com/python/cpython/pull/138953/commits/95a4187b80099f056194270db1b0d851d080c234
95a4187https://redirect.github.com/python/cpython/pull/138953/commits/95a4187b80099f056194270db1b0d851d080c234
python#137227https://github.com/python/cpython/pull/137227
python#138949https://github.com/python/cpython/issues/138949
https://redirect.github.com/JelleZijlstra
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
AlexWaygoodhttps://redirect.github.com/AlexWaygood
code ownerhttps://redirect.github.com/python/cpython/blob/dfd52e7a8b5a7e5a5d64b11742ac7242ec938ede/.github/CODEOWNERS#L579
September 15, 2025 20:14https://redirect.github.com/python/cpython/pull/138953#event-19709954973
https://redirect.github.com/apps/bedevere-app
bedevere-apphttps://redirect.github.com/apps/bedevere-app
awaiting core review https://redirect.github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 15, 2025https://redirect.github.com/python/cpython/pull/138953#event-19709955740
https://redirect.github.com/apps/bedevere-app
bedevere-apphttps://redirect.github.com/apps/bedevere-app
Sep 15, 2025 https://redirect.github.com/python/cpython/pull/138953#ref-issue-3275613418
ForwardRef.evaluate() mishandles type_params #137226 https://redirect.github.com/python/cpython/issues/137226
https://redirect.github.com/JelleZijlstra
remove still-broken testhttps://redirect.github.com/python/cpython/pull/138953/commits/58f97cd0110a6f87bb3aa0e62d731649c1a71548
58f97cdhttps://redirect.github.com/python/cpython/pull/138953/commits/58f97cd0110a6f87bb3aa0e62d731649c1a71548
https://redirect.github.com/johnslavik
Sign in to viewhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138953
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/hugovk
Sign in to viewhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138953
https://redirect.github.com/AlexWaygood
AlexWaygoodhttps://redirect.github.com/AlexWaygood
Sep 16, 2025 https://redirect.github.com/python/cpython/pull/138953#pullrequestreview-3228658963
View reviewed changes https://redirect.github.com/python/cpython/pull/138953/files/58f97cd0110a6f87bb3aa0e62d731649c1a71548
AlexWaygoodhttps://redirect.github.com/AlexWaygood
https://redirect.github.com/python/cpython/pull/138953#pullrequestreview-3228658963
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@hugovkhttps://github.com/hugovk
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
Lib/typing.pyhttps://redirect.github.com/python/cpython/pull/138953/files/58f97cd0110a6f87bb3aa0e62d731649c1a71548#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
AlexWaygoodhttps://redirect.github.com/AlexWaygood
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#discussion_r2351650685
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#discussion_r2352707384
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/apps/bedevere-app
bedevere-apphttps://redirect.github.com/apps/bedevere-app
awaiting merge https://redirect.github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://redirect.github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#event-19721156970
https://redirect.github.com/AlexWaygood
AlexWaygoodhttps://redirect.github.com/AlexWaygood
needs backport to 3.14 https://redirect.github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#event-19721189457
https://redirect.github.com/JelleZijlstra
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
6d6aba2https://redirect.github.com/python/cpython/commit/6d6aba252301cdf9d5ae3189629e1e43101dd58f
Sep 16, 2025https://github.com/python/cpython/pull/138953#event-19728357988
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/apps/miss-islington-app
miss-islington-apphttps://redirect.github.com/apps/miss-islington-app
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#issuecomment-3299035137
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/apps/bedevere-app
bedevere-apphttps://redirect.github.com/apps/bedevere-app
awaiting merge https://redirect.github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#event-19728359196
https://redirect.github.com/apps/miss-islington-app
miss-islington-apphttps://redirect.github.com/apps/miss-islington-app
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#issuecomment-3299035359
@JelleZijlstrahttps://github.com/JelleZijlstra
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/apps/miss-islington-app
miss-islington-apphttps://redirect.github.com/apps/miss-islington-app
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#event-19728361025
https://redirect.github.com/JelleZijlstra
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
September 16, 2025 14:28https://redirect.github.com/python/cpython/pull/138953#event-19728363787
JelleZijlstrahttps://redirect.github.com/JelleZijlstra
Sep 16, 2025 https://redirect.github.com/python/cpython/pull/138953#ref-commit-25ab548
https://redirect.github.com/JelleZijlstra
[3.14]https://redirect.github.com/JelleZijlstra/cpython/commit/25ab548444a8b152247e6152f968b1cc70556d1d
pythongh-137226https://github.com/python/cpython/issues/137226
: Fix get_type_hints() on generic TypedDict wit…https://redirect.github.com/JelleZijlstra/cpython/commit/25ab548444a8b152247e6152f968b1cc70556d1d
25ab548https://redirect.github.com/JelleZijlstra/cpython/commit/25ab548444a8b152247e6152f968b1cc70556d1d
pythonGH-138953https://github.com/python/cpython/pull/138953
pythonGH-137227https://github.com/python/cpython/pull/137227
pythonGH-138949https://github.com/python/cpython/issues/138949
6d6aba2https://github.com/JelleZijlstra/cpython/commit/6d6aba252301cdf9d5ae3189629e1e43101dd58f
https://redirect.github.com/apps/bedevere-app
bedevere-apphttps://redirect.github.com/apps/bedevere-app
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#issuecomment-3299059773
GH-138989https://github.com/python/cpython/pull/138989
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/apps/bedevere-app
bedevere-apphttps://redirect.github.com/apps/bedevere-app
needs backport to 3.14 https://redirect.github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Sep 16, 2025https://redirect.github.com/python/cpython/pull/138953#event-19728502118
hugovkhttps://redirect.github.com/hugovk
Sep 17, 2025 https://redirect.github.com/python/cpython/pull/138953#ref-commit-6038447
https://redirect.github.com/JelleZijlstra
[3.14]https://redirect.github.com/python/cpython/commit/6038447d99663b0434a4f2c545c0543e9a81fdc3
gh-137226https://github.com/python/cpython/issues/137226
: Fix get_type_hints() on generic TypedDict with stri…https://redirect.github.com/python/cpython/commit/6038447d99663b0434a4f2c545c0543e9a81fdc3
6038447https://redirect.github.com/python/cpython/commit/6038447d99663b0434a4f2c545c0543e9a81fdc3
GH-138953https://github.com/python/cpython/pull/138953
#138989https://github.com/python/cpython/pull/138989
Sign up for freehttps://redirect.github.com/join?source=comment-repo
Sign in to commenthttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138953
https://redirect.github.com/johnslavik
johnslavik https://redirect.github.com/johnslavik
https://redirect.github.com/python/cpython/pull/138953/files/58f97cd0110a6f87bb3aa0e62d731649c1a71548
https://redirect.github.com/AlexWaygood
AlexWaygood https://redirect.github.com/AlexWaygood
https://redirect.github.com/python/cpython/pull/138953/files/58f97cd0110a6f87bb3aa0e62d731649c1a71548
https://redirect.github.com/JelleZijlstra
JelleZijlstra https://redirect.github.com/JelleZijlstra
Please reload this pagehttps://redirect.github.com/python/cpython/pull/138953
https://redirect.github.com/JelleZijlstra
https://redirect.github.com/hugovk
https://redirect.github.com/johnslavik
https://redirect.github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.