Title: Submit only runtimeClasspath to the dependency graph by abashev · Pull Request #82 · openjavaformat/open-java-format · GitHub
Open Graph Title: Submit only runtimeClasspath to the dependency graph by abashev · Pull Request #82 · openjavaformat/open-java-format
X Title: Submit only runtimeClasspath to the dependency graph by abashev · Pull Request #82 · openjavaformat/open-java-format
Description: All 24 open Dependabot alerts, the critical tika-core one (#18) among them, are for build tooling that never ships. This limits the submitted dependency graph to runtimeClasspath. Why the current setting does not help. dependency-submission resolves every configuration of every project and submits all of it: 452 packages, among them buildSrc's buildScriptClasspath and compileClasspath (JReleaser 1.26.0 and its tika-core, httpclient5, httpcore5-h2) and the root project's buildscript classpath (jsoup, Jackson 2.20.2 and 2.21.0, plexus-utils). DEPENDENCY_GRAPH_RUNTIME_INCLUDE_CONFIGURATIONS does not filter anything: it only labels each package runtime or development. Dependabot raises alerts for both, and the auto-triage rule the old comment counted on to dismiss the development ones was never created. Why runtimeClasspath is enough. Everything that ships is built from it: the published jars and their POMs, the native image (open-java-format-native compiles from runtimeClasspath), the Eclipse plugin (embeds it), and the IntelliJ plugin (bundles it, and its formatter configuration resolves the same 14 packages as :open-java-format's runtimeClasspath). The plugin matches the regex against the whole configuration name, so testRuntimeClasspath stays out. The scope label goes: with only runtime configurations in the graph it would say nothing, and without a scope parameter the plugin writes none. Nothing in this repository reads it. Checked locally with the GitHub Dependency Graph Gradle Plugin 1.4.2 that gradle/actions v6.3.0 runs, applied through an init script to :ForceDependencyResolutionPlugin_resolveAllDependencies: before after packages in the graph 452 24 runtime packages of the old graph still present 24 24 open alerts whose vulnerable version is in the graph 24 0 Without the filter the local run reproduces the snapshot of the last submission on main (run 36137459303) package for package, except the platform-specific JetBrains Runtime. The action passes the input to Gradle as DEPENDENCY_GRAPH_INCLUDE_CONFIGURATIONS (sources/src/dependency-graph.ts at the pinned SHA). The workflow runs only on pushes to main, so this PR's checks do not exercise it. After the merge the next run replaces the snapshot under the same correlator (submit_dependency_graph-full-build), and the 24 alerts should close as fixed.
Open Graph Description: All 24 open Dependabot alerts, the critical tika-core one (#18) among them, are for build tooling that never ships. This limits the submitted dependency graph to runtimeClasspath. Why the current s...
X Description: All 24 open Dependabot alerts, the critical tika-core one (#18) among them, are for build tooling that never ships. This limits the submitted dependency graph to runtimeClasspath. Why the current s...
Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/82
X: @github
Domain: redirect.github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f3c3e700-e334-efbd-b7e3-5a231921c1df |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B792:F2EBF:4EB71:69695:6AFBD8F2 |
| html-safe-nonce | d5c0d01114c92eec035abac860ef4fe00a5280b3d4b936c08a58aad061910534 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzkyOkYyRUJGOjRFQjcxOjY5Njk1OjZBRkJEOEYyIiwidmlzaXRvcl9pZCI6Ijc0MTY4MTY2OTE2NDc1MTA5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36762c021bddde0d962ec579fe97310869baf8dd9b336006cf6db95670ce3456 |
| hovercard-subject-tag | pull_request:4639957178 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/82/files |
| twitter:image | https://avatars.githubusercontent.com/u/214171?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/214171?s=400&v=4 |
| og:image:alt | All 24 open Dependabot alerts, the critical tika-core one (#18) among them, are for build tooling that never ships. This limits the submitted dependency graph to runtimeClasspath. Why the current s... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 820be804f18e1ef3940bd74a00d41d73d02e2b91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width