René's URL Explorer Experiment


Title: Reorder non-sealed as one modifier by abashev · Pull Request #67 · openjavaformat/open-java-format · GitHub

Open Graph Title: Reorder non-sealed as one modifier by abashev · Pull Request #67 · openjavaformat/open-java-format

X Title: Reorder non-sealed as one modifier by abashev · Pull Request #67 · openjavaformat/open-java-format

Description: Brings over google/google-java-format#1107, a fix from google-java-format 1.23. The bug non-sealed private interface B extends I {} made the whole file fail with error: expected. javac lexes non-sealed as three tokens, non, - and sealed, and ModifierOrderer looked at one token at a time: it never saw non-sealed, took the trailing sealed as the modifier to move in front of private, and left non- behind, so the reordered text no longer parsed. From upstream, with the author kept google/google-java-format#1107 by Liam Miller-Cushon, commit authored by them. The sorter reads the three tokens as one modifier (ModifierTokens) and writes it back whole. Adapted to this codebase's javax.annotation.Nullable and NullAway suppressions. The upstream golden Sealed and the sealedClass unit test come with it, with the expected output in this project's style. Added here A second ModifierOrdererTest case for the exact shape that failed, non-sealed private. Checked The golden and the new unit test fail on main and pass with the change. ./gradlew :open-java-format:test on JDK 21: 1503 tests, all green. The 15,747 files of the JDK 21 sources format exactly as before; none of them writes non-sealed out of JLS order.

Open Graph Description: Brings over google/google-java-format#1107, a fix from google-java-format 1.23. The bug non-sealed private interface B extends I {} made the whole file fail with error: <identifier> expected....

X Description: Brings over google/google-java-format#1107, a fix from google-java-format 1.23. The bug non-sealed private interface B extends I {} made the whole file fail with error: &lt;identifier&gt; e...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/67

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af6215ae-5fc5-8e9b-913b-2de47a263677
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF90:2AEFEF:54ABD:6E6F5:6AFBD902
html-safe-nonce6d814db896ba17efd7ed1d00fa7526cbe0931f747af27e8a8a9b19875fe479b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjkwOjJBRUZFRjo1NEFCRDo2RTZGNTo2QUZCRDkwMiIsInZpc2l0b3JfaWQiOiI4MzMwNDcwNDYxMTg3ODA3NDkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4a055d4872b4be440d369719d2b28347840496f405c676c4424883bba726068f
hovercard-subject-tagpull_request:4630446973
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/67/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altBrings over google/google-java-format#1107, a fix from google-java-format 1.23. The bug non-sealed private interface B extends I {} made the whole file fail with error: <identifier> expected....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release820be804f18e1ef3940bd74a00d41d73d02e2b91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F67%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F67%2Ffiles
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files
openjavaformathttps://redirect.github.com/openjavaformat
open-java-formathttps://redirect.github.com/openjavaformat/open-java-format
Codehttps://redirect.github.com/openjavaformat/open-java-format
Issues30 (30)https://redirect.github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://redirect.github.com/openjavaformat/open-java-format/pulls
Discussionshttps://redirect.github.com/openjavaformat/open-java-format/discussions
Actionshttps://redirect.github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://redirect.github.com/openjavaformat/open-java-format/security
Insightshttps://redirect.github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://redirect.github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://redirect.github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://redirect.github.com/abashev
mainhttps://redirect.github.com/openjavaformat/open-java-format/tree/main
non-sealed-modifier-orderhttps://redirect.github.com/openjavaformat/open-java-format/tree/non-sealed-modifier-order
Conversation 0 https://redirect.github.com/openjavaformat/open-java-format/pull/67
Commits 1 https://redirect.github.com/openjavaformat/open-java-format/pull/67/commits
Checks 15 https://redirect.github.com/openjavaformat/open-java-format/pull/67/checks
Files changed https://redirect.github.com/openjavaformat/open-java-format/pull/67/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files
Reorder non-sealed as one modifier https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#top
Show all changes 1 commit https://redirect.github.com/openjavaformat/open-java-format/pull/67/files
6282d12 Reorder non-sealed as one modifier cushon Sep 24, 2026 https://redirect.github.com/openjavaformat/open-java-format/pull/67/commits/6282d1244f199a1827d2bced36df9d56c5b13a52
Clear filters https://redirect.github.com/openjavaformat/open-java-format/pull/67/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files
ModifierOrderer.java https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
FileBasedTests.java https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-37a9ba04f49a2468318e11b2f38928b3751a1bb7b3c52f0c870eeba55be4b3be
ModifierOrdererTest.java https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-bed2981284ae09f2dbb77677a7c05494580532661df6276dd5688414fa1334af
Sealed.input https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4bec26d616e773f7ada3174ee9b08f1e2aa527fa0d7ce66b4a7a5aa4fae510a5
Sealed.output https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-3275fff1aea3cf37a9fa97233e27bf208abc45a3c920d12aaa91019a2b698a3a
open-java-format/src/main/java/com/palantir/javaformat/java/ModifierOrderer.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
View file https://redirect.github.com/openjavaformat/open-java-format/blob/6282d1244f199a1827d2bced36df9d56c5b13a52/open-java-format/src/main/java/com/palantir/javaformat/java/ModifierOrderer.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/67/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4ca4542a2cdbaea2771802d24e9af48d5ba8493ade0269e8e828d0a3a9e3b10e
open-java-format/src/test/java/com/palantir/javaformat/java/FileBasedTests.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-37a9ba04f49a2468318e11b2f38928b3751a1bb7b3c52f0c870eeba55be4b3be
View file https://redirect.github.com/openjavaformat/open-java-format/blob/6282d1244f199a1827d2bced36df9d56c5b13a52/open-java-format/src/test/java/com/palantir/javaformat/java/FileBasedTests.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/67/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-37a9ba04f49a2468318e11b2f38928b3751a1bb7b3c52f0c870eeba55be4b3be
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-37a9ba04f49a2468318e11b2f38928b3751a1bb7b3c52f0c870eeba55be4b3be
open-java-format/src/test/java/com/palantir/javaformat/java/ModifierOrdererTest.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-bed2981284ae09f2dbb77677a7c05494580532661df6276dd5688414fa1334af
View file https://redirect.github.com/openjavaformat/open-java-format/blob/6282d1244f199a1827d2bced36df9d56c5b13a52/open-java-format/src/test/java/com/palantir/javaformat/java/ModifierOrdererTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/67/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-bed2981284ae09f2dbb77677a7c05494580532661df6276dd5688414fa1334af
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/Sealed.inputhttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-4bec26d616e773f7ada3174ee9b08f1e2aa527fa0d7ce66b4a7a5aa4fae510a5
View file https://redirect.github.com/openjavaformat/open-java-format/blob/6282d1244f199a1827d2bced36df9d56c5b13a52/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/Sealed.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/67/{{ revealButtonHref }}
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/Sealed.outputhttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files#diff-3275fff1aea3cf37a9fa97233e27bf208abc45a3c920d12aaa91019a2b698a3a
View file https://redirect.github.com/openjavaformat/open-java-format/blob/6282d1244f199a1827d2bced36df9d56c5b13a52/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/Sealed.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/67/{{ revealButtonHref }}
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/67/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.