René's URL Explorer Experiment


Title: Accept a type annotation on the qualifier of a method reference by abashev · Pull Request #66 · openjavaformat/open-java-format · GitHub

Open Graph Title: Accept a type annotation on the qualifier of a method reference by abashev · Pull Request #66 · openjavaformat/open-java-format

X Title: Accept a type annotation on the qualifier of a method reference by abashev · Pull Request #66 · openjavaformat/open-java-format

Description: Brings over google/google-java-format#984, a fix from google-java-format 1.19. The bug Supplier> a = @A ArrayList::new; failed with error: did not generate token "@". The printing of a type annotation on a method reference's qualifier was already in place, but visitMemberReference first synced to the tree's start position, and javac's start position for a member reference leaves out the annotation, so the sync reported the annotation's tokens as never generated. From upstream, with the author kept google/google-java-format#984 by Liam Miller-Cushon, commit authored by them: visitMemberReference no longer syncs to the start position. The upstream golden B308157568 comes with it; it covers a type annotation in every other position too, with the expected output in this project's style. Checked The golden fails on main and passes with the change. Long method references still break at :: exactly as before. ./gradlew :open-java-format:test on JDK 21: 1501 tests, all green. The 15,747 files of the JDK 21 sources format exactly as before.

Open Graph Description: Brings over google/google-java-format#984, a fix from google-java-format 1.19. The bug Supplier<List<?>> a = @A ArrayList::new; failed with error: did not generate token "@". ...

X Description: Brings over google/google-java-format#984, a fix from google-java-format 1.19. The bug Supplier&lt;List&lt;?&gt;&gt; a = @A ArrayList::new; failed with error: did not generate token...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/66

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40176fc2-6d13-2fd3-059d-f7cf5028be88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD076:101F59:4F087:6B247:6AFBD905
html-safe-nonce433043a0164755d57d9fc335690e4e2a04cf99ce187addda3f36b25f26b2e31e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDc2OjEwMUY1OTo0RjA4Nzo2QjI0Nzo2QUZCRDkwNSIsInZpc2l0b3JfaWQiOiIzNzgwOTkyMTY0OTYwMTMxMzM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac76854a7cdef218b2aa4dbe5ab34a8d39da205765fe68eface08358fc56a037e2
hovercard-subject-tagpull_request:4630411657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/66/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altBrings over google/google-java-format#984, a fix from google-java-format 1.19. The bug Supplier<List<?>> a = @A ArrayList::new; failed with error: did not generate token "@". ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release820be804f18e1ef3940bd74a00d41d73d02e2b91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F66%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F66%2Ffiles
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files
openjavaformathttps://redirect.github.com/openjavaformat
open-java-formathttps://redirect.github.com/openjavaformat/open-java-format
Codehttps://redirect.github.com/openjavaformat/open-java-format
Issues30 (30)https://redirect.github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://redirect.github.com/openjavaformat/open-java-format/pulls
Discussionshttps://redirect.github.com/openjavaformat/open-java-format/discussions
Actionshttps://redirect.github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://redirect.github.com/openjavaformat/open-java-format/security
Insightshttps://redirect.github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://redirect.github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://redirect.github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://redirect.github.com/abashev
mainhttps://redirect.github.com/openjavaformat/open-java-format/tree/main
member-reference-type-annotationhttps://redirect.github.com/openjavaformat/open-java-format/tree/member-reference-type-annotation
Conversation 0 https://redirect.github.com/openjavaformat/open-java-format/pull/66
Commits 1 https://redirect.github.com/openjavaformat/open-java-format/pull/66/commits
Checks 15 https://redirect.github.com/openjavaformat/open-java-format/pull/66/checks
Files changed https://redirect.github.com/openjavaformat/open-java-format/pull/66/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files
Accept a type annotation on the qualifier of a method reference https://redirect.github.com/openjavaformat/open-java-format/pull/66/files#top
Show all changes 1 commit https://redirect.github.com/openjavaformat/open-java-format/pull/66/files
af4b138 Accept a type annotation on the qualifier of a method reference cushon Sep 24, 2026 https://redirect.github.com/openjavaformat/open-java-format/pull/66/commits/af4b13837a025a4281ac643b457eeac477cad39e
Clear filters https://redirect.github.com/openjavaformat/open-java-format/pull/66/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files
JavaInputAstVisitor.java https://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
B308157568.input https://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-03937721f2688e9550d798e57fcde0273a9d142d304c43c8e65645baf1c90443
B308157568.output https://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-7120d9146cbcaee373df00280f19b6f3ad5046ee3e43f679a339a3d01dacca87
open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
View file https://redirect.github.com/openjavaformat/open-java-format/blob/af4b13837a025a4281ac643b457eeac477cad39e/open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/66/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
https://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/B308157568.inputhttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-03937721f2688e9550d798e57fcde0273a9d142d304c43c8e65645baf1c90443
View file https://redirect.github.com/openjavaformat/open-java-format/blob/af4b13837a025a4281ac643b457eeac477cad39e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/B308157568.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/66/{{ revealButtonHref }}
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/B308157568.outputhttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files#diff-7120d9146cbcaee373df00280f19b6f3ad5046ee3e43f679a339a3d01dacca87
View file https://redirect.github.com/openjavaformat/open-java-format/blob/af4b13837a025a4281ac643b457eeac477cad39e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/B308157568.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/66/{{ revealButtonHref }}
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/66/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.