René's URL Explorer Experiment


Title: Reflow long strings in formatDiff on the JVM, as with the native binary by abashev · Pull Request #232 · openjavaformat/open-java-format · GitHub

Open Graph Title: Reflow long strings in formatDiff on the JVM, as with the native binary by abashev · Pull Request #232 · openjavaformat/open-java-format

X Title: Reflow long strings in formatDiff on the JVM, as with the native binary by abashev · Pull Request #232 · openjavaformat/open-java-format

Description: Builds on #231; merge that first. Part of #219. formatDiff on the JVM now reflows long strings as it does with the native binary, and as IntelliJ IDEA does: the in-process FormatterServiceImpl.getFormatReplacements returns what Main --output-replacements prints. One method. What FormatFileCallable did for --output-replacements moves, unchanged, to the package-private Formatter.getFormatAndReflowReplacements; FormatFileCallable and FormatterServiceImpl call it. The command line's output does not change. The check. Each case of FormatterCasesTest, which #231's FormatterCasesJava21Test, Java25Test and Java28Test run, also gives the lines that formatting changes, taken as a range, to the service and to Main, and expects the same replacements. On the code of #231, 78 of the 915 cases fail on it, the stringwrapper ones among them. The services. FormatDiffTest runs the in-process formatter next to the bootstrapping and native ones, and FormatterServicesTest and FormatDiffTest reflow a long string on a changed line with each of the three. Not here: a long string outside the ranges is still reflowed once one in them needs it, on every surface alike now; that is the next pull request. Tests JDK 21: ./gradlew check passes; 1,419 tests in :open-java-format. JDK 25 and JDK 28 (28+23-ea): :open-java-format:test passes. JDK 25: :open-java-format:test passes, with the JDK 25 cases; JDK 28 (28+23-ea) too, with the JDK 28 ones. -PnativeImage=true (macOS aarch64, GraalVM 25): FormatterServicesTest 11 of 11, FormatDiffTest 7 of 7.

Open Graph Description: Builds on #231; merge that first. Part of #219. formatDiff on the JVM now reflows long strings as it does with the native binary, and as IntelliJ IDEA does: the in-process FormatterServiceImpl.getF...

X Description: Builds on #231; merge that first. Part of #219. formatDiff on the JVM now reflows long strings as it does with the native binary, and as IntelliJ IDEA does: the in-process FormatterServiceImpl.getF...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/232

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c09abca-e65e-8740-f02a-b126d1462868
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE31C:EFBC8:1F0B1B:2B78A9:6AFBD17D
html-safe-nonce3c0b719527c9ba0002eba918fc45775405cc3cb7753be2eb3336d5ffc24c95c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzFDOkVGQkM4OjFGMEIxQjoyQjc4QTk6NkFGQkQxN0QiLCJ2aXNpdG9yX2lkIjoiNjgzNTY2NTQxNTE3NTkxNzk0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac84c3a2ba959c6f90fbe0fb26d76485d103b873f0459686fc75fd715123becf72
hovercard-subject-tagpull_request:5315972389
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/232/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altBuilds on #231; merge that first. Part of #219. formatDiff on the JVM now reflows long strings as it does with the native binary, and as IntelliJ IDEA does: the in-process FormatterServiceImpl.getF...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release820be804f18e1ef3940bd74a00d41d73d02e2b91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F232%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F232%2Ffiles
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files
Reloadhttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files
openjavaformathttps://redirect.github.com/openjavaformat
open-java-formathttps://redirect.github.com/openjavaformat/open-java-format
Codehttps://redirect.github.com/openjavaformat/open-java-format
Issues30 (30)https://redirect.github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://redirect.github.com/openjavaformat/open-java-format/pulls
Discussionshttps://redirect.github.com/openjavaformat/open-java-format/discussions
Actionshttps://redirect.github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://redirect.github.com/openjavaformat/open-java-format/security
Insightshttps://redirect.github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://redirect.github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://redirect.github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://redirect.github.com/abashev
21.X.Xhttps://redirect.github.com/openjavaformat/open-java-format/tree/21.X.X
abashev/Range-reflow-in-processhttps://redirect.github.com/openjavaformat/open-java-format/tree/abashev/Range-reflow-in-process
Conversation 0 https://redirect.github.com/openjavaformat/open-java-format/pull/232
Commits 2 https://redirect.github.com/openjavaformat/open-java-format/pull/232/commits
Checks 17 https://redirect.github.com/openjavaformat/open-java-format/pull/232/checks
Files changed https://redirect.github.com/openjavaformat/open-java-format/pull/232/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files
Reflow long strings in formatDiff on the JVM, as with the native binary https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#top
Show all changes 2 commits https://redirect.github.com/openjavaformat/open-java-format/pull/232/files
bac4aa5 Return what --output-replacements prints from the in-process service abashev Nov 16, 2026 https://redirect.github.com/openjavaformat/open-java-format/pull/232/commits/bac4aa5084e3d7a27b7f14611be614c316e9a263
94e5117 Run the in-process formatter in FormatDiffTest and FormatterServicesTest abashev Nov 14, 2026 https://redirect.github.com/openjavaformat/open-java-format/pull/232/commits/94e5117a59938e1a0ca0f7b24f06b6c6e12c86ec
Clear filters https://redirect.github.com/openjavaformat/open-java-format/pull/232/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files
FormatDiffTest.java https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-b10c300cf3e9d91e6627e36b29c66d7a670beac2e79dda14481e48787f75d85b
FormatterServicesTest.java https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-124f2692d8cf2b1114341e748c10142cb70d873610f7fb86fe1497251f1442e7
FormatFileCallable.java https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-361a7035a2275aa1f571c45c56ee25bdc8e7e3cbf62267b33b63fbe337a7dc49
Formatter.java https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-fd61ca102fae096ccb3dcee9925025bec1ea7d5ab586817c56f186ffe2b705f0
FormatterServiceImpl.java https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-4e56414cb6a91b2c45fe09d8d4524e9a3b0a13a8c4fa4255c698ed213a8d2961
FormatterCasesTest.java https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-ba24490f720ed2a66a3fcfd208c29009ac7bddeabf6ca658b11e3160f3450d4e
gradle-open-java-format/src/test/java/com/palantir/javaformat/gradle/FormatDiffTest.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-b10c300cf3e9d91e6627e36b29c66d7a670beac2e79dda14481e48787f75d85b
View file https://redirect.github.com/openjavaformat/open-java-format/blob/94e5117a59938e1a0ca0f7b24f06b6c6e12c86ec/gradle-open-java-format/src/test/java/com/palantir/javaformat/gradle/FormatDiffTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/232/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-b10c300cf3e9d91e6627e36b29c66d7a670beac2e79dda14481e48787f75d85b
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-b10c300cf3e9d91e6627e36b29c66d7a670beac2e79dda14481e48787f75d85b
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-b10c300cf3e9d91e6627e36b29c66d7a670beac2e79dda14481e48787f75d85b
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-b10c300cf3e9d91e6627e36b29c66d7a670beac2e79dda14481e48787f75d85b
...-jdk-bootstrap/src/test/java/com/palantir/javaformat/bootstrap/FormatterServicesTest.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-124f2692d8cf2b1114341e748c10142cb70d873610f7fb86fe1497251f1442e7
View file https://redirect.github.com/openjavaformat/open-java-format/blob/94e5117a59938e1a0ca0f7b24f06b6c6e12c86ec/open-java-format-jdk-bootstrap/src/test/java/com/palantir/javaformat/bootstrap/FormatterServicesTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/232/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-124f2692d8cf2b1114341e748c10142cb70d873610f7fb86fe1497251f1442e7
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-124f2692d8cf2b1114341e748c10142cb70d873610f7fb86fe1497251f1442e7
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-124f2692d8cf2b1114341e748c10142cb70d873610f7fb86fe1497251f1442e7
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-124f2692d8cf2b1114341e748c10142cb70d873610f7fb86fe1497251f1442e7
open-java-format/src/main/java/com/palantir/javaformat/java/FormatFileCallable.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-361a7035a2275aa1f571c45c56ee25bdc8e7e3cbf62267b33b63fbe337a7dc49
View file https://redirect.github.com/openjavaformat/open-java-format/blob/94e5117a59938e1a0ca0f7b24f06b6c6e12c86ec/open-java-format/src/main/java/com/palantir/javaformat/java/FormatFileCallable.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/232/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-361a7035a2275aa1f571c45c56ee25bdc8e7e3cbf62267b33b63fbe337a7dc49
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-361a7035a2275aa1f571c45c56ee25bdc8e7e3cbf62267b33b63fbe337a7dc49
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-361a7035a2275aa1f571c45c56ee25bdc8e7e3cbf62267b33b63fbe337a7dc49
open-java-format/src/main/java/com/palantir/javaformat/java/Formatter.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-fd61ca102fae096ccb3dcee9925025bec1ea7d5ab586817c56f186ffe2b705f0
View file https://redirect.github.com/openjavaformat/open-java-format/blob/94e5117a59938e1a0ca0f7b24f06b6c6e12c86ec/open-java-format/src/main/java/com/palantir/javaformat/java/Formatter.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/232/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-fd61ca102fae096ccb3dcee9925025bec1ea7d5ab586817c56f186ffe2b705f0
open-java-format/src/main/java/com/palantir/javaformat/java/FormatterServiceImpl.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-4e56414cb6a91b2c45fe09d8d4524e9a3b0a13a8c4fa4255c698ed213a8d2961
View file https://redirect.github.com/openjavaformat/open-java-format/blob/94e5117a59938e1a0ca0f7b24f06b6c6e12c86ec/open-java-format/src/main/java/com/palantir/javaformat/java/FormatterServiceImpl.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/232/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-4e56414cb6a91b2c45fe09d8d4524e9a3b0a13a8c4fa4255c698ed213a8d2961
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-4e56414cb6a91b2c45fe09d8d4524e9a3b0a13a8c4fa4255c698ed213a8d2961
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-4e56414cb6a91b2c45fe09d8d4524e9a3b0a13a8c4fa4255c698ed213a8d2961
open-java-format/src/test/java/com/palantir/javaformat/java/FormatterCasesTest.javahttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-ba24490f720ed2a66a3fcfd208c29009ac7bddeabf6ca658b11e3160f3450d4e
View file https://redirect.github.com/openjavaformat/open-java-format/blob/94e5117a59938e1a0ca0f7b24f06b6c6e12c86ec/open-java-format/src/test/java/com/palantir/javaformat/java/FormatterCasesTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/openjavaformat/open-java-format/pull/232/{{ revealButtonHref }}
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-ba24490f720ed2a66a3fcfd208c29009ac7bddeabf6ca658b11e3160f3450d4e
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-ba24490f720ed2a66a3fcfd208c29009ac7bddeabf6ca658b11e3160f3450d4e
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-ba24490f720ed2a66a3fcfd208c29009ac7bddeabf6ca658b11e3160f3450d4e
https://redirect.github.com/openjavaformat/open-java-format/pull/232/files#diff-ba24490f720ed2a66a3fcfd208c29009ac7bddeabf6ca658b11e3160f3450d4e
Please reload this pagehttps://redirect.github.com/openjavaformat/open-java-format/pull/232/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.