René's URL Explorer Experiment


Title: src: add MakeCallback() taking an Environment by nigrosimone · Pull Request #66510 · nodejs/node · GitHub

Open Graph Title: src: add MakeCallback() taking an Environment by nigrosimone · Pull Request #66510 · nodejs/node

X Title: src: add MakeCallback() taking an Environment by nigrosimone · Pull Request #66510 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: node::MakeCallback() looks up the Environment from the creation context of the callback on every call. This adds an overload that takes it: an addon calling into the same Environment many times (uW...

X Description: node::MakeCallback() looks up the Environment from the creation context of the callback on every call. This adds an overload that takes it: an addon calling into the same Environment many times (uW...

Opengraph URL: https://github.com/nodejs/node/pull/66510

X: @github

direct link

Domain: redirect.github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:10ce47f5-d846-30e4-6827-c63433743c6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA682:78AAB:BB76BF:ED8AB6:6B036F44
html-safe-noncebb152fe9693dc88c83ba0a0f0623aff9699d167a3ffb19bc2bcf596729fe93b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjgyOjc4QUFCOkJCNzZCRjpFRDhBQjY6NkIwMzZGNDQiLCJ2aXNpdG9yX2lkIjoiMTAwNTk2ODIwODIzMjE0ODgwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccc9396855765bffb6c53b7475a52e70e9554c57ee519569f2db32d8c30eeb5e0
hovercard-subject-tagpull_request:4735275008
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66510/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/620a8484e4d19f97e540d44cc1bc3f991550a052f32fbac1506807899b3c0ce6/nodejs/node/pull/66510
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/620a8484e4d19f97e540d44cc1bc3f991550a052f32fbac1506807899b3c0ce6/nodejs/node/pull/66510
og:image:altnode::MakeCallback() looks up the Environment from the creation context of the callback on every call. This adds an overload that takes it: an addon calling into the same Environment many times (uW...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenigrosimone
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://redirect.github.com/nodejs/node/pull/66510#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66510
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66510
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://redirect.github.com/nodejs/node/pull/66510
Reloadhttps://redirect.github.com/nodejs/node/pull/66510
Reloadhttps://redirect.github.com/nodejs/node/pull/66510
nodejshttps://redirect.github.com/nodejs
nodehttps://redirect.github.com/nodejs/node
Codehttps://redirect.github.com/nodejs/node
Issues639 (639)https://redirect.github.com/nodejs/node/issues
Pull requests667 (667)https://redirect.github.com/nodejs/node/pulls
Actionshttps://redirect.github.com/nodejs/node/actions
Projectshttps://redirect.github.com/nodejs/node/projects
Security and qualityhttps://redirect.github.com/nodejs/node/security
Insightshttps://redirect.github.com/nodejs/node/insights
https://redirect.github.com/nodejs/node
nigrosimonehttps://redirect.github.com/nigrosimone
nodejs:mainhttps://redirect.github.com/nodejs/node/tree/main
nigrosimone:makecallback-envhttps://redirect.github.com/nigrosimone/node/tree/makecallback-env
Conversationhttps://redirect.github.com/nodejs/node/pull/66510
Commits2 (2)https://redirect.github.com/nodejs/node/pull/66510/commits
Checkshttps://redirect.github.com/nodejs/node/pull/66510/checks
Files changedhttps://redirect.github.com/nodejs/node/pull/66510/files
src: add MakeCallback() taking an Environmenthttps://redirect.github.com/nodejs/node/pull/66510#top
nigrosimonehttps://redirect.github.com/nigrosimone
nodejs:mainhttps://redirect.github.com/nodejs/node/tree/main
nigrosimone:makecallback-envhttps://redirect.github.com/nigrosimone/node/tree/makecallback-env
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Oct 4, 2026https://redirect.github.com/nodejs/node/pull/66510#issue-5700412991
#66509https://github.com/nodejs/node/pull/66509
#66395https://github.com/nodejs/node/pull/66395
#66500https://github.com/nodejs/node/pull/66500
nodejs/performance#24https://github.com/nodejs/performance/issues/24
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66510
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
Oct 4, 2026https://redirect.github.com/nodejs/node/pull/66510#issuecomment-5981314380
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66510
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
c++ https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 4, 2026https://redirect.github.com/nodejs/node/pull/66510#event-32448371710
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Oct 4, 2026 https://redirect.github.com/nodejs/node/pull/66510#ref-issue-1457032793
MakeCallback is very slow nodejs/performance#24 https://redirect.github.com/nodejs/performance/issues/24
https://redirect.github.com/legendecas
legendecashttps://redirect.github.com/legendecas
node-api https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Oct 9, 2026https://redirect.github.com/nodejs/node/pull/66510#event-32887151575
https://redirect.github.com/apps/github-project-automation
github-project-automationhttps://redirect.github.com/apps/github-project-automation
Node-API Team Projecthttps://redirect.github.com/orgs/nodejs/projects/11
Oct 9, 2026https://redirect.github.com/nodejs/node/pull/66510#event-32979400640
https://redirect.github.com/apps/github-project-automation
github-project-automationhttps://redirect.github.com/apps/github-project-automation
Node-API Team Projecthttps://redirect.github.com/orgs/nodejs/projects/11
Oct 9, 2026https://redirect.github.com/nodejs/node/pull/66510#event-33297977464
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/310f5451b1a58e63e483c10819b2535b535c4ef5..77584c54a44419160c4e9289883186140bf2aada
310f545https://redirect.github.com/nodejs/node/commit/310f5451b1a58e63e483c10819b2535b535c4ef5
77584c5https://redirect.github.com/nodejs/node/commit/77584c54a44419160c4e9289883186140bf2aada
Compare https://redirect.github.com/nodejs/node/compare/310f5451b1a58e63e483c10819b2535b535c4ef5..77584c54a44419160c4e9289883186140bf2aada
October 21, 2026 00:58https://redirect.github.com/nodejs/node/pull/66510#event-33799959318
https://redirect.github.com/ronag
ronaghttps://redirect.github.com/ronag
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66510#issuecomment-6742473306
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66510
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66510#issuecomment-6743468672
nodejs/performance#24https://github.com/nodejs/performance/issues/24
#66509https://github.com/nodejs/node/pull/66509
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66510
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/77584c54a44419160c4e9289883186140bf2aada..7383b33ace4ec74d9d292ba17cfe725fb61913e7
77584c5https://redirect.github.com/nodejs/node/commit/77584c54a44419160c4e9289883186140bf2aada
7383b33https://redirect.github.com/nodejs/node/commit/7383b33ace4ec74d9d292ba17cfe725fb61913e7
Compare https://redirect.github.com/nodejs/node/compare/77584c54a44419160c4e9289883186140bf2aada..7383b33ace4ec74d9d292ba17cfe725fb61913e7
November 9, 2026 15:27https://redirect.github.com/nodejs/node/pull/66510#event-35583865970
https://redirect.github.com/ronag
ronaghttps://redirect.github.com/ronag
anonrighttps://redirect.github.com/anonrig
jasnellhttps://redirect.github.com/jasnell
mcollinahttps://redirect.github.com/mcollina
November 9, 2026 15:41https://redirect.github.com/nodejs/node/pull/66510#event-35585335901
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/e7388cb23c8e878a431844bdce3ca427cf9f7a3c..0bf95f35173421d1214fb8bb9c7d07918cb9ffab
e7388cbhttps://redirect.github.com/nodejs/node/commit/e7388cb23c8e878a431844bdce3ca427cf9f7a3c
0bf95f3https://redirect.github.com/nodejs/node/commit/0bf95f35173421d1214fb8bb9c7d07918cb9ffab
Compare https://redirect.github.com/nodejs/node/compare/e7388cb23c8e878a431844bdce3ca427cf9f7a3c..0bf95f35173421d1214fb8bb9c7d07918cb9ffab
November 9, 2026 16:39https://redirect.github.com/nodejs/node/pull/66510#event-35590934698
nigrosimonehttps://redirect.github.com/nigrosimone
November 9, 2026 18:21https://redirect.github.com/nodejs/node/pull/66510#commits-pushed-4000c25
https://redirect.github.com/nigrosimone
node-api: find the Environment oncehttps://redirect.github.com/nodejs/node/pull/66510/commits/4000c257d83b86425357734a0486daf5b041e660
4000c25https://redirect.github.com/nodejs/node/pull/66510/commits/4000c257d83b86425357734a0486daf5b041e660
nodejs/performance#24https://github.com/nodejs/performance/issues/24
https://redirect.github.com/nigrosimone
src: add MakeCallback() taking an Environmenthttps://redirect.github.com/nodejs/node/pull/66510/commits/c07db1678646fbd628c6f76e1f8af618789c2f72
c07db16https://redirect.github.com/nodejs/node/pull/66510/commits/c07db1678646fbd628c6f76e1f8af618789c2f72
nodejs/performance#24https://github.com/nodejs/performance/issues/24
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/0bf95f35173421d1214fb8bb9c7d07918cb9ffab..c07db1678646fbd628c6f76e1f8af618789c2f72
0bf95f3https://redirect.github.com/nodejs/node/commit/0bf95f35173421d1214fb8bb9c7d07918cb9ffab
c07db16https://redirect.github.com/nodejs/node/commit/c07db1678646fbd628c6f76e1f8af618789c2f72
Compare https://redirect.github.com/nodejs/node/compare/0bf95f35173421d1214fb8bb9c7d07918cb9ffab..c07db1678646fbd628c6f76e1f8af618789c2f72
November 9, 2026 17:22https://redirect.github.com/nodejs/node/pull/66510#event-35594993782
https://github.co/hiddenchars
https://redirect.github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://redirect.github.com/join?source=comment-repo
Sign in to commenthttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66510
https://redirect.github.com/mcollina
mcollina https://redirect.github.com/mcollina
https://redirect.github.com/anonrig
anonrig https://redirect.github.com/anonrig
https://redirect.github.com/jasnell
jasnell https://redirect.github.com/jasnell
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66510
c++ https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node-api https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Node-API Team Project https://redirect.github.com/orgs/nodejs/projects/11
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66510
https://redirect.github.com/nigrosimone
https://redirect.github.com/nodejs-github-bot
https://redirect.github.com/ronag
https://redirect.github.com/legendecas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.