René's URL Explorer Experiment


Title: node-api: find the Environment once by nigrosimone · Pull Request #66509 · nodejs/node · GitHub

Open Graph Title: node-api: find the Environment once by nigrosimone · Pull Request #66509 · nodejs/node

X Title: node-api: find the Environment once by nigrosimone · Pull Request #66509 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Without an async context, napi_make_callback goes through the public node::MakeCallback(), which looks up the Environment from the creation context of the callback on every call. The napi_env alrea...

X Description: Without an async context, napi_make_callback goes through the public node::MakeCallback(), which looks up the Environment from the creation context of the callback on every call. The napi_env alrea...

Opengraph URL: https://github.com/nodejs/node/pull/66509

X: @github

direct link

Domain: redirect.github.com

IPv4 address: 140.82.113.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c91a870f-e4e1-c3c7-e652-a9046171e10b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6F0:1D39D6:15916:1B9FB:6B03650A
html-safe-nonceb7a4a567c6b14f895c2da6505fffc7842c4479b483389cf6a9224a615c11ccb4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkYwOjFEMzlENjoxNTkxNjoxQjlGQjo2QjAzNjUwQSIsInZpc2l0b3JfaWQiOiIzODEzODExNDUzMTc4MzczMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacca2929666d9fba8d5794f560d2e58e4692c3098240c55576b5663550d6ca8ad8
hovercard-subject-tagpull_request:4735274709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66509/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/845b9713ec2c73a31060b6de4c574dca5f64df88624461fb70294b538ef60f2b/nodejs/node/pull/66509
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/845b9713ec2c73a31060b6de4c574dca5f64df88624461fb70294b538ef60f2b/nodejs/node/pull/66509
og:image:altWithout an async context, napi_make_callback goes through the public node::MakeCallback(), which looks up the Environment from the creation context of the callback on every call. The napi_env alrea...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenigrosimone
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://redirect.github.com/nodejs/node/pull/66509#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66509
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66509
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://redirect.github.com/nodejs/node/pull/66509
Reloadhttps://redirect.github.com/nodejs/node/pull/66509
Reloadhttps://redirect.github.com/nodejs/node/pull/66509
nodejshttps://redirect.github.com/nodejs
nodehttps://redirect.github.com/nodejs/node
Codehttps://redirect.github.com/nodejs/node
Issues639 (639)https://redirect.github.com/nodejs/node/issues
Pull requests667 (667)https://redirect.github.com/nodejs/node/pulls
Actionshttps://redirect.github.com/nodejs/node/actions
Projectshttps://redirect.github.com/nodejs/node/projects
Security and qualityhttps://redirect.github.com/nodejs/node/security
Insightshttps://redirect.github.com/nodejs/node/insights
https://redirect.github.com/nodejs/node
nigrosimonehttps://redirect.github.com/nigrosimone
nodejs:mainhttps://redirect.github.com/nodejs/node/tree/main
nigrosimone:napi-make-callback-envhttps://redirect.github.com/nigrosimone/node/tree/napi-make-callback-env
Conversationhttps://redirect.github.com/nodejs/node/pull/66509
Commits1 (1)https://redirect.github.com/nodejs/node/pull/66509/commits
Checkshttps://redirect.github.com/nodejs/node/pull/66509/checks
Files changedhttps://redirect.github.com/nodejs/node/pull/66509/files
node-api: find the Environment oncehttps://redirect.github.com/nodejs/node/pull/66509#top
nigrosimonehttps://redirect.github.com/nigrosimone
nodejs:mainhttps://redirect.github.com/nodejs/node/tree/main
nigrosimone:napi-make-callback-envhttps://redirect.github.com/nigrosimone/node/tree/napi-make-callback-env
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Oct 4, 2026https://redirect.github.com/nodejs/node/pull/66509#issue-5700412604
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
#66316https://github.com/nodejs/node/pull/66316
#66395https://github.com/nodejs/node/pull/66395
#66500https://github.com/nodejs/node/pull/66500
nodejs/performance#24https://github.com/nodejs/performance/issues/24
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Oct 4, 2026 https://redirect.github.com/nodejs/node/pull/66509#ref-pullrequest-5700412991
src: add MakeCallback() taking an Environment #66510 https://redirect.github.com/nodejs/node/pull/66510
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
Oct 4, 2026https://redirect.github.com/nodejs/node/pull/66509#issuecomment-5981313925
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
c++ https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 4, 2026https://redirect.github.com/nodejs/node/pull/66509#event-32448371597
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Oct 4, 2026 https://redirect.github.com/nodejs/node/pull/66509#ref-issue-1457032793
MakeCallback is very slow nodejs/performance#24 https://redirect.github.com/nodejs/performance/issues/24
https://redirect.github.com/legendecas
legendecashttps://redirect.github.com/legendecas
node-api https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Oct 9, 2026https://redirect.github.com/nodejs/node/pull/66509#event-32887088789
https://redirect.github.com/apps/github-project-automation
github-project-automationhttps://redirect.github.com/apps/github-project-automation
Node-API Team Projecthttps://redirect.github.com/orgs/nodejs/projects/11
Oct 9, 2026https://redirect.github.com/nodejs/node/pull/66509#event-32979381901
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/b72903097bf5cf69719a3c06dd157731f9947374..1a639d6303de73547e838476d083c0b4d1c03a6d
b729030https://redirect.github.com/nodejs/node/commit/b72903097bf5cf69719a3c06dd157731f9947374
1a639d6https://redirect.github.com/nodejs/node/commit/1a639d6303de73547e838476d083c0b4d1c03a6d
Compare https://redirect.github.com/nodejs/node/compare/b72903097bf5cf69719a3c06dd157731f9947374..1a639d6303de73547e838476d083c0b4d1c03a6d
October 21, 2026 00:58https://redirect.github.com/nodejs/node/pull/66509#event-33799958014
https://redirect.github.com/ronag
ronaghttps://redirect.github.com/ronag
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6742471825
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
November 9, 2026 15:09https://redirect.github.com/nodejs/node/pull/66509#event-35582105680
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6743467984
#66395https://github.com/nodejs/node/pull/66395
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/1a639d6303de73547e838476d083c0b4d1c03a6d..64bedaad2d3ec861dc122038d3177c96cfcd9e78
1a639d6https://redirect.github.com/nodejs/node/commit/1a639d6303de73547e838476d083c0b4d1c03a6d
64bedaahttps://redirect.github.com/nodejs/node/commit/64bedaad2d3ec861dc122038d3177c96cfcd9e78
Compare https://redirect.github.com/nodejs/node/compare/1a639d6303de73547e838476d083c0b4d1c03a6d..64bedaad2d3ec861dc122038d3177c96cfcd9e78
November 9, 2026 15:26https://redirect.github.com/nodejs/node/pull/66509#event-35583861804
https://redirect.github.com/ronag
ronaghttps://redirect.github.com/ronag
Nov 9, 2026 https://redirect.github.com/nodejs/node/pull/66509#pullrequestreview-5828345390
View reviewed changes https://redirect.github.com/nodejs/node/pull/66509/files
https://redirect.github.com/mcollina
mcollinahttps://redirect.github.com/mcollina
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6744654535
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/5bcd17122dbb48da6ab3a67d599e7c83f3f14eb8..f911f827e818ce128ea20ec8934352c61aeb3ba5
5bcd171https://redirect.github.com/nodejs/node/commit/5bcd17122dbb48da6ab3a67d599e7c83f3f14eb8
f911f82https://redirect.github.com/nodejs/node/commit/f911f827e818ce128ea20ec8934352c61aeb3ba5
Compare https://redirect.github.com/nodejs/node/compare/5bcd17122dbb48da6ab3a67d599e7c83f3f14eb8..f911f827e818ce128ea20ec8934352c61aeb3ba5
November 9, 2026 16:39https://redirect.github.com/nodejs/node/pull/66509#event-35590929846
https://redirect.github.com/ronag
ronaghttps://redirect.github.com/ronag
request-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66509#event-35593404787
https://redirect.github.com/nigrosimone
node-api: find the Environment oncehttps://redirect.github.com/nodejs/node/pull/66509/commits/4000c257d83b86425357734a0486daf5b041e660
4000c25https://redirect.github.com/nodejs/node/pull/66509/commits/4000c257d83b86425357734a0486daf5b041e660
nodejs/performance#24https://github.com/nodejs/performance/issues/24
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
force-pushedhttps://redirect.github.com/nodejs/node/compare/f911f827e818ce128ea20ec8934352c61aeb3ba5..4000c257d83b86425357734a0486daf5b041e660
f911f82https://redirect.github.com/nodejs/node/commit/f911f827e818ce128ea20ec8934352c61aeb3ba5
4000c25https://redirect.github.com/nodejs/node/commit/4000c257d83b86425357734a0486daf5b041e660
Compare https://redirect.github.com/nodejs/node/compare/f911f827e818ce128ea20ec8934352c61aeb3ba5..4000c257d83b86425357734a0486daf5b041e660
November 9, 2026 17:22https://redirect.github.com/nodejs/node/pull/66509#event-35594989496
https://redirect.github.com/nigrosimone
nigrosimonehttps://redirect.github.com/nigrosimone
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6748561493
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://redirect.github.com/apps/codecov
codecovhttps://redirect.github.com/apps/codecov
Nov 9, 2026https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6748562078
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66509?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
3e5c8afhttps://app.codecov.io/gh/nodejs/node/commit/3e5c8afba6dcff91d46b8204276d62e3843b23b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4000c25https://app.codecov.io/gh/nodejs/node/commit/4000c257d83b86425357734a0486daf5b041e660?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66509?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_api.cchttps://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_api.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYXBpLmNj
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66509?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/api/callback.cchttps://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fapi%2Fcallback.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9jYWxsYmFjay5jYw==
src/node_api_internals.hhttps://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_api_internals.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYXBpX2ludGVybmFscy5o
src/node_internals.hhttps://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_internals.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaW50ZXJuYWxzLmg=
src/node_api.cchttps://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_api.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYXBpLmNj
545 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66509/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://github.co/hiddenchars
https://redirect.github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://redirect.github.com/join?source=comment-repo
Sign in to commenthttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66509
https://redirect.github.com/ronag
ronag https://redirect.github.com/ronag
https://redirect.github.com/nodejs/node/pull/66509/files/64bedaad2d3ec861dc122038d3177c96cfcd9e78
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
c++ https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node-api https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
request-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Node-API Team Project https://redirect.github.com/orgs/nodejs/projects/11
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/66509
https://redirect.github.com/nigrosimone
https://redirect.github.com/nodejs-github-bot
https://redirect.github.com/ronag
https://redirect.github.com/mcollina
https://redirect.github.com/legendecas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.