| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c91a870f-e4e1-c3c7-e652-a9046171e10b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E6F0:1D39D6:15916:1B9FB:6B03650A |
| html-safe-nonce | b7a4a567c6b14f895c2da6505fffc7842c4479b483389cf6a9224a615c11ccb4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkYwOjFEMzlENjoxNTkxNjoxQjlGQjo2QjAzNjUwQSIsInZpc2l0b3JfaWQiOiIzODEzODExNDUzMTc4MzczMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ca2929666d9fba8d5794f560d2e58e4692c3098240c55576b5663550d6ca8ad8 |
| hovercard-subject-tag | pull_request:4735274709 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66509/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/845b9713ec2c73a31060b6de4c574dca5f64df88624461fb70294b538ef60f2b/nodejs/node/pull/66509 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/845b9713ec2c73a31060b6de4c574dca5f64df88624461fb70294b538ef60f2b/nodejs/node/pull/66509 |
| og:image:alt | Without an async context, napi_make_callback goes through the public node::MakeCallback(), which looks up the Environment from the creation context of the callback on every call. The napi_env alrea... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nigrosimone |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://redirect.github.com/nodejs/node/pull/66509#start-of-content |
| https://redirect.github.com/ |
| Sign in | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66509 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66509 |
| Sign up | https://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://redirect.github.com/nodejs/node/pull/66509 |
| Reload | https://redirect.github.com/nodejs/node/pull/66509 |
| Reload | https://redirect.github.com/nodejs/node/pull/66509 |
| nodejs | https://redirect.github.com/nodejs |
| node | https://redirect.github.com/nodejs/node |
| Code | https://redirect.github.com/nodejs/node |
| Issues639 (639) | https://redirect.github.com/nodejs/node/issues |
| Pull requests667 (667) | https://redirect.github.com/nodejs/node/pulls |
| Actions | https://redirect.github.com/nodejs/node/actions |
| Projects | https://redirect.github.com/nodejs/node/projects |
| Security and quality | https://redirect.github.com/nodejs/node/security |
| Insights | https://redirect.github.com/nodejs/node/insights |
| https://redirect.github.com/nodejs/node |
| nigrosimone | https://redirect.github.com/nigrosimone |
| nodejs:main | https://redirect.github.com/nodejs/node/tree/main |
| nigrosimone:napi-make-callback-env | https://redirect.github.com/nigrosimone/node/tree/napi-make-callback-env |
| Conversation | https://redirect.github.com/nodejs/node/pull/66509 |
| Commits1 (1) | https://redirect.github.com/nodejs/node/pull/66509/commits |
| Checks | https://redirect.github.com/nodejs/node/pull/66509/checks |
| Files changed | https://redirect.github.com/nodejs/node/pull/66509/files |
| node-api: find the Environment once | https://redirect.github.com/nodejs/node/pull/66509#top |
| nigrosimone | https://redirect.github.com/nigrosimone |
| nodejs:main | https://redirect.github.com/nodejs/node/tree/main |
| nigrosimone:napi-make-callback-env | https://redirect.github.com/nigrosimone/node/tree/napi-make-callback-env |
|
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| Oct 4, 2026 | https://redirect.github.com/nodejs/node/pull/66509#issue-5700412604 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| #66316 | https://github.com/nodejs/node/pull/66316 |
| #66395 | https://github.com/nodejs/node/pull/66395 |
| #66500 | https://github.com/nodejs/node/pull/66500 |
| nodejs/performance#24 | https://github.com/nodejs/performance/issues/24 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
|
Oct 4, 2026
| https://redirect.github.com/nodejs/node/pull/66509#ref-pullrequest-5700412991 |
|
src: add MakeCallback() taking an Environment
#66510
| https://redirect.github.com/nodejs/node/pull/66510 |
| https://redirect.github.com/nodejs-github-bot |
| nodejs-github-bot | https://redirect.github.com/nodejs-github-bot |
| Oct 4, 2026 | https://redirect.github.com/nodejs/node/pull/66509#issuecomment-5981313925 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| https://redirect.github.com/nodejs-github-bot |
| nodejs-github-bot | https://redirect.github.com/nodejs-github-bot |
|
c++
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Oct 4, 2026 | https://redirect.github.com/nodejs/node/pull/66509#event-32448371597 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
|
Oct 4, 2026
| https://redirect.github.com/nodejs/node/pull/66509#ref-issue-1457032793 |
|
MakeCallback is very slow
nodejs/performance#24
| https://redirect.github.com/nodejs/performance/issues/24 |
| https://redirect.github.com/legendecas |
| legendecas | https://redirect.github.com/legendecas |
|
node-api
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Oct 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#event-32887088789 |
| https://redirect.github.com/apps/github-project-automation |
| github-project-automation | https://redirect.github.com/apps/github-project-automation |
| Node-API Team Project | https://redirect.github.com/orgs/nodejs/projects/11 |
| Oct 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#event-32979381901 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| force-pushed | https://redirect.github.com/nodejs/node/compare/b72903097bf5cf69719a3c06dd157731f9947374..1a639d6303de73547e838476d083c0b4d1c03a6d |
| b729030 | https://redirect.github.com/nodejs/node/commit/b72903097bf5cf69719a3c06dd157731f9947374 |
| 1a639d6 | https://redirect.github.com/nodejs/node/commit/1a639d6303de73547e838476d083c0b4d1c03a6d |
|
Compare
| https://redirect.github.com/nodejs/node/compare/b72903097bf5cf69719a3c06dd157731f9947374..1a639d6303de73547e838476d083c0b4d1c03a6d |
| October 21, 2026 00:58 | https://redirect.github.com/nodejs/node/pull/66509#event-33799958014 |
| https://redirect.github.com/ronag |
| ronag | https://redirect.github.com/ronag |
| Nov 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6742471825 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| November 9, 2026 15:09 | https://redirect.github.com/nodejs/node/pull/66509#event-35582105680 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| Nov 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6743467984 |
| #66395 | https://github.com/nodejs/node/pull/66395 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| force-pushed | https://redirect.github.com/nodejs/node/compare/1a639d6303de73547e838476d083c0b4d1c03a6d..64bedaad2d3ec861dc122038d3177c96cfcd9e78 |
| 1a639d6 | https://redirect.github.com/nodejs/node/commit/1a639d6303de73547e838476d083c0b4d1c03a6d |
| 64bedaa | https://redirect.github.com/nodejs/node/commit/64bedaad2d3ec861dc122038d3177c96cfcd9e78 |
|
Compare
| https://redirect.github.com/nodejs/node/compare/1a639d6303de73547e838476d083c0b4d1c03a6d..64bedaad2d3ec861dc122038d3177c96cfcd9e78 |
| November 9, 2026 15:26 | https://redirect.github.com/nodejs/node/pull/66509#event-35583861804 |
| https://redirect.github.com/ronag |
| ronag | https://redirect.github.com/ronag |
|
Nov 9, 2026
| https://redirect.github.com/nodejs/node/pull/66509#pullrequestreview-5828345390 |
|
View reviewed changes
| https://redirect.github.com/nodejs/node/pull/66509/files |
| https://redirect.github.com/mcollina |
| mcollina | https://redirect.github.com/mcollina |
| Nov 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6744654535 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| force-pushed | https://redirect.github.com/nodejs/node/compare/5bcd17122dbb48da6ab3a67d599e7c83f3f14eb8..f911f827e818ce128ea20ec8934352c61aeb3ba5 |
| 5bcd171 | https://redirect.github.com/nodejs/node/commit/5bcd17122dbb48da6ab3a67d599e7c83f3f14eb8 |
| f911f82 | https://redirect.github.com/nodejs/node/commit/f911f827e818ce128ea20ec8934352c61aeb3ba5 |
|
Compare
| https://redirect.github.com/nodejs/node/compare/5bcd17122dbb48da6ab3a67d599e7c83f3f14eb8..f911f827e818ce128ea20ec8934352c61aeb3ba5 |
| November 9, 2026 16:39 | https://redirect.github.com/nodejs/node/pull/66509#event-35590929846 |
| https://redirect.github.com/ronag |
| ronag | https://redirect.github.com/ronag |
|
request-ci
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#event-35593404787 |
|
| https://redirect.github.com/nigrosimone |
| node-api: find the Environment once | https://redirect.github.com/nodejs/node/pull/66509/commits/4000c257d83b86425357734a0486daf5b041e660 |
| 4000c25 | https://redirect.github.com/nodejs/node/pull/66509/commits/4000c257d83b86425357734a0486daf5b041e660 |
| nodejs/performance#24 | https://github.com/nodejs/performance/issues/24 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| force-pushed | https://redirect.github.com/nodejs/node/compare/f911f827e818ce128ea20ec8934352c61aeb3ba5..4000c257d83b86425357734a0486daf5b041e660 |
| f911f82 | https://redirect.github.com/nodejs/node/commit/f911f827e818ce128ea20ec8934352c61aeb3ba5 |
| 4000c25 | https://redirect.github.com/nodejs/node/commit/4000c257d83b86425357734a0486daf5b041e660 |
|
Compare
| https://redirect.github.com/nodejs/node/compare/f911f827e818ce128ea20ec8934352c61aeb3ba5..4000c257d83b86425357734a0486daf5b041e660 |
| November 9, 2026 17:22 | https://redirect.github.com/nodejs/node/pull/66509#event-35594989496 |
| https://redirect.github.com/nigrosimone |
| nigrosimone | https://redirect.github.com/nigrosimone |
| Nov 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6748561493 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| https://redirect.github.com/apps/codecov |
| codecov | https://redirect.github.com/apps/codecov |
| Nov 9, 2026 | https://redirect.github.com/nodejs/node/pull/66509#issuecomment-6748562078 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/66509?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 3e5c8af | https://app.codecov.io/gh/nodejs/node/commit/3e5c8afba6dcff91d46b8204276d62e3843b23b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 4000c25 | https://app.codecov.io/gh/nodejs/node/commit/4000c257d83b86425357734a0486daf5b041e660?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/66509?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_api.cc | https://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_api.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYXBpLmNj |
| 0 Missing and 1 partial ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/66509?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/api/callback.cc | https://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fapi%2Fcallback.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9jYWxsYmFjay5jYw== |
| src/node_api_internals.h | https://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_api_internals.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYXBpX2ludGVybmFscy5o |
| src/node_internals.h | https://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_internals.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaW50ZXJuYWxzLmg= |
| src/node_api.cc | https://app.codecov.io/gh/nodejs/node/pull/66509?src=pr&el=tree&filepath=src%2Fnode_api.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYXBpLmNj |
| 545 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/66509/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
| https://github.co/hiddenchars |
| https://redirect.github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://redirect.github.com/join?source=comment-repo |
| Sign in to comment | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66509 |
|
| https://redirect.github.com/ronag |
|
ronag
| https://redirect.github.com/ronag |
|
| https://redirect.github.com/nodejs/node/pull/66509/files/64bedaad2d3ec861dc122038d3177c96cfcd9e78 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
|
c++
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
node-api
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
request-ci
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
Node-API Team Project
| https://redirect.github.com/orgs/nodejs/projects/11 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66509 |
|
| https://redirect.github.com/nigrosimone |
|
| https://redirect.github.com/nodejs-github-bot |
|
| https://redirect.github.com/ronag |
|
| https://redirect.github.com/mcollina |
|
| https://redirect.github.com/legendecas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |