| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d219493e-d28a-7228-8d30-8e6f7c2ae4e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8252:19B3CF:B29DEA:E16961:6B036C18 |
| html-safe-nonce | d657ad9d35f7427226d5f08ae988585959c600440c0757c3453fc97ef183bca8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjUyOjE5QjNDRjpCMjlERUE6RTE2OTYxOjZCMDM2QzE4IiwidmlzaXRvcl9pZCI6IjQyMDQ3MzA2NDA0OTY4MTUxMjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 41a9600d5b1a4b74e767f69558d02f3c7de8fb8b1a6c597a2efb455f64d02f16 |
| hovercard-subject-tag | pull_request:4604684754 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66210/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/90c8aabc04012258fae7f1735c034d76b92151bd394d71c8f717dc884f461c73/nodejs/node/pull/66210 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/90c8aabc04012258fae7f1735c034d76b92151bd394d71c8f717dc884f461c73/nodejs/node/pull/66210 |
| og:image:alt | Refs: #66202
Status: Closed. The intended behavior is still being decided in #66202, and
@christianaurichzm has a fix prepared there.
This PR changed lib/internal/http.js to use ?? instead of || wh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | barathraj048 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://redirect.github.com/nodejs/node/pull/66210#start-of-content |
| https://redirect.github.com/ |
| Sign in | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66210 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66210 |
| Sign up | https://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://redirect.github.com/nodejs/node/pull/66210 |
| Reload | https://redirect.github.com/nodejs/node/pull/66210 |
| Reload | https://redirect.github.com/nodejs/node/pull/66210 |
| nodejs | https://redirect.github.com/nodejs |
| node | https://redirect.github.com/nodejs/node |
| Code | https://redirect.github.com/nodejs/node |
| Issues639 (639) | https://redirect.github.com/nodejs/node/issues |
| Pull requests668 (668) | https://redirect.github.com/nodejs/node/pulls |
| Actions | https://redirect.github.com/nodejs/node/actions |
| Projects | https://redirect.github.com/nodejs/node/projects |
| Security and quality | https://redirect.github.com/nodejs/node/security |
| Insights | https://redirect.github.com/nodejs/node/insights |
| https://redirect.github.com/nodejs/node |
| barathraj048 | https://redirect.github.com/barathraj048 |
| nodejs:main | https://redirect.github.com/nodejs/node/tree/main |
| barathraj048:fix/http-proxy-env-empty-value | https://redirect.github.com/barathraj048/node-js/tree/fix/http-proxy-env-empty-value |
| Conversation | https://redirect.github.com/nodejs/node/pull/66210 |
| Commits1 (1) | https://redirect.github.com/nodejs/node/pull/66210/commits |
| Checks | https://redirect.github.com/nodejs/node/pull/66210/checks |
| Files changed | https://redirect.github.com/nodejs/node/pull/66210/files |
| http: align empty proxy env var handling with fetch() | https://redirect.github.com/nodejs/node/pull/66210#top |
| barathraj048 | https://redirect.github.com/barathraj048 |
| nodejs:main | https://redirect.github.com/nodejs/node/tree/main |
| barathraj048:fix/http-proxy-env-empty-value | https://redirect.github.com/barathraj048/node-js/tree/fix/http-proxy-env-empty-value |
|
| https://redirect.github.com/barathraj048 |
| barathraj048 | https://redirect.github.com/barathraj048 |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issue-5542649393 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| #66202 | https://github.com/nodejs/node/issues/66202 |
| #66202 | https://github.com/nodejs/node/issues/66202 |
| @christianaurichzm | https://github.com/christianaurichzm |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
|
| https://redirect.github.com/barathraj048 |
| http: align empty proxy env var handling with fetch() | https://redirect.github.com/nodejs/node/pull/66210/commits/371a26a772ba62d4e9bb07c7994aba62245fb0c5 |
| 371a26a | https://redirect.github.com/nodejs/node/pull/66210/commits/371a26a772ba62d4e9bb07c7994aba62245fb0c5 |
| nodejs#66202 | https://github.com/nodejs/node/issues/66202 |
| https://redirect.github.com/nodejs-github-bot |
| nodejs-github-bot | https://redirect.github.com/nodejs-github-bot |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issuecomment-5780577168 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://redirect.github.com/nodejs-github-bot |
| nodejs-github-bot | https://redirect.github.com/nodejs-github-bot |
|
http
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#event-31616932652 |
| https://redirect.github.com/apps/codecov |
| codecov | https://redirect.github.com/apps/codecov |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issuecomment-5781940362 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/66210?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 36dd044 | https://app.codecov.io/gh/nodejs/node/commit/36dd044cfdb20487951a83b75a3341af3025ca17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 371a26a | https://app.codecov.io/gh/nodejs/node/commit/371a26a772ba62d4e9bb07c7994aba62245fb0c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/66210?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/http.js | https://app.codecov.io/gh/nodejs/node/pull/66210?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAuanM= |
| 40 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/66210/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://redirect.github.com/MikeMcC399 |
| MikeMcC399 | https://redirect.github.com/MikeMcC399 |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issuecomment-5784156813 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| @barathraj048 | https://github.com/barathraj048 |
| #66202 | https://github.com/nodejs/node/issues/66202 |
| #66202 | https://github.com/nodejs/node/issues/66202 |
| @christianaurichzm | https://github.com/christianaurichzm |
| Developer Certificate of Origin | https://github.com/nodejs/node/blob/main/CONTRIBUTING.md#developers-certificate-of-origin-11 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://redirect.github.com/MikeMcC399 |
| MikeMcC399 | https://redirect.github.com/MikeMcC399 |
|
Sep 22, 2026
| https://redirect.github.com/nodejs/node/pull/66210#ref-issue-5538297472 |
|
fetch() and http.request() disagree when a lower-cased proxy env var is empty
#66202
| https://redirect.github.com/nodejs/node/issues/66202 |
| https://redirect.github.com/christianaurichzm |
| christianaurichzm | https://redirect.github.com/christianaurichzm |
|
Sep 22, 2026
| https://redirect.github.com/nodejs/node/pull/66210#pullrequestreview-5284612593 |
|
View reviewed changes
| https://redirect.github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5 |
| christianaurichzm | https://redirect.github.com/christianaurichzm |
| https://redirect.github.com/nodejs/node/pull/66210#pullrequestreview-5284612593 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #66202 | https://github.com/nodejs/node/issues/66202 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| lib/internal/http.js | https://redirect.github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f |
| christianaurichzm | https://redirect.github.com/christianaurichzm |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#discussion_r4077191323 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/barathraj048/node-js/blob/371a26a772ba62d4e9bb07c7994aba62245fb0c5/doc/api/http.md?plain=1#L221 | https://github.com/barathraj048/node-js/blob/371a26a772ba62d4e9bb07c7994aba62245fb0c5/doc/api/http.md?plain=1#L221 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| test/parallel/test-http-proxy-env-empty-value.js | https://redirect.github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-de108e00f6593f183f9c5cc6bee7a293988d04170ece11ed73981f881eb2f963 |
| christianaurichzm | https://redirect.github.com/christianaurichzm |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#discussion_r4077230309 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| test/parallel/test-http-proxy-env-empty-value.js | https://redirect.github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-de108e00f6593f183f9c5cc6bee7a293988d04170ece11ed73981f881eb2f963 |
| christianaurichzm | https://redirect.github.com/christianaurichzm |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#discussion_r4077231966 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| test/parallel/test-http-proxy-env-empty-value.js | https://redirect.github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-de108e00f6593f183f9c5cc6bee7a293988d04170ece11ed73981f881eb2f963 |
| christianaurichzm | https://redirect.github.com/christianaurichzm |
| Sep 22, 2026 | https://redirect.github.com/nodejs/node/pull/66210#discussion_r4077246421 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://redirect.github.com/barathraj048 |
| barathraj048 | https://redirect.github.com/barathraj048 |
| Sep 23, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issuecomment-5787609561 |
| @MikeMcC399 | https://github.com/MikeMcC399 |
| @christianaurichzm | https://github.com/christianaurichzm |
| #66202 | https://github.com/nodejs/node/issues/66202 |
| @christianaurichzm | https://github.com/christianaurichzm |
| @christianaurichzm | https://github.com/christianaurichzm |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://redirect.github.com/barathraj048 |
| barathraj048 | https://redirect.github.com/barathraj048 |
| Sep 23, 2026 | https://redirect.github.com/nodejs/node/pull/66210#event-31644258782 |
| https://redirect.github.com/MikeMcC399 |
| MikeMcC399 | https://redirect.github.com/MikeMcC399 |
| Sep 23, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issuecomment-5799433418 |
| #65952 | https://github.com/nodejs/node/pull/65952 |
| guide for first-time contributors | https://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md |
| contribution and automation policies | https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md |
| pull request guide | https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md |
| AI use policy | https://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md |
| Code of Conduct | https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://redirect.github.com/barathraj048 |
| barathraj048 | https://redirect.github.com/barathraj048 |
| Sep 24, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issuecomment-5806519199 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://redirect.github.com/barathraj048 |
| barathraj048 | https://redirect.github.com/barathraj048 |
| Sep 24, 2026 | https://redirect.github.com/nodejs/node/pull/66210#issuecomment-5806596521 |
| @MikeMcC399 | https://github.com/MikeMcC399 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
| https://github.co/hiddenchars |
| https://redirect.github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://redirect.github.com/join?source=comment-repo |
| Sign in to comment | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66210 |
|
| https://redirect.github.com/christianaurichzm |
|
christianaurichzm
| https://redirect.github.com/christianaurichzm |
|
| https://redirect.github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5 |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
|
http
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://redirect.github.com/nodejs/node/pull/66210 |
|
| https://redirect.github.com/barathraj048 |
|
| https://redirect.github.com/nodejs-github-bot |
|
| https://redirect.github.com/MikeMcC399 |
|
| https://redirect.github.com/christianaurichzm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |