René's URL Explorer Experiment


Title: stream: check done before backpressure in stream reader by watilde · Pull Request #63699 · nodejs/node · GitHub

Open Graph Title: stream: check done before backpressure in stream reader by watilde · Pull Request #63699 · nodejs/node

X Title: stream: check done before backpressure in stream reader by watilde · Pull Request #63699 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Opengraph URL: https://github.com/nodejs/node/pull/63699

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0fb3a9bf-9507-505f-af4a-494ab89bd57e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC98:39495A:D9CD1:12E2F1:6AFBB9A3
html-safe-nonce8a41114ca221546e7c8198c2c247066bd8ba6d3afd47a8f5fe7056b700f42fbe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzk4OjM5NDk1QTpEOUNEMToxMkUyRjE6NkFGQkI5QTMiLCJ2aXNpdG9yX2lkIjoiMTM3MzU2MDg0NDA0OTk1NTIzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac98d86e0a58e196673371153b488f056440b2e9146d9990c272262fc20e4a1c9c
hovercard-subject-tagpull_request:3782454801
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63699/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2edfc9cad58a022691e7de969b649d50151dd98c2a305946ff0e1fabd7e583aa/nodejs/node/pull/63699
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2edfc9cad58a022691e7de969b649d50151dd98c2a305946ff0e1fabd7e583aa/nodejs/node/pull/63699
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewatilde
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://redirect.github.com/nodejs/node/pull/63699#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://redirect.github.com/nodejs/node/pull/63699
Reloadhttps://redirect.github.com/nodejs/node/pull/63699
Reloadhttps://redirect.github.com/nodejs/node/pull/63699
nodejshttps://redirect.github.com/nodejs
nodehttps://redirect.github.com/nodejs/node
Codehttps://redirect.github.com/nodejs/node
Issues643 (643)https://redirect.github.com/nodejs/node/issues
Pull requests678 (678)https://redirect.github.com/nodejs/node/pulls
Actionshttps://redirect.github.com/nodejs/node/actions
Projectshttps://redirect.github.com/nodejs/node/projects
Security and qualityhttps://redirect.github.com/nodejs/node/security
Insightshttps://redirect.github.com/nodejs/node/pulse
https://redirect.github.com/nodejs/node
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
nodejs:mainhttps://redirect.github.com/nodejs/node/tree/main
watilde:stream-readhttps://redirect.github.com/watilde/node/tree/stream-read
Conversationhttps://redirect.github.com/nodejs/node/pull/63699
Commits1 (1)https://redirect.github.com/nodejs/node/pull/63699/commits
Checkshttps://redirect.github.com/nodejs/node/pull/63699/checks
Files changedhttps://redirect.github.com/nodejs/node/pull/63699/files
stream: check done before backpressure in stream readerhttps://redirect.github.com/nodejs/node/pull/63699#top
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
nodejs:mainhttps://redirect.github.com/nodejs/node/tree/main
watilde:stream-readhttps://redirect.github.com/watilde/node/tree/stream-read
https://redirect.github.com/watilde
watildehttps://redirect.github.com/watilde
Jun 1, 2026https://redirect.github.com/nodejs/node/pull/63699#issue-4564878602
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/watilde
stream: check done before backpressure in stream readerhttps://redirect.github.com/nodejs/node/pull/63699/commits/af459814ef0c5e30b0572000746af2ff7069b56c
af45981https://redirect.github.com/nodejs/node/pull/63699/commits/af459814ef0c5e30b0572000746af2ff7069b56c
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
Jun 1, 2026https://redirect.github.com/nodejs/node/pull/63699#issuecomment-4594721743
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
needs-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jun 1, 2026https://redirect.github.com/nodejs/node/pull/63699#event-26198344899
https://redirect.github.com/apps/codecov
codecovhttps://redirect.github.com/apps/codecov
Jun 1, 2026https://redirect.github.com/nodejs/node/pull/63699#issuecomment-4595363580
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63699?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
39b481bhttps://app.codecov.io/gh/nodejs/node/commit/39b481b5c510d3a12b6eea15a17681e6773d0b5d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
af45981https://app.codecov.io/gh/nodejs/node/commit/af459814ef0c5e30b0572000746af2ff7069b56c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63699?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/compose.jshttps://app.codecov.io/gh/nodejs/node/pull/63699?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fcompose.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvY29tcG9zZS5qcw==
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63699?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/compose.jshttps://app.codecov.io/gh/nodejs/node/pull/63699?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fcompose.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvY29tcG9zZS5qcw==
479 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63699/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/mcollina
mcollinahttps://redirect.github.com/mcollina
Jun 7, 2026 https://redirect.github.com/nodejs/node/pull/63699#pullrequestreview-4445159925
View reviewed changes https://redirect.github.com/nodejs/node/pull/63699/files/af459814ef0c5e30b0572000746af2ff7069b56c
mcollinahttps://redirect.github.com/mcollina
https://redirect.github.com/nodejs/node/pull/63699#pullrequestreview-4445159925
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/mcollina
mcollinahttps://redirect.github.com/mcollina
request-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 7, 2026https://redirect.github.com/nodejs/node/pull/63699#event-26440557367
https://redirect.github.com/apps/github-actions
github-actionshttps://redirect.github.com/apps/github-actions
request-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 7, 2026https://redirect.github.com/nodejs/node/pull/63699#event-26441210413
https://redirect.github.com/nodejs-github-bot
Sign in to viewhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
Jun 7, 2026https://redirect.github.com/nodejs/node/pull/63699#issuecomment-4643962068
https://ci.nodejs.org/job/node-test-pull-request/73950/https://ci.nodejs.org/job/node-test-pull-request/73950/
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/trivikr
trivikrhttps://redirect.github.com/trivikr
author ready https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 9, 2026https://redirect.github.com/nodejs/node/pull/63699#event-26503451592
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
commit-queue https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 9, 2026https://redirect.github.com/nodejs/node/pull/63699#event-26505270768
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
5498337https://redirect.github.com/nodejs/node/commit/549833792e416e6a127f209f5cae3b459e5e1251
Jun 9, 2026https://github.com/nodejs/node/pull/63699#event-26505273490
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/nodejs-github-bot
nodejs-github-bothttps://redirect.github.com/nodejs-github-bot
Jun 9, 2026https://redirect.github.com/nodejs/node/pull/63699#issuecomment-4656260130
5498337https://github.com/nodejs/node/commit/549833792e416e6a127f209f5cae3b459e5e1251
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/watilde
watildehttps://redirect.github.com/watilde
June 16, 2026 07:07https://redirect.github.com/nodejs/node/pull/63699#event-26795060440
aduh95https://redirect.github.com/aduh95
Jun 18, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-commit-10272a9
https://redirect.github.com/watilde
https://redirect.github.com/aduh95
stream: check done before backpressure in stream readerhttps://redirect.github.com/nodejs/node/commit/10272a94b62780c33082f528c54218e2408370d0
10272a9https://redirect.github.com/nodejs/node/commit/10272a94b62780c33082f528c54218e2408370d0
#63699https://github.com/nodejs/node/pull/63699
https://redirect.github.com/apps/github-actions
github-actionshttps://redirect.github.com/apps/github-actions
Jun 22, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://redirect.github.com/nodejs/node/pull/64058
aduh95https://redirect.github.com/aduh95
Jun 25, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-commit-97590e8
https://redirect.github.com/watilde
https://redirect.github.com/aduh95
stream: check done before backpressure in stream readerhttps://redirect.github.com/nodejs/node/commit/97590e8680e6ebc7edc0824c2977ec7d153dd002
97590e8https://redirect.github.com/nodejs/node/commit/97590e8680e6ebc7edc0824c2977ec7d153dd002
#63699https://github.com/nodejs/node/pull/63699
https://redirect.github.com/apps/github-actions
github-actionshttps://redirect.github.com/apps/github-actions
Jul 21, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-pullrequest-4939678359
2026-07-22, Version 24.19.0 'Krypton' (LTS) #64654 https://redirect.github.com/nodejs/node/pull/64654
aduh95https://redirect.github.com/aduh95
Jul 30, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-commit-915e3e2
https://redirect.github.com/watilde
https://redirect.github.com/aduh95
stream: check done before backpressure in stream readerhttps://redirect.github.com/nodejs/node/commit/915e3e2f42aed2c7b56b9347c1f7336021faf736
915e3e2https://redirect.github.com/nodejs/node/commit/915e3e2f42aed2c7b56b9347c1f7336021faf736
#63699https://github.com/nodejs/node/pull/63699
Exiklehttps://redirect.github.com/Exikle
Aug 8, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-commit-46cbbe7
https://redirect.github.com/apps/dusk-bot
feat(container): update image node (24.18.1 ➔ 24.19.0) (#1374)https://redirect.github.com/Exikle/home-infra/commit/46cbbe7e63d19134e6d8b33925944ad713d99c9a
46cbbe7https://redirect.github.com/Exikle/home-infra/commit/46cbbe7e63d19134e6d8b33925944ad713d99c9a
renovatehttps://redirect.github.com/apps/renovate
Aug 10, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-commit-1c07d5e
https://redirect.github.com/marketplace/renovate
⬆️ Update Node.js to v24.19.0https://redirect.github.com/gwennlbh/swarpc/commit/1c07d5e8ccdfb9fed2b82a9b2a5cb60e7b8b8d6c
1c07d5ehttps://redirect.github.com/gwennlbh/swarpc/commit/1c07d5e8ccdfb9fed2b82a9b2a5cb60e7b8b8d6c
https://redirect.github.com/robobun
robobunhttps://redirect.github.com/robobun
Sep 6, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-pullrequest-5363630823
node:stream: consume the compose() tail in flowing mode oven-sh/bun#41510 https://redirect.github.com/oven-sh/bun/pull/41510
robobunhttps://redirect.github.com/robobun
Sep 6, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-commit-c455555
https://redirect.github.com/robobun
node:stream: consume the compose() tail in flowing modehttps://redirect.github.com/oven-sh/bun/commit/c45555578f28e78f87c9494a7ba90aa7f14815d7
c455555https://redirect.github.com/oven-sh/bun/commit/c45555578f28e78f87c9494a7ba90aa7f14815d7
nodejs/node#63593https://github.com/nodejs/node/pull/63593
nodejs/node#63699https://github.com/nodejs/node/pull/63699
https://redirect.github.com/robobun
robobunhttps://redirect.github.com/robobun
Oct 29, 2026 https://redirect.github.com/nodejs/node/pull/63699#ref-pullrequest-6094725005
node:stream: finish the decoder in setEncoding() after the end, proxy the first own method in wrap() oven-sh/bun#47333 https://redirect.github.com/oven-sh/bun/pull/47333
https://github.co/hiddenchars
https://redirect.github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://redirect.github.com/join?source=comment-repo
Sign in to commenthttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
https://redirect.github.com/mcollina
mcollina https://redirect.github.com/mcollina
https://redirect.github.com/nodejs/node/pull/63699/files/af459814ef0c5e30b0572000746af2ff7069b56c
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
author ready https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://redirect.github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://redirect.github.com/nodejs/node/pull/63699
https://redirect.github.com/watilde
https://redirect.github.com/nodejs-github-bot
https://redirect.github.com/mcollina
https://redirect.github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.