Title: node-api,test: use local files for `instanceof` tests by vmoroz · Pull Request #60190 · nodejs/node · GitHub
Open Graph Title: node-api,test: use local files for `instanceof` tests by vmoroz · Pull Request #60190 · nodejs/node
X Title: node-api,test: use local files for `instanceof` tests by vmoroz · Pull Request #60190 · nodejs/node
Description: Make Node-API instanceof tests independent from V8 code. Currently test/js-native-api/test_general/testInstanceOf.js test file depends on two files from the V8 code: deps/v8/test/mjsunit/instanceof.js deps/v8/test/mjsunit/instanceof-2.js While it works for the Node.js project, it makes it difficult to reuse these tests for other JS engines and JS runtimes. In this PR we copy and adapt contents of these two V8 files to testV8Instanceof.js and testV8Instanceof2.js files. These are exactly the same tests as before, but they are now local to the test/js-native-api/test_general test.
Open Graph Description: Make Node-API instanceof tests independent from V8 code. Currently test/js-native-api/test_general/testInstanceOf.js test file depends on two files from the V8 code: deps/v8/test/mjsunit/instanceo...
X Description: Make Node-API instanceof tests independent from V8 code. Currently test/js-native-api/test_general/testInstanceOf.js test file depends on two files from the V8 code: deps/v8/test/mjsunit/instanceo...
Opengraph URL: https://github.com/nodejs/node/pull/60190
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:b9b60fb5-7cb1-2aa6-b334-ae2ae372e0df |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | CD30:1D6D:622682:853322:6992FFB2 |
| html-safe-nonce | 7b95447b62374f3261d35f2435533740604c1897e7bed8d386cc2b1040648ff7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDMwOjFENkQ6NjIyNjgyOjg1MzMyMjo2OTkyRkZCMiIsInZpc2l0b3JfaWQiOiI0NjUyMzc5MTUxNzAxMDQ5MjY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9c90bb915a66e24b1bf1ba6307c2d266da9be74576201e3378c543eaca5d6a30 |
| hovercard-subject-tag | pull_request:2902664359 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/60190/checks |
| twitter:image | https://avatars.githubusercontent.com/u/972834?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/972834?s=400&v=4 |
| og:image:alt | Make Node-API instanceof tests independent from V8 code. Currently test/js-native-api/test_general/testInstanceOf.js test file depends on two files from the V8 code: deps/v8/test/mjsunit/instanceo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 348cc0594c4976eb4050dc9547ecf65057ee89a2b7ed0652b983b9b539f57145 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 91a0a74305bca931ec621f52a6782246d341466f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width