René's URL Explorer Experiment


Title: :bug: Fakeclient: Update passed object in Apply by alvaroaleman · Pull Request #3283 · kubernetes-sigs/controller-runtime · GitHub

Open Graph Title: :bug: Fakeclient: Update passed object in Apply by alvaroaleman · Pull Request #3283 · kubernetes-sigs/controller-runtime

X Title: :bug: Fakeclient: Update passed object in Apply by alvaroaleman · Pull Request #3283 · kubernetes-sigs/controller-runtime

Description: Repo for the controller-runtime subproject of kubebuilder (sig-apimachinery) - :bug: Fakeclient: Update passed object in Apply by alvaroaleman · Pull Request #3283 · kubernetes-sigs/controller-runtime

Open Graph Description: Currently, the object that is passed into the fakeclients Apply will not get updated, this change fixes that. It also adds tests that validate that all mutating methods except Delete update the obj...

X Description: Currently, the object that is passed into the fakeclients Apply will not get updated, this change fixes that. It also adds tests that validate that all mutating methods except Delete update the obj...

Opengraph URL: https://github.com/kubernetes-sigs/controller-runtime/pull/3283

X: @github

direct link

Domain: redirect.github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:146c2b4a-c9b3-1da5-ca09-ff88dcaed690
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id823C:209605:90DF7:C8FD9:6992F434
html-safe-nonceff15c3becbbe14f7e0e004677b7938739a4a530f5432bce5f2f161cacdaa840b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjNDOjIwOTYwNTo5MERGNzpDOEZEOTo2OTkyRjQzNCIsInZpc2l0b3JfaWQiOiI0MzE0MzM3MDU5MTEwMzE5MTU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5e0649ed810fd517ac23e881c6b6187cb55734f073b5b9f734d67e7eef83084f
hovercard-subject-tagpull_request:2751395419
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/kubernetes-sigs/controller-runtime/3283/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/093980243e6fce30a35cdd1a6f86345af7b47b8bc4d7d77fa1eefa2c9ffc120b/kubernetes-sigs/controller-runtime/pull/3283
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/093980243e6fce30a35cdd1a6f86345af7b47b8bc4d7d77fa1eefa2c9ffc120b/kubernetes-sigs/controller-runtime/pull/3283
og:image:altCurrently, the object that is passed into the fakeclients Apply will not get updated, this change fixes that. It also adds tests that validate that all mutating methods except Delete update the obj...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealvaroaleman
hostnamegithub.com
expected-hostnamegithub.com
None348cc0594c4976eb4050dc9547ecf65057ee89a2b7ed0652b983b9b539f57145
turbo-cache-controlno-cache
go-importgithub.com/kubernetes-sigs/controller-runtime git https://github.com/kubernetes-sigs/controller-runtime.git
octolytics-dimension-user_id36015203
octolytics-dimension-user_loginkubernetes-sigs
octolytics-dimension-repository_id136494223
octolytics-dimension-repository_nwokubernetes-sigs/controller-runtime
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id136494223
octolytics-dimension-repository_network_root_nwokubernetes-sigs/controller-runtime
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasece72317238c729e85014e1d867fd30d09b7f94ba
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#start-of-content
https://redirect.github.com/
Sign in https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fkubernetes-sigs%2Fcontroller-runtime%2Fpull%2F3283
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fkubernetes-sigs%2Fcontroller-runtime%2Fpull%2F3283
Sign up https://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=kubernetes-sigs%2Fcontroller-runtime
Reloadhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
Reloadhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
Reloadhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
kubernetes-sigs https://redirect.github.com/kubernetes-sigs
controller-runtimehttps://redirect.github.com/kubernetes-sigs/controller-runtime
Notifications https://redirect.github.com/login?return_to=%2Fkubernetes-sigs%2Fcontroller-runtime
Fork 1.3k https://redirect.github.com/login?return_to=%2Fkubernetes-sigs%2Fcontroller-runtime
Star 2.9k https://redirect.github.com/login?return_to=%2Fkubernetes-sigs%2Fcontroller-runtime
Code https://redirect.github.com/kubernetes-sigs/controller-runtime
Issues 70 https://redirect.github.com/kubernetes-sigs/controller-runtime/issues
Pull requests 8 https://redirect.github.com/kubernetes-sigs/controller-runtime/pulls
Actions https://redirect.github.com/kubernetes-sigs/controller-runtime/actions
Projects 0 https://redirect.github.com/kubernetes-sigs/controller-runtime/projects
Security 0 https://redirect.github.com/kubernetes-sigs/controller-runtime/security
Insights https://redirect.github.com/kubernetes-sigs/controller-runtime/pulse
Code https://redirect.github.com/kubernetes-sigs/controller-runtime
Issues https://redirect.github.com/kubernetes-sigs/controller-runtime/issues
Pull requests https://redirect.github.com/kubernetes-sigs/controller-runtime/pulls
Actions https://redirect.github.com/kubernetes-sigs/controller-runtime/actions
Projects https://redirect.github.com/kubernetes-sigs/controller-runtime/projects
Security https://redirect.github.com/kubernetes-sigs/controller-runtime/security
Insights https://redirect.github.com/kubernetes-sigs/controller-runtime/pulse
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
kubernetes-sigs:mainhttps://redirect.github.com/kubernetes-sigs/controller-runtime/tree/main
alvaroaleman:fix-unmarshalhttps://redirect.github.com/alvaroaleman/controller-runtime/tree/fix-unmarshal
Conversationhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
Commits1 (1)https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283/commits
Checkshttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283/checks
Files changedhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283/files
🐛 Fakeclient: Update passed object in Applyhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#top
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
kubernetes-sigs:mainhttps://redirect.github.com/kubernetes-sigs/controller-runtime/tree/main
alvaroaleman:fix-unmarshalhttps://redirect.github.com/alvaroaleman/controller-runtime/tree/fix-unmarshal
https://redirect.github.com/alvaroaleman
alvaroalemanhttps://redirect.github.com/alvaroaleman
Aug 17, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#issue-3328492431
Please reload this pagehttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
cncf-cla: yes https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3A%22cncf-cla%3A%20yes%22
Aug 17, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#event-19191963589
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
joelanfordhttps://redirect.github.com/joelanford
troy0820https://redirect.github.com/troy0820
August 17, 2025 16:57https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#event-19191963626
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
approved https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3Aapproved
size/M https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3Asize%2FM
Aug 17, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#event-19191963666
https://redirect.github.com/alvaroaleman
🐛 Fakeclient: Update passed object in Applyhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283/commits/4bfda0b10b5281f6cd0aeee34138f560112f5616
4bfda0bhttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283/commits/4bfda0b10b5281f6cd0aeee34138f560112f5616
https://redirect.github.com/alvaroaleman
alvaroalemanhttps://redirect.github.com/alvaroaleman
force-pushedhttps://redirect.github.com/kubernetes-sigs/controller-runtime/compare/f3126bc5e290914e95bd6a23f51aedd062577d6a..4bfda0b10b5281f6cd0aeee34138f560112f5616
f3126bchttps://redirect.github.com/kubernetes-sigs/controller-runtime/commit/f3126bc5e290914e95bd6a23f51aedd062577d6a
4bfda0bhttps://redirect.github.com/kubernetes-sigs/controller-runtime/commit/4bfda0b10b5281f6cd0aeee34138f560112f5616
Compare https://redirect.github.com/kubernetes-sigs/controller-runtime/compare/f3126bc5e290914e95bd6a23f51aedd062577d6a..4bfda0b10b5281f6cd0aeee34138f560112f5616
August 17, 2025 17:03https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#event-19191982192
https://redirect.github.com/sbueringer
sbueringerhttps://redirect.github.com/sbueringer
Aug 18, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#issuecomment-3196157916
Please reload this pagehttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
sbueringerhttps://redirect.github.com/sbueringer
Aug 18, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#event-19201117529
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
lgtm https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3Algtm
Aug 18, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#event-19201117792
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
Aug 18, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#issuecomment-3196158235
Please reload this pagehttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
Aug 18, 2025https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283#issuecomment-3196158270
alvaroalemanhttps://github.com/kubernetes-sigs/controller-runtime/pull/3283
sbueringerhttps://github.com/kubernetes-sigs/controller-runtime/pull/3283#issuecomment-3196157916
herehttps://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fcontroller-runtime
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/kubernetes-sigs/controller-runtime/blob/main/OWNERS
Please reload this pagehttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
https://redirect.github.com/k8s-ci-robot
k8s-ci-robothttps://redirect.github.com/k8s-ci-robot
3554729https://redirect.github.com/kubernetes-sigs/controller-runtime/commit/3554729cfb3179c1a13f554b828d658d062dceb9
Aug 18, 2025https://github.com/kubernetes-sigs/controller-runtime/pull/3283#event-19201329132
Please reload this pagehttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
https://github.co/hiddenchars
https://redirect.github.com/kubernetes-sigs/controller-runtime/pull/{{ revealButtonHref }}
Sign up for freehttps://redirect.github.com/join?source=comment-repo
Sign in to commenthttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fkubernetes-sigs%2Fcontroller-runtime%2Fpull%2F3283
https://redirect.github.com/joelanford
joelanford https://redirect.github.com/joelanford
https://redirect.github.com/troy0820
troy0820 https://redirect.github.com/troy0820
https://redirect.github.com/sbueringer
sbueringer https://redirect.github.com/sbueringer
approved https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3Aapproved
cncf-cla: yes https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3A%22cncf-cla%3A%20yes%22
lgtm https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3Algtm
size/M https://redirect.github.com/kubernetes-sigs/controller-runtime/issues?q=state%3Aopen%20label%3Asize%2FM
Please reload this pagehttps://redirect.github.com/kubernetes-sigs/controller-runtime/pull/3283
https://redirect.github.com/alvaroaleman
https://redirect.github.com/sbueringer
https://redirect.github.com/k8s-ci-robot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.