René's URL Explorer Experiment


Title: [ConfigFetcher] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs by yashykt · Pull Request #37939 · grpc/grpc · GitHub

Open Graph Title: [ConfigFetcher] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs by yashykt · Pull Request #37939 · grpc/grpc

X Title: [ConfigFetcher] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs by yashykt · Pull Request #37939 · grpc/grpc

Description: C++ based gRPC (C++, Python, Ruby, Objective-C, PHP, C#) - [ConfigFetcher] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs by yashykt · Pull Request #37939 · grpc/grpc

Open Graph Description: With config fetching for an xDS enabled server, we were not doing graceful GOAWAYs for LDS updates. The correct process is - send a GOAWAY with max stream ID send PING to wait for RTT Finally, sen...

X Description: With config fetching for an xDS enabled server, we were not doing graceful GOAWAYs for LDS updates. The correct process is - send a GOAWAY with max stream ID send PING to wait for RTT Finally, sen...

Opengraph URL: https://github.com/grpc/grpc/pull/37939

X: @github

direct link

Domain: redirect.github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:49359d25-7440-0683-0505-de01240ed490
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA94:107233:451AE13:5CB64BD:6A65306E
html-safe-nonceee9ef32f215ce7473c1878ac544bcc0c6e6792667a1851b308cee6cc6150cef6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTk0OjEwNzIzMzo0NTFBRTEzOjVDQjY0QkQ6NkE2NTMwNkUiLCJ2aXNpdG9yX2lkIjoiODQ5NjMzMjE0NjcxMDIyOTEwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace5f343fb4c15e2bfa2c4a956b99215626b5aac7549e6885f1f8b6b7d7ccded83
hovercard-subject-tagpull_request:2130477126
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/grpc/grpc/37939/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/111aa043482e702034e096d0b2201a37abaf0efb81296b42fa0af4b4aac0729f/grpc/grpc/pull/37939
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/111aa043482e702034e096d0b2201a37abaf0efb81296b42fa0af4b4aac0729f/grpc/grpc/pull/37939
og:image:altWith config fetching for an xDS enabled server, we were not doing graceful GOAWAYs for LDS updates. The correct process is - send a GOAWAY with max stream ID send PING to wait for RTT Finally, sen...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyashykt
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-cache
go-importgithub.com/grpc/grpc git https://github.com/grpc/grpc.git
octolytics-dimension-user_id7802525
octolytics-dimension-user_logingrpc
octolytics-dimension-repository_id27729880
octolytics-dimension-repository_nwogrpc/grpc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27729880
octolytics-dimension-repository_network_root_nwogrpc/grpc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/grpc/grpc/pull/37939#start-of-content
https://redirect.github.com/
Sign in https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgrpc%2Fgrpc%2Fpull%2F37939
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgrpc%2Fgrpc%2Fpull%2F37939
Sign up https://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=grpc%2Fgrpc
Reloadhttps://redirect.github.com/grpc/grpc/pull/37939
Reloadhttps://redirect.github.com/grpc/grpc/pull/37939
Reloadhttps://redirect.github.com/grpc/grpc/pull/37939
Please reload this pagehttps://redirect.github.com/grpc/grpc/pull/37939
grpc https://redirect.github.com/grpc
grpchttps://redirect.github.com/grpc/grpc
Notifications https://redirect.github.com/login?return_to=%2Fgrpc%2Fgrpc
Fork 11.3k https://redirect.github.com/login?return_to=%2Fgrpc%2Fgrpc
Star 45.2k https://redirect.github.com/login?return_to=%2Fgrpc%2Fgrpc
Code https://redirect.github.com/grpc/grpc
Issues 677 https://redirect.github.com/grpc/grpc/issues
Pull requests 679 https://redirect.github.com/grpc/grpc/pulls
Discussions https://redirect.github.com/grpc/grpc/discussions
Actions https://redirect.github.com/grpc/grpc/actions
Projects https://redirect.github.com/grpc/grpc/projects
Security and quality 0 https://redirect.github.com/grpc/grpc/security
Insights https://redirect.github.com/grpc/grpc/pulse
Code https://redirect.github.com/grpc/grpc
Issues https://redirect.github.com/grpc/grpc/issues
Pull requests https://redirect.github.com/grpc/grpc/pulls
Discussions https://redirect.github.com/grpc/grpc/discussions
Actions https://redirect.github.com/grpc/grpc/actions
Projects https://redirect.github.com/grpc/grpc/projects
Security and quality https://redirect.github.com/grpc/grpc/security
Insights https://redirect.github.com/grpc/grpc/pulse
yashykthttps://redirect.github.com/yashykt
grpc:masterhttps://redirect.github.com/grpc/grpc/tree/master
yashykt:SendGoawayNoHttp2Errorhttps://redirect.github.com/yashykt/grpc/tree/SendGoawayNoHttp2Error
Conversationhttps://redirect.github.com/grpc/grpc/pull/37939
Commits1 (1)https://redirect.github.com/grpc/grpc/pull/37939/commits
Checkshttps://redirect.github.com/grpc/grpc/pull/37939/checks
Files changedhttps://redirect.github.com/grpc/grpc/pull/37939/files
[ConfigFetcher] Set HTTP2 error to NO_ERROR to do graceful GOAWAYshttps://redirect.github.com/grpc/grpc/pull/37939#top
yashykthttps://redirect.github.com/yashykt
grpc:masterhttps://redirect.github.com/grpc/grpc/tree/master
yashykt:SendGoawayNoHttp2Errorhttps://redirect.github.com/yashykt/grpc/tree/SendGoawayNoHttp2Error
https://redirect.github.com/yashykt
yashykthttps://redirect.github.com/yashykt
Oct 17, 2024https://redirect.github.com/grpc/grpc/pull/37939#issue-2595068422
Please reload this pagehttps://redirect.github.com/grpc/grpc/pull/37939
https://btx.cloud.google.com/invocations/041cafcd-334b-42dd-a797-cfd03c53048e/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_end2end_test@poller%3Dpoll;config=f78d0de70f525043d29a05fb7a78970999e04b7f8a87d8c4e974688bf7616998/loghttps://btx.cloud.google.com/invocations/041cafcd-334b-42dd-a797-cfd03c53048e/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_end2end_test@poller%3Dpoll;config=f78d0de70f525043d29a05fb7a78970999e04b7f8a87d8c4e974688bf7616998/log
Please reload this pagehttps://redirect.github.com/grpc/grpc/pull/37939
https://redirect.github.com/yashykt
[ConfigFetcher] Set HTTP2 error to NO_ERROR for graceful GOAWAYshttps://redirect.github.com/grpc/grpc/pull/37939/commits/ba47fede1b2b587141436420121973400551f06f
ba47fedhttps://redirect.github.com/grpc/grpc/pull/37939/commits/ba47fede1b2b587141436420121973400551f06f
https://redirect.github.com/yashykt
yashykthttps://redirect.github.com/yashykt
markdrothhttps://redirect.github.com/markdroth
October 17, 2024 15:26https://redirect.github.com/grpc/grpc/pull/37939#event-14701426745
https://redirect.github.com/apps/github-actions
github-actionshttps://redirect.github.com/apps/github-actions
lang/core https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Alang%2Fcore
Oct 17, 2024https://redirect.github.com/grpc/grpc/pull/37939#event-14701427535
https://redirect.github.com/yashykt
yashykthttps://redirect.github.com/yashykt
Oct 17, 2024https://redirect.github.com/grpc/grpc/pull/37939#event-14701429409
https://redirect.github.com/yashykt
yashykthttps://redirect.github.com/yashykt
release notes: yes https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3A%22release%20notes%3A%20yes%22
Oct 17, 2024https://redirect.github.com/grpc/grpc/pull/37939#event-14701449542
https://redirect.github.com/markdroth
markdrothhttps://redirect.github.com/markdroth
Oct 17, 2024 https://redirect.github.com/grpc/grpc/pull/37939#pullrequestreview-2375597944
View reviewed changes https://redirect.github.com/grpc/grpc/pull/37939/files/ba47fede1b2b587141436420121973400551f06f
https://redirect.github.com/apps/grpc-checks
grpc-checkshttps://redirect.github.com/apps/grpc-checks
bloat/none https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Abloat%2Fnone
per-call-memory/decrease https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Aper-call-memory%2Fdecrease
per-channel-memory/neutral https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Aper-channel-memory%2Fneutral
Oct 17, 2024https://redirect.github.com/grpc/grpc/pull/37939#event-14701819487
https://redirect.github.com/apps/copybara-service
copybara-servicehttps://redirect.github.com/apps/copybara-service
5c5bf14https://redirect.github.com/grpc/grpc/commit/5c5bf14fde78e2892cbfe9285c5c8d40ba576df0
Oct 17, 2024https://redirect.github.com/grpc/grpc/pull/37939#event-14702578618
paulosjcahttps://redirect.github.com/paulosjca
Nov 25, 2024 https://redirect.github.com/grpc/grpc/pull/37939#ref-commit-2a09e16
https://redirect.github.com/yashykt
https://redirect.github.com/paulosjca
[ConfigFetcher] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs (https://redirect.github.com/paulosjca/grpc/commit/2a09e1667b9d4fa673ee3c78a31f4efb08d7f316
g…https://github.com/grpc/grpc/pull/37939
2a09e16https://redirect.github.com/paulosjca/grpc/commit/2a09e1667b9d4fa673ee3c78a31f4efb08d7f316
…rpc#37939https://github.com/grpc/grpc/pull/37939
https://btx.cloud.google.com/invocations/041cafcd-334b-42dd-a797-cfd03c53048e/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_end2end_test@poller%3Dpoll;config=f78d0de70f525043d29a05fb7a78970999e04b7f8a87d8c4e974688bf7616998/loghttps://btx.cloud.google.com/invocations/041cafcd-334b-42dd-a797-cfd03c53048e/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_end2end_test@poller%3Dpoll;config=f78d0de70f525043d29a05fb7a78970999e04b7f8a87d8c4e974688bf7616998/log
grpc#37939https://github.com/grpc/grpc/pull/37939
grpc#37939https://github.com/grpc/grpc/pull/37939
ba47fedhttps://github.com/paulosjca/grpc/commit/ba47fede1b2b587141436420121973400551f06f
https://redirect.github.com/yashykt
yashykthttps://redirect.github.com/yashykt
Jan 23, 2025 https://redirect.github.com/grpc/grpc/pull/37939#ref-pullrequest-2805668942
[Chttp2Server] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs #38533 https://redirect.github.com/grpc/grpc/pull/38533
copybara-servicehttps://redirect.github.com/apps/copybara-service
Jan 23, 2025 https://redirect.github.com/grpc/grpc/pull/37939#ref-commit-3a9f914
https://redirect.github.com/yashykt
https://redirect.github.com/copybara-github
[Chttp2Server] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs (https://redirect.github.com/grpc/grpc/commit/3a9f91479dc6acaf45ca5b900163ba513277c767
#3…https://github.com/grpc/grpc/pull/38533
3a9f914https://redirect.github.com/grpc/grpc/commit/3a9f91479dc6acaf45ca5b900163ba513277c767
…8533https://github.com/grpc/grpc/pull/38533
#37939https://github.com/grpc/grpc/pull/37939
https://btx.cloud.google.com/invocations/f13563e3-f5a1-4ebf-ae09-2acc093f7dc1/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_security_end2end_test@experiment%3Dserver_listener;config=f8ddc3bebf5e6cc62f388a7fd7ea6691e7afaf3538ca2c553c67e20cbad53251/testshttps://btx.cloud.google.com/invocations/f13563e3-f5a1-4ebf-ae09-2acc093f7dc1/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_security_end2end_test@experiment%3Dserver_listener;config=f8ddc3bebf5e6cc62f388a7fd7ea6691e7afaf3538ca2c553c67e20cbad53251/tests
#38533https://github.com/grpc/grpc/pull/38533
#38533https://github.com/grpc/grpc/pull/38533
4dbef2chttps://github.com/grpc/grpc/commit/4dbef2c4d0fe80f27e43309fbc58bda84fa3f840
XuanWang-Amoshttps://redirect.github.com/XuanWang-Amos
Jan 28, 2025 https://redirect.github.com/grpc/grpc/pull/37939#ref-commit-3ffc682
https://redirect.github.com/yashykt
https://redirect.github.com/XuanWang-Amos
[Chttp2Server] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs (https://redirect.github.com/xrmx/grpc/commit/3ffc682a30634dc23e4119054898d5da4ddd18f6
gr…https://github.com/grpc/grpc/pull/38533
3ffc682https://redirect.github.com/xrmx/grpc/commit/3ffc682a30634dc23e4119054898d5da4ddd18f6
…pc#38533https://github.com/grpc/grpc/pull/38533
grpc#37939https://github.com/grpc/grpc/pull/37939
https://btx.cloud.google.com/invocations/f13563e3-f5a1-4ebf-ae09-2acc093f7dc1/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_security_end2end_test@experiment%3Dserver_listener;config=f8ddc3bebf5e6cc62f388a7fd7ea6691e7afaf3538ca2c553c67e20cbad53251/testshttps://btx.cloud.google.com/invocations/f13563e3-f5a1-4ebf-ae09-2acc093f7dc1/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_security_end2end_test@experiment%3Dserver_listener;config=f8ddc3bebf5e6cc62f388a7fd7ea6691e7afaf3538ca2c553c67e20cbad53251/tests
grpc#38533https://github.com/grpc/grpc/pull/38533
grpc#38533https://github.com/grpc/grpc/pull/38533
4dbef2chttps://github.com/xrmx/grpc/commit/4dbef2c4d0fe80f27e43309fbc58bda84fa3f840
paulosjcahttps://redirect.github.com/paulosjca
Feb 20, 2025 https://redirect.github.com/grpc/grpc/pull/37939#ref-commit-14770be
https://redirect.github.com/yashykt
https://redirect.github.com/paulosjca
[Chttp2Server] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs (https://redirect.github.com/paulosjca/grpc/commit/14770be238799e7ad3223b3b36cc79c236aa9562
gr…https://github.com/grpc/grpc/pull/38533
14770behttps://redirect.github.com/paulosjca/grpc/commit/14770be238799e7ad3223b3b36cc79c236aa9562
…pc#38533https://github.com/grpc/grpc/pull/38533
grpc#37939https://github.com/grpc/grpc/pull/37939
https://btx.cloud.google.com/invocations/f13563e3-f5a1-4ebf-ae09-2acc093f7dc1/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_security_end2end_test@experiment%3Dserver_listener;config=f8ddc3bebf5e6cc62f388a7fd7ea6691e7afaf3538ca2c553c67e20cbad53251/testshttps://btx.cloud.google.com/invocations/f13563e3-f5a1-4ebf-ae09-2acc093f7dc1/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_security_end2end_test@experiment%3Dserver_listener;config=f8ddc3bebf5e6cc62f388a7fd7ea6691e7afaf3538ca2c553c67e20cbad53251/tests
grpc#38533https://github.com/grpc/grpc/pull/38533
grpc#38533https://github.com/grpc/grpc/pull/38533
4dbef2chttps://github.com/paulosjca/grpc/commit/4dbef2c4d0fe80f27e43309fbc58bda84fa3f840
https://github.co/hiddenchars
https://redirect.github.com/grpc/grpc/pull/{{ revealButtonHref }}
Sign up for freehttps://redirect.github.com/join?source=comment-repo
Sign in to commenthttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgrpc%2Fgrpc%2Fpull%2F37939
https://redirect.github.com/markdroth
markdroth https://redirect.github.com/markdroth
https://redirect.github.com/grpc/grpc/pull/37939/files/ba47fede1b2b587141436420121973400551f06f
bloat/none https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Abloat%2Fnone
lang/core https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Alang%2Fcore
per-call-memory/decrease https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Aper-call-memory%2Fdecrease
per-channel-memory/neutral https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3Aper-channel-memory%2Fneutral
release notes: yes https://redirect.github.com/grpc/grpc/issues?q=state%3Aopen%20label%3A%22release%20notes%3A%20yes%22
Please reload this pagehttps://redirect.github.com/grpc/grpc/pull/37939
https://redirect.github.com/yashykt
https://redirect.github.com/markdroth
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.