René's URL Explorer Experiment


Title: Simplify circular default value validation by andimarek · Pull Request #4460 · graphql-java/graphql-java · GitHub

Open Graph Title: Simplify circular default value validation by andimarek · Pull Request #4460 · graphql-java/graphql-java

X Title: Simplify circular default value validation by andimarek · Pull Request #4460 · graphql-java/graphql-java

Description: Summary Ports the core circular-default validation simplifications from the merged 26.x backport in #4450 to master while retaining all existing master integration coverage. unify literal and programmatic default traversal in NoDefaultValueCircularRefs support programmatic iterable and Java array values through the same traversal detect input-object cycles from arguments before external default coercion can recursively expand them create fresh stateful schema validation rules for every validation run consolidate the lower-level circular-default Spock cases without removing CircularInputDefaultValuesTest Analysis The master implementation still had separate AST and external-value algorithms, retained validation-rule state across runs, and could reach external-value coercion before a circular default had been recorded. The #4450 implementation cleanup removes those failure modes and reduces the focused implementation and lower-level test code by 75 net lines. Unlike #4450, this PR intentionally preserves CircularInputDefaultValuesTest so the higher-level schema-build coverage and explicit SDL argument-default regression remain in place. Testing ./gradlew test --tests graphql.CircularInputDefaultValuesTest --tests graphql.schema.validation.NoDefaultValueCircularRefsTest --tests graphql.schema.validation.SchemaValidatorTest (25 tests) ./gradlew test (5,754 tests) ./gradlew check -x test -x testng All passed on Java 25.

Open Graph Description: Summary Ports the core circular-default validation simplifications from the merged 26.x backport in #4450 to master while retaining all existing master integration coverage. unify literal and prog...

X Description: Summary Ports the core circular-default validation simplifications from the merged 26.x backport in #4450 to master while retaining all existing master integration coverage. unify literal and prog...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4460

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ef295f77-8d84-50b4-c36d-edb0b7feb943
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5BA:3159C:B4EA49:EE69D7:6AED4B52
html-safe-noncee3c4ce6d5bf5437e558db57d022bf1aec00e3281f8c428d8f5e4ec880fb61ad7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUJBOjMxNTlDOkI0RUE0OTpFRTY5RDc6NkFFRDRCNTIiLCJ2aXNpdG9yX2lkIjoiMzg1MDcyMjU4NjgwMjM0MjczOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac20e2b4488c6cda75c6e53c241fc90784c87f2e6e594432af6ceb123bc131fab4
hovercard-subject-tagpull_request:4344151455
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4460/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altSummary Ports the core circular-default validation simplifications from the merged 26.x backport in #4450 to master while retaining all existing master integration coverage. unify literal and prog...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4460%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4460%2Ffiles
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
graphql-javahttps://redirect.github.com/graphql-java
graphql-javahttps://redirect.github.com/graphql-java/graphql-java
Codehttps://redirect.github.com/graphql-java/graphql-java
Issues27 (27)https://redirect.github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://redirect.github.com/graphql-java/graphql-java/pulls
Discussionshttps://redirect.github.com/graphql-java/graphql-java/discussions
Actionshttps://redirect.github.com/graphql-java/graphql-java/actions
Projectshttps://redirect.github.com/graphql-java/graphql-java/projects
Wikihttps://redirect.github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://redirect.github.com/graphql-java/graphql-java/security
Insightshttps://redirect.github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://redirect.github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://redirect.github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://redirect.github.com/andimarek
masterhttps://redirect.github.com/graphql-java/graphql-java/tree/master
codex/simplify-circular-default-validationhttps://redirect.github.com/graphql-java/graphql-java/tree/codex/simplify-circular-default-validation
Conversation 1 https://redirect.github.com/graphql-java/graphql-java/pull/4460
Commits 2 https://redirect.github.com/graphql-java/graphql-java/pull/4460/commits
Checks 11 https://redirect.github.com/graphql-java/graphql-java/pull/4460/checks
Files changed https://redirect.github.com/graphql-java/graphql-java/pull/4460/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
Simplify circular default value validation https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#top
Show all changes 2 commits https://redirect.github.com/graphql-java/graphql-java/pull/4460/files
3e617f0 Simplify circular default value validation andimarek Aug 23, 2026 https://redirect.github.com/graphql-java/graphql-java/pull/4460/commits/3e617f098769f9bfcff3edf342764f3ff5112b1f
f180dcf Restore circular default integration coverage andimarek Aug 23, 2026 https://redirect.github.com/graphql-java/graphql-java/pull/4460/commits/f180dcf5eb1106067c67c1420103ad8792dfec8e
Clear filters https://redirect.github.com/graphql-java/graphql-java/pull/4460/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
DefaultValuesAreValid.java https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-f3665dc61eed591657753e75e2239e288f4c696a9ee654b73b6dfa7644fa9827
NoDefaultValueCircularRefs.java https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-3632ac24a39cb30dc4901f8d09f502139b8cf6be9c4d655464462b9899e69a54
SchemaValidator.java https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
NoDefaultValueCircularRefsTest.groovy https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-835bbc969285cd4534e681979cafc50064e8f0a76f79ae967eb65d62b09a3d29
SchemaValidatorTest.groovy https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-05d8104f949be383f380a7f78a265bda004f807396548ff874d6b2337376db70
src/main/java/graphql/schema/validation/DefaultValuesAreValid.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-f3665dc61eed591657753e75e2239e288f4c696a9ee654b73b6dfa7644fa9827
View file https://redirect.github.com/graphql-java/graphql-java/blob/f180dcf5eb1106067c67c1420103ad8792dfec8e/src/main/java/graphql/schema/validation/DefaultValuesAreValid.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4460/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-f3665dc61eed591657753e75e2239e288f4c696a9ee654b73b6dfa7644fa9827
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-f3665dc61eed591657753e75e2239e288f4c696a9ee654b73b6dfa7644fa9827
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-f3665dc61eed591657753e75e2239e288f4c696a9ee654b73b6dfa7644fa9827
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-f3665dc61eed591657753e75e2239e288f4c696a9ee654b73b6dfa7644fa9827
src/main/java/graphql/schema/validation/NoDefaultValueCircularRefs.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-3632ac24a39cb30dc4901f8d09f502139b8cf6be9c4d655464462b9899e69a54
View file https://redirect.github.com/graphql-java/graphql-java/blob/f180dcf5eb1106067c67c1420103ad8792dfec8e/src/main/java/graphql/schema/validation/NoDefaultValueCircularRefs.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4460/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-3632ac24a39cb30dc4901f8d09f502139b8cf6be9c4d655464462b9899e69a54
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-3632ac24a39cb30dc4901f8d09f502139b8cf6be9c4d655464462b9899e69a54
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-3632ac24a39cb30dc4901f8d09f502139b8cf6be9c4d655464462b9899e69a54
src/main/java/graphql/schema/validation/SchemaValidator.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
View file https://redirect.github.com/graphql-java/graphql-java/blob/f180dcf5eb1106067c67c1420103ad8792dfec8e/src/main/java/graphql/schema/validation/SchemaValidator.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4460/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
https://redirect.github.com/graphql-java/graphql-java/pull/4460/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4460/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.