René's URL Explorer Experiment


Title: Simplify directive cycle detection by andimarek · Pull Request #4459 · graphql-java/graphql-java · GitHub

Open Graph Title: Simplify directive cycle detection by andimarek · Pull Request #4459 · graphql-java/graphql-java

X Title: Simplify directive cycle detection by andimarek · Pull Request #4459 · graphql-java/graphql-java

Description: Summary derive directive and input-type references on demand instead of precomputing a second graph use one ordered active path for cycle detection and diagnostic formatting preserve directive-definition, input object, enum, scalar, and extension cycle handling on master consolidate duplicate cycle tests and add acyclic plus master-specific type coverage This follows up on the simplification made in #4451 for 26.x, adapted to master’s broader directive-definition and input-type cycle support. Testing ./gradlew test --tests graphql.schema.idl.SchemaTypeDirectivesCheckerTest --tests graphql.schema.idl.SchemaGeneratorTest --tests graphql.schema.idl.DirectivesOnDirectiveDefinitionsTest ./gradlew clean test (5,753 tests) ./gradlew check -x test -x testng

Open Graph Description: Summary derive directive and input-type references on demand instead of precomputing a second graph use one ordered active path for cycle detection and diagnostic formatting preserve directive-def...

X Description: Summary derive directive and input-type references on demand instead of precomputing a second graph use one ordered active path for cycle detection and diagnostic formatting preserve directive-def...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4459

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:afb0c1a8-faf2-1f02-7c21-3e7d28ef79a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6DA:137C1B:EA225D:132F0DC:6AED5A0E
html-safe-nonce08e85bc4381fcd6c17af83ebd8e3f3ec6814236fd83b25936b1fc6473686bb38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkRBOjEzN0MxQjpFQTIyNUQ6MTMyRjBEQzo2QUVENUEwRSIsInZpc2l0b3JfaWQiOiI3MjY4NTEzNDA0Njc2ODIzNTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6bd8f5ae728801533a1afe8879b2a5d808511daab9d98218b990ef2b41b2ceff
hovercard-subject-tagpull_request:4344130735
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4459/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altSummary derive directive and input-type references on demand instead of precomputing a second graph use one ordered active path for cycle detection and diagnostic formatting preserve directive-def...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4459%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4459%2Ffiles
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
graphql-javahttps://redirect.github.com/graphql-java
graphql-javahttps://redirect.github.com/graphql-java/graphql-java
Codehttps://redirect.github.com/graphql-java/graphql-java
Issues27 (27)https://redirect.github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://redirect.github.com/graphql-java/graphql-java/pulls
Discussionshttps://redirect.github.com/graphql-java/graphql-java/discussions
Actionshttps://redirect.github.com/graphql-java/graphql-java/actions
Projectshttps://redirect.github.com/graphql-java/graphql-java/projects
Wikihttps://redirect.github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://redirect.github.com/graphql-java/graphql-java/security
Insightshttps://redirect.github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://redirect.github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://redirect.github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://redirect.github.com/andimarek
masterhttps://redirect.github.com/graphql-java/graphql-java/tree/master
codex/simplify-directive-cycle-detectionhttps://redirect.github.com/graphql-java/graphql-java/tree/codex/simplify-directive-cycle-detection
Conversation 1 https://redirect.github.com/graphql-java/graphql-java/pull/4459
Commits 1 https://redirect.github.com/graphql-java/graphql-java/pull/4459/commits
Checks 11 https://redirect.github.com/graphql-java/graphql-java/pull/4459/checks
Files changed https://redirect.github.com/graphql-java/graphql-java/pull/4459/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
Simplify directive cycle detection https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#top
Show all changes 1 commit https://redirect.github.com/graphql-java/graphql-java/pull/4459/files
12ba185 Simplify directive cycle detection andimarek Aug 23, 2026 https://redirect.github.com/graphql-java/graphql-java/pull/4459/commits/12ba1856158f6b7a414cbaaf05910400e92b28f0
Clear filters https://redirect.github.com/graphql-java/graphql-java/pull/4459/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
SchemaTypeDirectivesChecker.java https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
DirectivesOnDirectiveDefinitionsTest.groovy https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-bb0f111f83691018399bd55ec850feb8219a435044add60f74961aec5b2fda46
SchemaGeneratorTest.groovy https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-2936f6e762b5a3f1aa5570476494746c8b8125e8f8a48bc6567fdc746a87b65a
SchemaTypeDirectivesCheckerTest.groovy https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-a37820d6ba4c91ab6d6e9ce3e8f1d5bda21f3f00b2c4897ac79e8c52c41d6f92
src/main/java/graphql/schema/idl/SchemaTypeDirectivesChecker.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
View file https://redirect.github.com/graphql-java/graphql-java/blob/12ba1856158f6b7a414cbaaf05910400e92b28f0/src/main/java/graphql/schema/idl/SchemaTypeDirectivesChecker.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4459/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
src/test/groovy/graphql/schema/idl/DirectivesOnDirectiveDefinitionsTest.groovyhttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-bb0f111f83691018399bd55ec850feb8219a435044add60f74961aec5b2fda46
View file https://redirect.github.com/graphql-java/graphql-java/blob/12ba1856158f6b7a414cbaaf05910400e92b28f0/src/test/groovy/graphql/schema/idl/DirectivesOnDirectiveDefinitionsTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4459/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-bb0f111f83691018399bd55ec850feb8219a435044add60f74961aec5b2fda46
https://redirect.github.com/graphql-java/graphql-java/pull/4459/files#diff-bb0f111f83691018399bd55ec850feb8219a435044add60f74961aec5b2fda46
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4459/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.