René's URL Explorer Experiment


Title: Backport 26.1: Mark InstrumentationState callback params as @Nullable by andimarek · Pull Request #4457 · graphql-java/graphql-java · GitHub

Open Graph Title: Backport 26.1: Mark InstrumentationState callback params as @Nullable by andimarek · Pull Request #4457 · graphql-java/graphql-java

X Title: Backport 26.1: Mark InstrumentationState callback params as @Nullable by andimarek · Pull Request #4457 · graphql-java/graphql-java

Description: Backport of #4435 to the 26.x maintenance branch. Summary mark instrumentation callback InstrumentationState parameters as @Nullable, matching the existing optional-state runtime contract propagate nullable child states through ChainedInstrumentation and NoContextChainedInstrumentation cover the Kotlin-facing signatures with compile fixtures exercised by Spock retain the existing 26.x field-fetching implementation while applying the nullability fix This backports the fix for #4433. Kotlin implementations overriding these callbacks must declare the state parameter as InstrumentationState?. Verification ./gradlew test --tests graphql.execution.instrumentation.InstrumentationStateNullabilityTest --tests graphql.execution.instrumentation.InstrumentationTest --tests graphql.execution.instrumentation.ChainedInstrumentationStateTest --tests graphql.execution.instrumentation.NoContextChainedInstrumentationTest --tests graphql.execution.instrumentation.TracingInstrumentationTest 28 focused tests passed Kotlin compilation and NullAway/ErrorProne checks passed as part of the build

Open Graph Description: Backport of #4435 to the 26.x maintenance branch. Summary mark instrumentation callback InstrumentationState parameters as @Nullable, matching the existing optional-state runtime contract propagat...

X Description: Backport of #4435 to the 26.x maintenance branch. Summary mark instrumentation callback InstrumentationState parameters as @Nullable, matching the existing optional-state runtime contract propagat...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4457

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1c62e595-dccf-ec2e-b635-5a2cb2e14961
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8AC:3B3F35:E11F6E:12803DA:6AED596E
html-safe-nonce4303205804cc82f43c23023d2adc44060624c55764ca7e60ba8b14e2738eb63e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEFDOjNCM0YzNTpFMTFGNkU6MTI4MDNEQTo2QUVENTk2RSIsInZpc2l0b3JfaWQiOiI1ODk3NTQxMzQ1MzY5NDc5NTM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace94c86a869cecfd272eca74209d06895bdc72d1e9924994f02cc8a798d16d12f
hovercard-subject-tagpull_request:4341694072
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4457/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altBackport of #4435 to the 26.x maintenance branch. Summary mark instrumentation callback InstrumentationState parameters as @Nullable, matching the existing optional-state runtime contract propagat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4457%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4457%2Ffiles
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
Reloadhttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
graphql-javahttps://redirect.github.com/graphql-java
graphql-javahttps://redirect.github.com/graphql-java/graphql-java
Codehttps://redirect.github.com/graphql-java/graphql-java
Issues27 (27)https://redirect.github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://redirect.github.com/graphql-java/graphql-java/pulls
Discussionshttps://redirect.github.com/graphql-java/graphql-java/discussions
Actionshttps://redirect.github.com/graphql-java/graphql-java/actions
Projectshttps://redirect.github.com/graphql-java/graphql-java/projects
Wikihttps://redirect.github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://redirect.github.com/graphql-java/graphql-java/security
Insightshttps://redirect.github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://redirect.github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://redirect.github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://redirect.github.com/andimarek
26.xhttps://redirect.github.com/graphql-java/graphql-java/tree/26.x
codex/backport-4435-to-26.xhttps://redirect.github.com/graphql-java/graphql-java/tree/codex/backport-4435-to-26.x
Conversation 1 https://redirect.github.com/graphql-java/graphql-java/pull/4457
Commits 2 https://redirect.github.com/graphql-java/graphql-java/pull/4457/commits
Checks 10 https://redirect.github.com/graphql-java/graphql-java/pull/4457/checks
Files changed https://redirect.github.com/graphql-java/graphql-java/pull/4457/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
Backport 26.1: Mark InstrumentationState callback params as @Nullable https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#top
Show all changes 2 commits https://redirect.github.com/graphql-java/graphql-java/pull/4457/files
ac661d0 fix: mark InstrumentationState callback params as @Nullable arimu1 Aug 5, 2026 https://redirect.github.com/graphql-java/graphql-java/pull/4457/commits/ac661d02bf7191714d6b6c41bd5be48d31632547
9be7527 Propagate nullable chained instrumentation state andimarek Aug 22, 2026 https://redirect.github.com/graphql-java/graphql-java/pull/4457/commits/9be75270d5a1718950e8a69040e95abe2b3ec55f
Clear filters https://redirect.github.com/graphql-java/graphql-java/pull/4457/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
MaxQueryComplexityInstrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
MaxQueryDepthInstrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
ChainedInstrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
Instrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
NoContextChainedInstrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-459659067e9535e1092db1146e4dba6dba82a5e41f1fef9ff85771b66077737e
SimplePerformantInstrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-6499bea408dbce71c903fa245398d9fd16ab0dc43481ec2ee96d3f3a219184b4
FieldValidationInstrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-471d3138f07fdc2cd335b1b5864c20bfc15024a260cc4c9165f4a94dee03f300
TracingInstrumentation.java https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-f079b472d438a589a24a6924fe1dadf2d2e686dd12847ec150eff68d727244db
InstrumentationStateNullabilityTest.groovy https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-6e74280dbc8dc97c5253bbf0fd2f7fce6fcb00c949a9b8fd16657848453da1cd
KotlinInstrumentationStateFixtures.kt https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-ad6765675fd51e6f4b1d957b25cd03d689e6562491ce3e8471ff0fe5f05165f5
src/main/java/graphql/analysis/MaxQueryComplexityInstrumentation.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
View file https://redirect.github.com/graphql-java/graphql-java/blob/9be75270d5a1718950e8a69040e95abe2b3ec55f/src/main/java/graphql/analysis/MaxQueryComplexityInstrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4457/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
src/main/java/graphql/analysis/MaxQueryDepthInstrumentation.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
View file https://redirect.github.com/graphql-java/graphql-java/blob/9be75270d5a1718950e8a69040e95abe2b3ec55f/src/main/java/graphql/analysis/MaxQueryDepthInstrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4457/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
src/main/java/graphql/execution/instrumentation/ChainedInstrumentation.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
View file https://redirect.github.com/graphql-java/graphql-java/blob/9be75270d5a1718950e8a69040e95abe2b3ec55f/src/main/java/graphql/execution/instrumentation/ChainedInstrumentation.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
src/main/java/graphql/execution/instrumentation/Instrumentation.javahttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
View file https://redirect.github.com/graphql-java/graphql-java/blob/9be75270d5a1718950e8a69040e95abe2b3ec55f/src/main/java/graphql/execution/instrumentation/Instrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://redirect.github.com/graphql-java/graphql-java/pull/4457/{{ revealButtonHref }}
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://redirect.github.com/graphql-java/graphql-java/pull/4457/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
Please reload this pagehttps://redirect.github.com/graphql-java/graphql-java/pull/4457/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.