René's URL Explorer Experiment


Title: Fix URI type adapter to preserve identity for non-ASCII URIs by anishesg · Pull Request #3067 · google/gson · GitHub

Open Graph Title: Fix URI type adapter to preserve identity for non-ASCII URIs by anishesg · Pull Request #3067 · google/gson

X Title: Fix URI type adapter to preserve identity for non-ASCII URIs by anishesg · Pull Request #3067 · google/gson

Description: A Java serialization/deserialization library to convert Java Objects into JSON and back - Fix URI type adapter to preserve identity for non-ASCII URIs by anishesg · Pull Request #3067 · google/gson

Open Graph Description: The URI type adapter was calling URI.toASCIIString() in its write() method, which percent-encodes non-ASCII characters and applies Unicode normalization. The read() method does not reverse this per...

X Description: The URI type adapter was calling URI.toASCIIString() in its write() method, which percent-encodes non-ASCII characters and applies Unicode normalization. The read() method does not reverse this per...

Opengraph URL: https://github.com/google/gson/pull/3067

X: @github

direct link

Domain: redirect.github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:777692ed-ea9c-466f-e75d-e692585d485c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA20:3E0336:16F342F:1E11B5B:6AED814C
html-safe-nonceeed164ecb433bd0ef8cf6161d4589b2eb73105a2349d9854890c1b725b87754d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTIwOjNFMDMzNjoxNkYzNDJGOjFFMTFCNUI6NkFFRDgxNEMiLCJ2aXNpdG9yX2lkIjoiNzY3MTg2NzQxOTk2NTM1ODQxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac221b7f942ff3c6948f6d546687a0baf4568f651e5c8e2c4106821d7c8267e793
hovercard-subject-tagpull_request:4112018146
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/gson/3067/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/718de95b680dfcd95adb2eb2b76fa3c812dc8802450dc362a5bbbe1924fb7c5d/google/gson/pull/3067
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/718de95b680dfcd95adb2eb2b76fa3c812dc8802450dc362a5bbbe1924fb7c5d/google/gson/pull/3067
og:image:altThe URI type adapter was calling URI.toASCIIString() in its write() method, which percent-encodes non-ASCII characters and applies Unicode normalization. The read() method does not reverse this per...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanishesg
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/google/gson git https://github.com/google/gson.git
octolytics-dimension-user_id1342004
octolytics-dimension-user_logingoogle
octolytics-dimension-repository_id32538871
octolytics-dimension-repository_nwogoogle/gson
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id32538871
octolytics-dimension-repository_network_root_nwogoogle/gson
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://redirect.github.com/google/gson/pull/3067#start-of-content
https://redirect.github.com/
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fgson%2Fpull%2F3067
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fgson%2Fpull%2F3067
Sign uphttps://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2Fgson
Reloadhttps://redirect.github.com/google/gson/pull/3067
Reloadhttps://redirect.github.com/google/gson/pull/3067
Reloadhttps://redirect.github.com/google/gson/pull/3067
googlehttps://redirect.github.com/google
gsonhttps://redirect.github.com/google/gson
Codehttps://redirect.github.com/google/gson
Issues224 (224)https://redirect.github.com/google/gson/issues
Pull requests118 (118)https://redirect.github.com/google/gson/pulls
Discussionshttps://redirect.github.com/google/gson/discussions
Actionshttps://redirect.github.com/google/gson/actions
Security and qualityhttps://redirect.github.com/google/gson/security
Insightshttps://redirect.github.com/google/gson/pulse
https://redirect.github.com/google/gson
eamonnmcmanushttps://redirect.github.com/eamonnmcmanus
google:mainhttps://redirect.github.com/google/gson/tree/main
proudhare:fix/ph-issue-1587https://redirect.github.com/proudhare/gson/tree/fix/ph-issue-1587
Conversationhttps://redirect.github.com/google/gson/pull/3067
Commits3 (3)https://redirect.github.com/google/gson/pull/3067/commits
Checkshttps://redirect.github.com/google/gson/pull/3067/checks
Files changedhttps://redirect.github.com/google/gson/pull/3067/files
Fix URI type adapter to preserve identity for non-ASCII URIshttps://redirect.github.com/google/gson/pull/3067#top
eamonnmcmanushttps://redirect.github.com/eamonnmcmanus
google:mainhttps://redirect.github.com/google/gson/tree/main
proudhare:fix/ph-issue-1587https://redirect.github.com/proudhare/gson/tree/fix/ph-issue-1587
https://redirect.github.com/anishesg
anishesghttps://redirect.github.com/anishesg
Jul 22, 2026https://redirect.github.com/google/gson/pull/3067#issue-4953462052
#1587https://github.com/google/gson/issues/1587
Please reload this pagehttps://redirect.github.com/google/gson/pull/3067
https://redirect.github.com/anishesg
Fix URI type adapter to preserve identity for non-ASCII URIshttps://redirect.github.com/google/gson/pull/3067/commits/e800acb4dadb504492c2a320f96fad45b8e76ed7
e800acbhttps://redirect.github.com/google/gson/pull/3067/commits/e800acb4dadb504492c2a320f96fad45b8e76ed7
https://redirect.github.com/anishesg
anishesghttps://redirect.github.com/anishesg
Jul 22, 2026 https://redirect.github.com/google/gson/pull/3067#ref-issue-502803611
URI type adapter does not preserve object identity #1587 https://redirect.github.com/google/gson/issues/1587
https://redirect.github.com/Marcono1234
Marcono1234https://redirect.github.com/Marcono1234
Jul 22, 2026 https://redirect.github.com/google/gson/pull/3067#pullrequestreview-4759106687
View reviewed changes https://redirect.github.com/google/gson/pull/3067/files/e800acb4dadb504492c2a320f96fad45b8e76ed7
gson/src/test/java/com/google/gson/functional/DefaultTypeAdaptersTest.javahttps://redirect.github.com/google/gson/pull/3067/files/e800acb4dadb504492c2a320f96fad45b8e76ed7#diff-80fadd68b1b498bc98e63d0434953ef50cdd9cc2d857fd2f4fd2ef37f2189418
Marcono1234https://redirect.github.com/Marcono1234
Jul 22, 2026https://redirect.github.com/google/gson/pull/3067#discussion_r3634097349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://redirect.github.com/google/gson/pull/3067
anishesghttps://redirect.github.com/anishesg
Jul 22, 2026https://redirect.github.com/google/gson/pull/3067#discussion_r3634685762
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://redirect.github.com/google/gson/pull/3067
anishesghttps://redirect.github.com/anishesg
July 22, 2026 23:50https://redirect.github.com/google/gson/pull/3067#commits-pushed-60a9c60
https://redirect.github.com/anishesg
address review feedback: use toString() for consistency in testUriDes…https://redirect.github.com/google/gson/pull/3067/commits/60a9c603327cf4626ff1c9a7ec94c537fdafed4b
60a9c60https://redirect.github.com/google/gson/pull/3067/commits/60a9c603327cf4626ff1c9a7ec94c537fdafed4b
https://redirect.github.com/eamonnmcmanus
Merge branch 'main' into fix/ph-issue-1587https://redirect.github.com/google/gson/pull/3067/commits/3b160db8d74ac379c81e69f14181a11b10566949
3b160dbhttps://redirect.github.com/google/gson/pull/3067/commits/3b160db8d74ac379c81e69f14181a11b10566949
https://redirect.github.com/eamonnmcmanus
eamonnmcmanushttps://redirect.github.com/eamonnmcmanus
Jul 23, 2026 https://redirect.github.com/google/gson/pull/3067#pullrequestreview-4766190854
View reviewed changes https://redirect.github.com/google/gson/pull/3067/files/3b160db8d74ac379c81e69f14181a11b10566949
eamonnmcmanushttps://redirect.github.com/eamonnmcmanus
https://redirect.github.com/google/gson/pull/3067#pullrequestreview-4766190854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://redirect.github.com/google/gson/pull/3067
https://redirect.github.com/eamonnmcmanus
eamonnmcmanushttps://redirect.github.com/eamonnmcmanus
961517dhttps://redirect.github.com/google/gson/commit/961517decce0aa907c285c19d8b93d5c746ecdcb
Jul 23, 2026https://github.com/google/gson/pull/3067#event-28405166672
Please reload this pagehttps://redirect.github.com/google/gson/pull/3067
https://redirect.github.com/ved-merget
ved-mergethttps://redirect.github.com/ved-merget
Sep 15, 2026 https://redirect.github.com/google/gson/pull/3067#ref-pullrequest-5468427838
[replay #3067] Fix URI type adapter to preserve identity for non-ASCII URIs Pufferfish-Merget/bench-gson#52 https://redirect.github.com/Pufferfish-Merget/bench-gson/pull/52
https://github.co/hiddenchars
https://redirect.github.com/google/gson/pull/{{ revealButtonHref }}
Sign up for freehttps://redirect.github.com/join?source=comment-repo
Sign in to commenthttps://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fgson%2Fpull%2F3067
https://redirect.github.com/eamonnmcmanus
eamonnmcmanus https://redirect.github.com/eamonnmcmanus
https://redirect.github.com/google/gson/pull/3067/files/3b160db8d74ac379c81e69f14181a11b10566949
https://redirect.github.com/Marcono1234
Marcono1234 https://redirect.github.com/Marcono1234
https://redirect.github.com/google/gson/pull/3067/files/e800acb4dadb504492c2a320f96fad45b8e76ed7
Please reload this pagehttps://redirect.github.com/google/gson/pull/3067
URI type adapter does not preserve object identity https://github.com/google/gson/issues/1587
Please reload this pagehttps://redirect.github.com/google/gson/pull/3067
https://redirect.github.com/anishesg
https://redirect.github.com/eamonnmcmanus
https://redirect.github.com/Marcono1234
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.