Title: Bump smmap dependency major-version upper bound by EliahKagan · Pull Request #95 · gitpython-developers/gitdb · GitHub
Open Graph Title: Bump smmap dependency major-version upper bound by EliahKagan · Pull Request #95 · gitpython-developers/gitdb
X Title: Bump smmap dependency major-version upper bound by EliahKagan · Pull Request #95 · gitpython-developers/gitdb
Description: This does not change the lower bound (nor does it prohibit any versions in the range), so all the combinations of versions that could be resolved before can still be resolved. As such, this is not a major or breaking change to gitdb. This is to permit gitdb to use smmap 6.*.* going forward (gitpython-developers/smmap#51), including future releases that may change more than metadata. Because it does not keep any combinations of versions that worked before from continuing to work, this should not break anything. Without this, regardless of whether or not anything further is done in smmap, installing GitPython does not install smmap 6 is with any version of Python, no matter how recent. This is because gitdb has the exclusive major version upper bound <6. With this, but no further smmap change since gitpython-developers/smmap#51, smmap 5 would be used on Python 3.7 and smmap 6 would be used on all later versions of Python. If you decide to merge gitpython-developers/smmap#52 and to make an smmap release after that, then with this gitdb would be able to use smmap 6 even on Python 3.7. Still, whether or not we actually want this, and also when, may depend to some extent on what is done in gitpython-developers/smmap#52 and more broadly to matters discussed in gitpython-developers/smmap#51. However, I suspect that a change like this will be wanted however that goes, unless the outcome is to yank smmap 6.0.0 with no further action. This PR is conceptually related to gitpython-developers/smmap#52 but I regard them to really be independent. Any combination of either of these PRs and making or not making a release after them could be done in any order and I believe everything would be fine (though obviously I do think these PRs should be regarded as improvements, though admittedly small ones, since if I didn't think that then I wouldn't have opened them). Since unlike smmap 6.0.0 the version bump in gitdb in a release after this PR would just be to a minor or patch version, the GitPython dependencies don't need to be updated.
Open Graph Description: This does not change the lower bound (nor does it prohibit any versions in the range), so all the combinations of versions that could be resolved before can still be resolved. As such, this is not ...
X Description: This does not change the lower bound (nor does it prohibit any versions in the range), so all the combinations of versions that could be resolved before can still be resolved. As such, this is not ...
Opengraph URL: https://github.com/gitpython-developers/gitdb/pull/95
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:26fccca0-c8db-3e91-af9f-11f572e00ebc |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A22E:236B02:48B29:63580:69695111 |
| html-safe-nonce | 2b2b4b6b0701aedcafb69ad3ad8ca19a231a73098cf7bbf02b829003f9fff8c9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjJFOjIzNkIwMjo0OEIyOTo2MzU4MDo2OTY5NTExMSIsInZpc2l0b3JfaWQiOiIyOTk2NzU0OTUxMDE0NTI1NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | adbde6751721417ec06de4bf8b202626809755d0cdc5848bb3e710d288618105 |
| hovercard-subject-tag | pull_request:1518445998 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/gitdb/pull/95/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This does not change the lower bound (nor does it prohibit any versions in the range), so all the combinations of versions that could be resolved before can still be resolved. As such, this is not ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/gitdb git https://github.com/gitpython-developers/gitdb.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126093 |
| octolytics-dimension-repository_nwo | gitpython-developers/gitdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126093 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/gitdb |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width