Title: Mark `test_installation` xfail on Cygwin CI by EliahKagan · Pull Request #2009 · gitpython-developers/GitPython · GitHub
Open Graph Title: Mark `test_installation` xfail on Cygwin CI by EliahKagan · Pull Request #2009 · gitpython-developers/GitPython
X Title: Mark `test_installation` xfail on Cygwin CI by EliahKagan · Pull Request #2009 · gitpython-developers/GitPython
Description: Together with #2007, this works around #2004, allowing all tests to pass on Cygwin CI. In #2007, installation of the environment in which tests run was fixed by downloading and running the get-pip.py bootstrap script. If we were to modify our helper that sets up the (separate) virtual environment in test_installation so that it does the same thing (or conditionally does so on CI, since the problem does not seem to happen in local installations), that would likely "fix" this more thoroughly, allowing the test to pass. But part of the goal of the installation test is to test that installation works in a typical environment on the platform it runs on. So it is not obivous that making it pass in that way would be an improvement compared to marking it xfail with the exception type that occurs due to #2004. So this just does that, for now. I don't know if this should be considered to close #2004 or not.
Open Graph Description: Together with #2007, this works around #2004, allowing all tests to pass on Cygwin CI. In #2007, installation of the environment in which tests run was fixed by downloading and running the get-pip....
X Description: Together with #2007, this works around #2004, allowing all tests to pass on Cygwin CI. In #2007, installation of the environment in which tests run was fixed by downloading and running the get-pip....
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2009
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:87c93adb-af4c-f8d2-8dfe-e51cb908e5b9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A408:1E73E4:17666A:20E459:696E4E4F |
| html-safe-nonce | 37589ea6c10eebf59d41f4e22efb25d75e0c98ce60ed49d6da93d29f543cf587 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDA4OjFFNzNFNDoxNzY2NkE6MjBFNDU5OjY5NkU0RTRGIiwidmlzaXRvcl9pZCI6IjI1MTQzOTgxMjMxMzYwMTE4NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f1a2fe630555e9ee2237ab70ff178ee694aef8d9afc46285fed40c04d69680d8 |
| hovercard-subject-tag | pull_request:2375326677 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2009/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Together with #2007, this works around #2004, allowing all tests to pass on Cygwin CI. In #2007, installation of the environment in which tests run was fixed by downloading and running the get-pip.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fd6f183b765d548d18ed5f3a1ce2c0e2a4ddbde2c74596c9d55c1a08b3e5572a |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a52ed9988fadfee5477eba0f6835cc823d7d8b33 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width