Title: Reorganize test_util and make xfail marks precise by EliahKagan · Pull Request #1729 · gitpython-developers/GitPython · GitHub
Open Graph Title: Reorganize test_util and make xfail marks precise by EliahKagan · Pull Request #1729 · gitpython-developers/GitPython
X Title: Reorganize test_util and make xfail marks precise by EliahKagan · Pull Request #1729 · gitpython-developers/GitPython
Description: Fixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spurious XPASS statuses make the information from xfail-marked tests less informative, and the specific problem focused on in #1728. In addition, this also refactors some other recently added tests in test_util.py, to achieve the goals described there. I may soon propose other changes that build on this in other ways, but that is not included here. Basically, this just: Reorganizes the tests in test_util.py, making some of them pure pytest tests. Uses @pytest.mark.parametrize with the marks= argument to apply @pytest.mark.xfail to exactly the cases that currently need it, and no others. Refactors some of the other tests' use of ad-hoc fixtures, removing some code reuse that I had added that was making the code harder rather than easier to maintain, and achieving useful code reuse more cleanly with a custom pytest fixture. This includes two changes to the pytest plugins that are used. Since those affect development dependencies, I list them here with their rationales: Because the parametrized mark supports nesting, generating test cases for the Cartesian product of the specified parameters, I removed the use of subtests for now, and thus also the pytest-subtests development dependency. Subtests, and that plugin, could be brought back in the future if they prove useful for another reason, but right now there are no longer any subtests in the test suite. This is the change I had anticipated in #1700 (comment). I have added and used pytest-mock for some of the new pure pytest tests that had previously used nested with-statements. The pytest-mock plugin provides a mocker fixture that wraps the functionality of unittest.mock but automatically unpatches everything (and in the reverse order in which it was patched) after the test. Since we do not yet have CI for native Windows, I have manually run the test_util.py tests on Windows (on Windows 10, with Python 3.12) to verify that they produce the expected statuses (including no FAIL statuses).
Open Graph Description: Fixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spur...
X Description: Fixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spur...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1729
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:c39ea2b4-dc55-996d-f936-8aaa1f4c1ec2 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 98D8:2FBE44:463FDA:5E0697:69719626 |
| html-safe-nonce | 8e9321efb7a57793f21216641f89132c52135ae0b75d36bec9ebb551156803b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEQ4OjJGQkU0NDo0NjNGREE6NUUwNjk3OjY5NzE5NjI2IiwidmlzaXRvcl9pZCI6IjQyMzAyMjQ1OTU2NzY5Mjc1MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 07cb4df005f7e2b61d9e5a3ae7c5c867f360fe392c7b48a20c12fcb93e8263e2 |
| hovercard-subject-tag | pull_request:1586314663 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1729/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Fixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spur... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdfdce9cd4f6ab85dca2b0d11264270829297c962dd5a79df449062d7822258f |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 51c736e60b302bd039c9d5164573d176ceb24bb2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width