Title: Remove `@NoEffect` annotations by EliahKagan · Pull Request #1677 · gitpython-developers/GitPython · GitHub
Open Graph Title: Remove `@NoEffect` annotations by EliahKagan · Pull Request #1677 · gitpython-developers/GitPython
X Title: Remove `@NoEffect` annotations by EliahKagan · Pull Request #1677 · gitpython-developers/GitPython
Description: Fixes #1674 Along with removing all @NoEffect annotations (there were only a handful), this: Adds missing asserts, where an expression statement was by itself that was intended as an assertion. This turned out to be the case in the places @NoEffect appeared in rendered documentation, making it so no per-file-ignores or other broadened suppressions were needed. Fixes misspellings (including one case affecting documentation). Adds a FIXME comment for investigating a free-standing expression statement with no obvious side effects that may have been meant as an assertion but would fail if turned into one. There are some other commented @-style suppression annotations throughout the project. This PR deliberately does not touch those. Some of them express useful intent that should eventually be stated in a different way but currently could be a breaking change to express better. For example, some of them express that a name that is imported but not used is intended to be present, which is better expressed with a static __all__ listing exactly the names (imports and otherwise) meant to be accessed through the module, but to usefully express this an __all__ needs to omit names not intended to be accessed that way, which may be a breaking change.
Open Graph Description: Fixes #1674 Along with removing all @NoEffect annotations (there were only a handful), this: Adds missing asserts, where an expression statement was by itself that was intended as an assertion. Th...
X Description: Fixes #1674 Along with removing all @NoEffect annotations (there were only a handful), this: Adds missing asserts, where an expression statement was by itself that was intended as an assertion. Th...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1677
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:40cf13af-43c0-d443-9d7d-75213c7cf779 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1A0:BE21E:131D46B:1B1F2D3:696918CB |
| html-safe-nonce | 01914d55a16dc994c2d49b4c54a211b272d24799f430f9b010913569350dfc8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUEwOkJFMjFFOjEzMUQ0NkI6MUIxRjJEMzo2OTY5MThDQiIsInZpc2l0b3JfaWQiOiI3MjEzMjc4Njk1MDAwNzA5MzIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0f759e02012f876e2128d7c172bfee9ed32316ec4747eb692fc0eacb8fb2ea0f |
| hovercard-subject-tag | pull_request:1525703945 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1677/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Fixes #1674 Along with removing all @NoEffect annotations (there were only a handful), this: Adds missing asserts, where an expression statement was by itself that was intended as an assertion. Th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd206f7ed6207863172be4a783826e86bd2375c3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width