Title: fix files list on file rename by teknoraver · Pull Request #1537 · gitpython-developers/GitPython · GitHub
Open Graph Title: fix files list on file rename by teknoraver · Pull Request #1537 · gitpython-developers/GitPython
X Title: fix files list on file rename by teknoraver · Pull Request #1537 · gitpython-developers/GitPython
Description: GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expected. This is the output of a normal commit: $ git diff --numstat 6ab9810cfe6c^ 6ab9810cfe6c 5 2 drivers/clk/zynqmp/divider.c And this a commit containing a rename: $ git diff --numstat db401875f438^ db401875f438 1 1 tools/testing/selftests/drivers/net/mlxsw/{spectrum-2 => }/devlink_trap_tunnel_ipip6.sh This can be triggered by this code: for commit in repo.iter_commits(): print(commit.hexsha) for file in commit.stats.files: print(file) Which will print for the normal commit: 6ab9810cfe6c8f3d8b8750c827d7870abd3751b9 'drivers/clk/zynqmp/divider.c' And when there is a rename: db401875f438168c5804b295b93a28c7730bb57a ('tools/testing/selftests/drivers/net/mlxsw/{spectrum-2 => ' '}/devlink_trap_tunnel_ipip6.sh') Fix this by pasing the --no-renames option to git diff which ignores renames and print the same output as if the file was deleted from the old path and created in the new one: $ git diff --numstat --no-renames db401875f438^ db401875f438 250 0 tools/testing/selftests/drivers/net/mlxsw/devlink_trap_tunnel_ipip6.sh 0 250 tools/testing/selftests/drivers/net/mlxsw/spectrum-2/devlink_trap_tunnel_ipip6.sh
Open Graph Description: GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expecte...
X Description: GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expecte...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1537
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:704c61c1-fe02-d65a-69a2-9c92e6cb45be |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7AC:7B850:445E8:615B6:69820E39 |
| html-safe-nonce | c8251942b78a9132826ce6331c20dfb8ce7ad1435c40a106d6f0e8ab59b5d9e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0FDOjdCODUwOjQ0NUU4OjYxNUI2OjY5ODIwRTM5IiwidmlzaXRvcl9pZCI6IjkzNTA4NzYxNTU5NjY5NTA5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 13d93b40c177d116969adefb28c7e53efd4dcd697c973f20d45bdd12379c826a |
| hovercard-subject-tag | pull_request:1194659321 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1537/files |
| twitter:image | https://avatars.githubusercontent.com/u/230946?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/230946?s=400&v=4 |
| og:image:alt | GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expecte... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2d53e73daff0fc9f0668e1e0628f2f5fa83e1e7e674b56f246f2f1c9ee32b15f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d5cf820dd454dbac0c84a97275f8ce4b224eba3a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width