Title: fix files list on file rename by teknoraver · Pull Request #1537 · gitpython-developers/GitPython · GitHub
Open Graph Title: fix files list on file rename by teknoraver · Pull Request #1537 · gitpython-developers/GitPython
X Title: fix files list on file rename by teknoraver · Pull Request #1537 · gitpython-developers/GitPython
Description: GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expected. This is the output of a normal commit: $ git diff --numstat 6ab9810cfe6c^ 6ab9810cfe6c 5 2 drivers/clk/zynqmp/divider.c And this a commit containing a rename: $ git diff --numstat db401875f438^ db401875f438 1 1 tools/testing/selftests/drivers/net/mlxsw/{spectrum-2 => }/devlink_trap_tunnel_ipip6.sh This can be triggered by this code: for commit in repo.iter_commits(): print(commit.hexsha) for file in commit.stats.files: print(file) Which will print for the normal commit: 6ab9810cfe6c8f3d8b8750c827d7870abd3751b9 'drivers/clk/zynqmp/divider.c' And when there is a rename: db401875f438168c5804b295b93a28c7730bb57a ('tools/testing/selftests/drivers/net/mlxsw/{spectrum-2 => ' '}/devlink_trap_tunnel_ipip6.sh') Fix this by pasing the --no-renames option to git diff which ignores renames and print the same output as if the file was deleted from the old path and created in the new one: $ git diff --numstat --no-renames db401875f438^ db401875f438 250 0 tools/testing/selftests/drivers/net/mlxsw/devlink_trap_tunnel_ipip6.sh 0 250 tools/testing/selftests/drivers/net/mlxsw/spectrum-2/devlink_trap_tunnel_ipip6.sh
Open Graph Description: GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expecte...
X Description: GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expecte...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1537
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dc042559-1759-53e1-38eb-e6daee790514 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A01A:1A7706:78731:9B39A:6982828A |
| html-safe-nonce | a321245fe8a51819840d99e287fd7c1e231e8861fde9301f6b23ba7b8e2209fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDFBOjFBNzcwNjo3ODczMTo5QjM5QTo2OTgyODI4QSIsInZpc2l0b3JfaWQiOiI2MzQzMDczNzY5MTM3MDEzMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5e8bb69a94c6de15d6d25d5754a06d7639105403cbacd070eb73c2b7571c1fd8 |
| hovercard-subject-tag | pull_request:1194659321 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1537/files |
| twitter:image | https://avatars.githubusercontent.com/u/230946?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/230946?s=400&v=4 |
| og:image:alt | GitPython parses the output of git diff --no-renames to get the files changed in a commit. This breaks when a commit contains a file rename, because the output of git diff is different than expecte... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 502ff2009aec8671c806fca4ec6d758f90b6b96901b01d5f0ed23cc438efdf0f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e7b93cf13221e895180e11ba3b1028b0b71f0ac |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width