Title: use tempfile.TemporaryDirectory & fix clone_from_unsafe_protocol tests by obfusk · Pull Request #1531 · gitpython-developers/GitPython · GitHub
Open Graph Title: use tempfile.TemporaryDirectory & fix clone_from_unsafe_protocol tests by obfusk · Pull Request #1531 · gitpython-developers/GitPython
X Title: use tempfile.TemporaryDirectory & fix clone_from_unsafe_protocol tests by obfusk · Pull Request #1531 · gitpython-developers/GitPython
Description: uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol instead of protocol); replaces /tmp/pwn w/ {tmp_file}; clones into tmp_dir / "repo" instead of tmp_dir, since tmp_dir / "pwn" will never exist afterwards otherwise; adds a test w/ ext::sh that actually allows the protocol, to ensure we're not missing anything in the other tests.
Open Graph Description: uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol ins...
X Description: uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol ins...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1531
X: @github
Domain: redirect.github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:386b2f8e-fe88-ca48-059f-a8fbe6b8c05a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C6A2:319E69:CAA2B6:1195B1E:69823867 |
| html-safe-nonce | a1c05cb373832958c47e8e27e5c40666bc8f15fe523abe036143e6895720d7b1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkEyOjMxOUU2OTpDQUEyQjY6MTE5NUIxRTo2OTgyMzg2NyIsInZpc2l0b3JfaWQiOiI3MDIzNTE5NjMxMDQ2NDkwMjE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 088f0b6322b4d2b25850bb578ac11ba27f609fc1967f8ac5d8def289b71374ab |
| hovercard-subject-tag | pull_request:1189695271 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1531/files |
| twitter:image | https://avatars.githubusercontent.com/u/1260687?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1260687?s=400&v=4 |
| og:image:alt | uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol ins... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9135c12c87e8ba63197821abe054b7c0a2842a97636ee220df564bb0788e556d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6b281db2f76bdbf4b45c30b597223c551b06e6e0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width