Title: Unclear why fun.py (and others?) shouldn't have a module docstring · Issue #1733 · gitpython-developers/GitPython · GitHub
Open Graph Title: Unclear why fun.py (and others?) shouldn't have a module docstring · Issue #1733 · gitpython-developers/GitPython
X Title: Unclear why fun.py (and others?) shouldn't have a module docstring · Issue #1733 · gitpython-developers/GitPython
Description: While working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementation and make it more versatile. # NOTE: Au...
Open Graph Description: While working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementatio...
X Description: While working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementatio...
Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/1733
X: @github
Domain: redirect.github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unclear why fun.py (and others?) shouldn't have a module docstring","articleBody":"While working on #1725 I noticed the `git.index.fun` module has this comment at the top:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/d5fc6e5337011d54fd2f3ff5aac71dbb38e43ee6/git/index/fun.py#L1-L2\r\n\r\nActually, that exact comment is due to my revision in that PR, but it's revised from:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/add46d9daa7664628ba3512297a2401981694c98/git/index/fun.py#L1-L3\r\n\r\nThis was introduced in 9ccd777, at which time an existing module docstring was converted to a comment instead. Various other module docstrings were also converted to comments. But some modules today do have docstrings. Running `make -C doc html` seems to work fine; I ran it a number of times on Ubuntu and Windows while working on that PR and since.\r\n\r\nI didn't want to assume it was okay to turn that back into a docstring. But either it (and any other top of module comments) should be turned into docstrings, *or* the reason they should not be should be made clearer (and any module docstrings causing problems fixed or converted back to comments).","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2023-11-04T22:19:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/1733/GitPython/issues/1733"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3c773a02-b694-155d-4203-431c230aa54d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A500:2BBD61:2216E9:2E9020:696AA2B9 |
| html-safe-nonce | 4b019a147ab42c9dd8104844f73e8206959fc8718fbf9bb2ff52a6d7bc89e8d7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTAwOjJCQkQ2MToyMjE2RTk6MkU5MDIwOjY5NkFBMkI5IiwidmlzaXRvcl9pZCI6IjM4NDQ4MjgyMjUxOTk1Nzk4MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e15a812fcf9a4c518e7051f0aa89e1cd50404b81fe66c5603f9832544c172331 |
| hovercard-subject-tag | issue:1977532946 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/1733/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b85bac128132604b3354cfae87526fff4e7bdc836b2c5f64d77dea9136dd1557/gitpython-developers/GitPython/issues/1733 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b85bac128132604b3354cfae87526fff4e7bdc836b2c5f64d77dea9136dd1557/gitpython-developers/GitPython/issues/1733 |
| og:image:alt | While working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementatio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EliahKagan |
| hostname | github.com |
| expected-hostname | github.com |
| None | a51f97dbb9326f71c08ecb61577457d543c602124d1a2672871258ef37ac5261 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4bd0eac606c70914085176ef312ebdcd97a8cdf1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width