| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:69ec6b97-1810-f43d-a3c0-58139b6e8e76 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B10C:22D7C9:FBFE0:1565B7:696A9AF8 |
| html-safe-nonce | 5b6e08aacc06d6d28de63e51069ccc426fa0dee80b834601b38c3e57aef59a86 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTBDOjIyRDdDOTpGQkZFMDoxNTY1Qjc6Njk2QTlBRjgiLCJ2aXNpdG9yX2lkIjoiMTE5NDU3NDE5Nzk5NjI5Njk1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ddd7786510d6184353ec8d21285181c27753a74e6f4d87c30a3374fa1c27da08 |
| hovercard-subject-tag | pull_request:1447970128 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/etr/libhttpserver/330/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a4fc0acb15e317b9d780b8ab651a6765f41749c6a3cdabd54786d33549722d8c/etr/libhttpserver/pull/330 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a4fc0acb15e317b9d780b8ab651a6765f41749c6a3cdabd54786d33549722d8c/etr/libhttpserver/pull/330 |
| og:image:alt | Identify the Bug
#329
Description of the Change
This pull request introduces the usage of locks in the werbserver class in order to protect member variables from data races.
Alternate Designs
N/A
P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | FlorianChevassu |
| hostname | github.com |
| expected-hostname | github.com |
| None | c0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af |
| turbo-cache-control | no-preview |
| go-import | github.com/etr/libhttpserver git https://github.com/etr/libhttpserver.git |
| octolytics-dimension-user_id | 1201536 |
| octolytics-dimension-user_login | etr |
| octolytics-dimension-repository_id | 3416891 |
| octolytics-dimension-repository_nwo | etr/libhttpserver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3416891 |
| octolytics-dimension-repository_network_root_nwo | etr/libhttpserver |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 99aab454e5ddc8df30805fb76c114c3008a15842 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://redirect.github.com/etr/libhttpserver/pull/330#start-of-content |
|
| https://redirect.github.com/ |
|
Sign in
| https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fetr%2Flibhttpserver%2Fpull%2F330 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fetr%2Flibhttpserver%2Fpull%2F330 |
|
Sign up
| https://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=etr%2Flibhttpserver |
| Reload | https://redirect.github.com/etr/libhttpserver/pull/330 |
| Reload | https://redirect.github.com/etr/libhttpserver/pull/330 |
| Reload | https://redirect.github.com/etr/libhttpserver/pull/330 |
|
etr
| https://redirect.github.com/etr |
| libhttpserver | https://redirect.github.com/etr/libhttpserver |
|
Notifications
| https://redirect.github.com/login?return_to=%2Fetr%2Flibhttpserver |
|
Fork
192
| https://redirect.github.com/login?return_to=%2Fetr%2Flibhttpserver |
|
Star
942
| https://redirect.github.com/login?return_to=%2Fetr%2Flibhttpserver |
|
Code
| https://redirect.github.com/etr/libhttpserver |
|
Issues
40
| https://redirect.github.com/etr/libhttpserver/issues |
|
Pull requests
11
| https://redirect.github.com/etr/libhttpserver/pulls |
|
Actions
| https://redirect.github.com/etr/libhttpserver/actions |
|
Projects
0
| https://redirect.github.com/etr/libhttpserver/projects |
|
Wiki
| https://redirect.github.com/etr/libhttpserver/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://redirect.github.com/etr/libhttpserver/security |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
|
Insights
| https://redirect.github.com/etr/libhttpserver/pulse |
|
Code
| https://redirect.github.com/etr/libhttpserver |
|
Issues
| https://redirect.github.com/etr/libhttpserver/issues |
|
Pull requests
| https://redirect.github.com/etr/libhttpserver/pulls |
|
Actions
| https://redirect.github.com/etr/libhttpserver/actions |
|
Projects
| https://redirect.github.com/etr/libhttpserver/projects |
|
Wiki
| https://redirect.github.com/etr/libhttpserver/wiki |
|
Security
| https://redirect.github.com/etr/libhttpserver/security |
|
Insights
| https://redirect.github.com/etr/libhttpserver/pulse |
| Sign up for GitHub
| https://redirect.github.com/signup?return_to=%2Fetr%2Flibhttpserver%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://redirect.github.com/login?return_to=%2Fetr%2Flibhttpserver%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://redirect.github.com/etr/libhttpserver/pull/330#issue-comment-box |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| etr:master | https://redirect.github.com/etr/libhttpserver/tree/master |
| FlorianChevassu:fix_webserver_thread_safety | https://redirect.github.com/FlorianChevassu/libhttpserver/tree/fix_webserver_thread_safety |
|
Fix webserver thread safety
| https://redirect.github.com/etr/libhttpserver/pull/330#top |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| etr:master | https://redirect.github.com/etr/libhttpserver/tree/master |
| FlorianChevassu:fix_webserver_thread_safety | https://redirect.github.com/FlorianChevassu/libhttpserver/tree/fix_webserver_thread_safety |
|
Conversation
8
| https://redirect.github.com/etr/libhttpserver/pull/330 |
|
Commits
6
| https://redirect.github.com/etr/libhttpserver/pull/330/commits |
|
Checks
0
| https://redirect.github.com/etr/libhttpserver/pull/330/checks |
|
Files changed
| https://redirect.github.com/etr/libhttpserver/pull/330/files |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| https://github.co/hiddenchars |
| https://redirect.github.com/etr/libhttpserver/pull/{{ revealButtonHref }} |
|
| https://redirect.github.com/FlorianChevassu |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| Jul 25, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#issue-1819813878 |
| #329 | https://github.com/etr/libhttpserver/issues/329 |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| fchevassu-antidot | https://redirect.github.com/fchevassu-antidot |
| July 25, 2023 10:35 | https://redirect.github.com/etr/libhttpserver/pull/330#commits-pushed-2ff6e31 |
|
| https://redirect.github.com/fchevassu-antidot |
| add test | https://redirect.github.com/etr/libhttpserver/pull/330/commits/2ff6e31bfa90a345e82a5dfaab3610979006e496 |
| 2ff6e31 | https://redirect.github.com/etr/libhttpserver/pull/330/commits/2ff6e31bfa90a345e82a5dfaab3610979006e496 |
|
| https://redirect.github.com/fchevassu-antidot |
| Use const when possible | https://redirect.github.com/etr/libhttpserver/pull/330/commits/ba2234d0556bde0139311ff91def7c1a2b5c815e |
| ba2234d | https://redirect.github.com/etr/libhttpserver/pull/330/commits/ba2234d0556bde0139311ff91def7c1a2b5c815e |
|
| https://redirect.github.com/fchevassu-antidot |
| Protect webserver::registered_resources_* | https://redirect.github.com/etr/libhttpserver/pull/330/commits/d4a89d8d61a0c7520e5b6800ca57280b63e4c976 |
| d4a89d8 | https://redirect.github.com/etr/libhttpserver/pull/330/commits/d4a89d8d61a0c7520e5b6800ca57280b63e4c976 |
|
| https://redirect.github.com/fchevassu-antidot |
| Protect webserver::bans and webserver::allowances | https://redirect.github.com/etr/libhttpserver/pull/330/commits/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
| 2f7b4ff | https://redirect.github.com/etr/libhttpserver/pull/330/commits/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
| https://redirect.github.com/FlorianChevassu |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| force-pushed | https://redirect.github.com/etr/libhttpserver/compare/858ef6169cc3c7f4901327ab183662c89064af9a..2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
| 858ef61 | https://redirect.github.com/etr/libhttpserver/commit/858ef6169cc3c7f4901327ab183662c89064af9a |
| 2f7b4ff | https://redirect.github.com/etr/libhttpserver/commit/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
|
Compare
| https://redirect.github.com/etr/libhttpserver/compare/858ef6169cc3c7f4901327ab183662c89064af9a..2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
| July 25, 2023 08:36 | https://redirect.github.com/etr/libhttpserver/pull/330#event-9908745698 |
| https://redirect.github.com/etr |
| etr | https://redirect.github.com/etr |
|
Aug 1, 2023
| https://redirect.github.com/etr/libhttpserver/pull/330#pullrequestreview-1557196268 |
|
View reviewed changes
| https://redirect.github.com/etr/libhttpserver/pull/330/files/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
| src/httpserver/webserver.hpp | https://redirect.github.com/etr/libhttpserver/pull/330/files/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5#diff-fcea8dea2184d98620480a5cddb26d7eff36db1be7e7b8ded054e17c2d967e63 |
| etr | https://redirect.github.com/etr |
| Aug 1, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#discussion_r1280761319 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| Aug 11, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#discussion_r1291042555 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| https://redirect.github.com/etr |
| etr | https://redirect.github.com/etr |
|
Aug 1, 2023
| https://redirect.github.com/etr/libhttpserver/pull/330#pullrequestreview-1557197663 |
|
View reviewed changes
| https://redirect.github.com/etr/libhttpserver/pull/330/files/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
| src/webserver.cpp | https://redirect.github.com/etr/libhttpserver/pull/330/files/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5#diff-9f24668b43bfb933b02221fb9f6dc1a442783d6c6ac99a010074313f03e1311f |
| etr | https://redirect.github.com/etr |
| Aug 1, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#discussion_r1280762249 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| Aug 11, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#discussion_r1291044842 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| etr | https://redirect.github.com/etr |
| Aug 17, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#discussion_r1297739287 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| https://redirect.github.com/etr |
| etr | https://redirect.github.com/etr |
| Aug 1, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#issuecomment-1660487012 |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
|
| https://redirect.github.com/fchevassu-antidot |
| Split bans_and_allowances_mutex in two distinct mutexes | https://redirect.github.com/etr/libhttpserver/pull/330/commits/145e9aaa372c948221d4cda6ac19b0dba8149255 |
| 145e9aa | https://redirect.github.com/etr/libhttpserver/pull/330/commits/145e9aaa372c948221d4cda6ac19b0dba8149255 |
| https://redirect.github.com/etr |
| etr | https://redirect.github.com/etr |
| Aug 17, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#issuecomment-1682963398 |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
|
| https://redirect.github.com/fchevassu-antidot |
| Simplify policy_callback condition | https://redirect.github.com/etr/libhttpserver/pull/330/commits/589ff8f9a7f23b3f7ced19573e95386563e746dd |
| 589ff8f | https://redirect.github.com/etr/libhttpserver/pull/330/commits/589ff8f9a7f23b3f7ced19573e95386563e746dd |
| https://redirect.github.com/FlorianChevassu |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| force-pushed | https://redirect.github.com/etr/libhttpserver/compare/101d19fea7a733c48d8e39d1ec954001b6f9b1d4..589ff8f9a7f23b3f7ced19573e95386563e746dd |
| 101d19f | https://redirect.github.com/etr/libhttpserver/commit/101d19fea7a733c48d8e39d1ec954001b6f9b1d4 |
| 589ff8f | https://redirect.github.com/etr/libhttpserver/commit/589ff8f9a7f23b3f7ced19573e95386563e746dd |
|
Compare
| https://redirect.github.com/etr/libhttpserver/compare/101d19fea7a733c48d8e39d1ec954001b6f9b1d4..589ff8f9a7f23b3f7ced19573e95386563e746dd |
| September 26, 2023 08:22 | https://redirect.github.com/etr/libhttpserver/pull/330#event-10471780386 |
| https://redirect.github.com/FlorianChevassu |
| FlorianChevassu | https://redirect.github.com/FlorianChevassu |
| Sep 26, 2023 | https://redirect.github.com/etr/libhttpserver/pull/330#issuecomment-1735087596 |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
| Sign up for free | https://redirect.github.com/join?source=comment-repo |
| Sign in to comment | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fetr%2Flibhttpserver%2Fpull%2F330 |
|
| https://redirect.github.com/etr |
|
etr
| https://redirect.github.com/etr |
|
| https://redirect.github.com/etr/libhttpserver/pull/330/files/2f7b4fffdebf809b434e0f8f1d3d66caebfde6d5 |
| Please reload this page | https://redirect.github.com/etr/libhttpserver/pull/330 |
|
| https://redirect.github.com/FlorianChevassu |
|
| https://redirect.github.com/etr |
|
| https://redirect.github.com/fchevassu-antidot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |