René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Please add an option to skip \"cd\" to different directories, or convert relative to absolute paths","articleBody":"Noticed something interesting recently fixing another CI error: my AppVeyor results were no longer being uploaded anymore (for who knows how long).  I am greatly suspicious of this code:\r\n\r\nhttps://github.com/codecov/codecov-python/blob/0743daa83647f12ff31b84d07113d2c24c27b924/codecov/__init__.py#L562-L565\r\n\r\n### Failed build\r\n\r\n[Full build log here](https://ci.appveyor.com/project/svenevs/exhale/builds/21187044/job/s46vy07b2e5yttju#L206), specifically this part is curious because this used to work as expected with `codecov` on this repo:\r\n\r\n```\r\n==\u003e Collecting reports\r\nXX\u003e Searching for reports disabled\r\n    Targeting specific files\r\n    - Ignored: [Errno 2] No such file or directory: '.\\\\coverage.xml'\r\nError: No coverage report found\r\n```\r\n\r\n### Solution: must use absolute path now\r\n\r\n```diff\r\n--- a/.appveyor.yml\r\n+++ b/.appveyor.yml\r\n@@ -94,6 +94,6 @@ after_test:\r\n         Invoke-Expression $codecov_cmd\r\n       }\r\n       else {\r\n-        $codecov_cmd = '\u0026 codecov -X gcov -f .\\coverage.xml --name ' + $env:TEST_NAME\r\n+        $codecov_cmd = '\u0026 codecov -X gcov -f c:\\projects\\exhale\\coverage.xml --name ' + $env:TEST_NAME\r\n         Invoke-Expression $codecov_cmd\r\n       }\r\n```\r\n\r\n### My Guess\r\n\r\nI don't think you can just do `cd \u003csomewhere\u003e \u0026\u0026 other_stuff || different_stuff` on windows in general.  So what I believe happens is the `cd` is successful, but the rest fails and then `codecov` never goes back.\r\n\r\nIn general, it's worth mentioning that this repo has a lot of patterns like this that should probably be a little more careful.  Another small example that could cause problems:\r\n\r\nhttps://github.com/codecov/codecov-python/blob/0743daa83647f12ff31b84d07113d2c24c27b924/codecov/__init__.py#L493\r\n\r\nI think that the python script was probably just adapted from the bash script and maybe that's why all of these are in here?  Unfortunately, there's a large number of them...but this is why there are generally so many problems on AppVeyor.\r\n\r\nFor the `cd` (suspected) problem, you may want to introduce a simple context manager so that you can do\r\n\r\n```py\r\nwith cd(some_path):\r\n    execute_stuff()\r\n```\r\n\r\nwhere the context manager will go back to where it came from (lots of examples online, [here's a good starting place](https://stackoverflow.com/a/24176022)).\r\n\r\nOr an even easier solution that would be much faster is specifically when you get a `-f \u003csome_path\u003e` you can check\r\n\r\n```py\r\n# suppose it was called this\r\nfile_path = args[\"-f\"]  # just an example...\r\nif not os.path.isabs(file_path):\r\n    file_path = os.path.abspath(file_path)\r\n```\r\n\r\nor similar.  Basically, make everything absolute before you start \"cd'ing\" around :upside_down_face:\r\n\r\nHappy to help implement changes with more input on what you want here.","author":{"url":"https://github.com/svenevs","@type":"Person","name":"svenevs"},"datePublished":"2018-12-22T01:02:50.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/174/codecov-python/issues/174"}