| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0b5ff7b8-9039-1a7f-0930-2252d5db7abb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE48:1C6C3E:BF9EB6:FDF883:6B00F1E6 |
| html-safe-nonce | 883997f331eac9e2910479d0c9adb245eda0ca2cb271ad28202d948ec1374af8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTQ4OjFDNkMzRTpCRjlFQjY6RkRGODgzOjZCMDBGMUU2IiwidmlzaXRvcl9pZCI6IjUzNjEyMzkyODQ2MDkyNDk3NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bbb3aaf0fd251cb3494097a9c32e886f1b0f710edff3cc96ada1c12dd84a1259 |
| hovercard-subject-tag | pull_request:1718383302 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/54353/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3bc9e0946b3edcd88936e471e62d5d5c594584611a1dc5b769bd2b4113d72fd8/angular/angular/pull/54353 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3bc9e0946b3edcd88936e471e62d5d5c594584611a1dc5b769bd2b4113d72fd8/angular/angular/pull/54353 |
| og:image:alt | The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals.
This commit addresses the crash by allowing there to be no matches. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JoostK |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://redirect.github.com/angular/angular/pull/54353#start-of-content |
| https://redirect.github.com/ |
| Sign in | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353 |
| Sign up | https://redirect.github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://redirect.github.com/angular/angular/pull/54353 |
| Reload | https://redirect.github.com/angular/angular/pull/54353 |
| Reload | https://redirect.github.com/angular/angular/pull/54353 |
| angular | https://redirect.github.com/angular |
| angular | https://redirect.github.com/angular/angular |
| Code | https://redirect.github.com/angular/angular |
| Issues835 (835) | https://redirect.github.com/angular/angular/issues |
| Pull requests141 (141) | https://redirect.github.com/angular/angular/pulls |
| Discussions | https://redirect.github.com/angular/angular/discussions |
| Actions | https://redirect.github.com/angular/angular/actions |
| Projects | https://redirect.github.com/angular/angular/projects |
| Security and quality40 (40) | https://redirect.github.com/angular/angular/security |
| Insights | https://redirect.github.com/angular/angular/insights |
| https://redirect.github.com/angular/angular |
| JoostK | https://redirect.github.com/JoostK |
| angular:main | https://redirect.github.com/angular/angular/tree/main |
| JoostK:core/signal-queries-empty | https://redirect.github.com/JoostK/angular/tree/core/signal-queries-empty |
| Conversation | https://redirect.github.com/angular/angular/pull/54353 |
| Commits1 (1) | https://redirect.github.com/angular/angular/pull/54353/commits |
| Checks | https://redirect.github.com/angular/angular/pull/54353/checks |
| Files changed | https://redirect.github.com/angular/angular/pull/54353/files |
| fix(core): do not crash for signal query that does not have any matches | https://redirect.github.com/angular/angular/pull/54353#top |
| JoostK | https://redirect.github.com/JoostK |
| angular:main | https://redirect.github.com/angular/angular/tree/main |
| JoostK:core/signal-queries-empty | https://redirect.github.com/JoostK/angular/tree/core/signal-queries-empty |
|
| https://redirect.github.com/JoostK |
| JoostK | https://redirect.github.com/JoostK |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#issue-2126049696 |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
|
| https://redirect.github.com/JoostK |
| fix(core): do not crash for signal query that does not have any matches | https://redirect.github.com/angular/angular/pull/54353/commits/a6eff00a01a7a5c0a3989b8d43834bf67959beaf |
| a6eff00 | https://redirect.github.com/angular/angular/pull/54353/commits/a6eff00a01a7a5c0a3989b8d43834bf67959beaf |
| https://redirect.github.com/JoostK |
| JoostK | https://redirect.github.com/JoostK |
|
action: review
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: core
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
core: queries
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20queries%22 |
|
target: rc
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22 |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#event-11751143988 |
| https://redirect.github.com/apps/ngbot |
| ngbot | https://redirect.github.com/apps/ngbot |
| Backlog | https://redirect.github.com/angular/angular/milestone/82 |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#event-11751144281 |
| https://redirect.github.com/JoostK |
| JoostK | https://redirect.github.com/JoostK |
| February 8, 2024 21:16 | https://redirect.github.com/angular/angular/pull/54353#event-11751347674 |
| https://redirect.github.com/apps/pullapprove |
| pullapprove | https://redirect.github.com/apps/pullapprove |
| jessicajaniuk | https://redirect.github.com/jessicajaniuk |
| February 8, 2024 21:16 | https://redirect.github.com/angular/angular/pull/54353#event-11751348813 |
| https://redirect.github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
|
Feb 8, 2024
| https://redirect.github.com/angular/angular/pull/54353#pullrequestreview-1871291208 |
|
View reviewed changes
| https://redirect.github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf |
| packages/core/src/render3/query.ts | https://redirect.github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#discussion_r1483610370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
| JoostK | https://redirect.github.com/JoostK |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#discussion_r1483614135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
| https://redirect.github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
|
Feb 8, 2024
| https://redirect.github.com/angular/angular/pull/54353#pullrequestreview-1871293017 |
|
View reviewed changes
| https://redirect.github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
| https://redirect.github.com/angular/angular/pull/54353#pullrequestreview-1871293017 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @JoostK | https://github.com/JoostK |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
| https://redirect.github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
|
action: merge
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#event-11751459257 |
| https://redirect.github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
| jessicajaniuk | https://redirect.github.com/jessicajaniuk |
| February 8, 2024 21:29 | https://redirect.github.com/angular/angular/pull/54353#event-11751463170 |
| https://redirect.github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
|
merge: caretaker note
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#event-11752056576 |
| https://redirect.github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://redirect.github.com/pkozlowski-opensource |
| Feb 8, 2024 | https://redirect.github.com/angular/angular/pull/54353#issuecomment-1935051553 |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
| https://redirect.github.com/jessicajaniuk |
| jessicajaniuk | https://redirect.github.com/jessicajaniuk |
| abf6371 | https://redirect.github.com/angular/angular/commit/abf637165b8705b614546067c7f409dca08b2635 |
| Feb 9, 2024 | https://redirect.github.com/angular/angular/pull/54353#event-11759060138 |
| jessicajaniuk | https://redirect.github.com/jessicajaniuk |
|
Feb 9, 2024
| https://redirect.github.com/angular/angular/pull/54353#ref-commit-62b87b4 |
|
| https://redirect.github.com/JoostK |
|
| https://redirect.github.com/thePunderWoman |
| fix(core): do not crash for signal query that does not have any match… | https://redirect.github.com/angular/angular/commit/62b87b4551d77815f58af152d1921de3733621ba |
| 62b87b4 | https://redirect.github.com/angular/angular/commit/62b87b4551d77815f58af152d1921de3733621ba |
| #54353 | https://github.com/angular/angular/pull/54353 |
| #54353 | https://github.com/angular/angular/pull/54353 |
| https://redirect.github.com/jessicajaniuk |
| jessicajaniuk | https://redirect.github.com/jessicajaniuk |
| Feb 9, 2024 | https://redirect.github.com/angular/angular/pull/54353#issuecomment-1936084043 |
| abf6371 | https://github.com/angular/angular/commit/abf637165b8705b614546067c7f409dca08b2635 |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
| atscott | https://redirect.github.com/atscott |
|
Feb 16, 2024
| https://redirect.github.com/angular/angular/pull/54353#ref-commit-83b1e4b |
|
| https://redirect.github.com/JoostK |
|
| https://redirect.github.com/atscott |
| fix(core): do not crash for signal query that does not have any match… | https://redirect.github.com/atscott/angular/commit/83b1e4be89568fa2efc042babd4c3aae461d85dd |
| 83b1e4b | https://redirect.github.com/atscott/angular/commit/83b1e4be89568fa2efc042babd4c3aae461d85dd |
| angular#54353 | https://github.com/angular/angular/pull/54353 |
| angular#54353 | https://github.com/angular/angular/pull/54353 |
| https://redirect.github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://redirect.github.com/apps/angular-automatic-lock-bot |
| Mar 11, 2024 | https://redirect.github.com/angular/angular/pull/54353#issuecomment-1987424228 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
| https://redirect.github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://redirect.github.com/apps/angular-automatic-lock-bot |
| Mar 11, 2024 | https://redirect.github.com/angular/angular/pull/54353#event-12066767543 |
| https://github.co/hiddenchars |
| https://redirect.github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://redirect.github.com/join?source=comment-repo |
| Sign in | https://redirect.github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353 |
|
| https://redirect.github.com/pkozlowski-opensource |
|
pkozlowski-opensource
| https://redirect.github.com/pkozlowski-opensource |
|
| https://redirect.github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
|
action: merge
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: core
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
core: queries
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20queries%22 |
|
merge: caretaker note
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: rc
| https://redirect.github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22 |
|
Backlog
| https://redirect.github.com/angular/angular/milestone/82 |
| Please reload this page | https://redirect.github.com/angular/angular/pull/54353 |
|
| https://redirect.github.com/JoostK |
|
| https://redirect.github.com/pkozlowski-opensource |
|
| https://redirect.github.com/jessicajaniuk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |