René's URL Explorer Experiment


Title: Reuse http client by harmingcola · Pull Request #62 · web-push-libs/webpush-java · GitHub

Open Graph Title: Reuse http client by harmingcola · Pull Request #62 · web-push-libs/webpush-java

X Title: Reuse http client by harmingcola · Pull Request #62 · web-push-libs/webpush-java

Description: …troying on ConnectException to avoid thread leak I've been your library for a few months now and it works brilliantly (thanks) However, we'd a network blip yesterday and it started causing Executi...

Open Graph Description: …troying on ConnectException to avoid thread leak I've been your library for a few months now and it works brilliantly (thanks) However, we'd a network blip yesterday and it started causing...

X Description: …troying on ConnectException to avoid thread leak I've been your library for a few months now and it works brilliantly (thanks) However, we'd a network blip yesterday and it started...

Opengraph URL: https://github.com/web-push-libs/webpush-java/pull/62

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:32881dab-8708-c62a-b9a5-00dba3c0054d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4E4:56F18:AAF04E:D942BE:69758DFA
html-safe-noncefa7e731f83008ac99c3af2b318e4b15349fa3254f580a83bac103bc25ad77858
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEU0OjU2RjE4OkFBRjA0RTpEOTQyQkU6Njk3NThERkEiLCJ2aXNpdG9yX2lkIjoiNzUwNzA3NjQ3ODM0NTI1MjM0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b56099b47edff883784336cd7646b2781e4082359a88f170937b07991fa42fb
hovercard-subject-tagpull_request:200749395
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/web-push-libs/webpush-java/62/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38252da8becd3a30765e1f33b209ac0ca046b1e1b423bb704e6b24db592184a9/web-push-libs/webpush-java/pull/62
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38252da8becd3a30765e1f33b209ac0ca046b1e1b423bb704e6b24db592184a9/web-push-libs/webpush-java/pull/62
og:image:alt…troying on ConnectException to avoid thread leak I've been your library for a few months now and it works brilliantly (thanks) However, we'd a network blip yesterday and it started causing...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameharmingcola
hostnamegithub.com
expected-hostnamegithub.com
None4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f
turbo-cache-controlno-preview
go-importgithub.com/web-push-libs/webpush-java git https://github.com/web-push-libs/webpush-java.git
octolytics-dimension-user_id19820480
octolytics-dimension-user_loginweb-push-libs
octolytics-dimension-repository_id53700230
octolytics-dimension-repository_nwoweb-push-libs/webpush-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id53700230
octolytics-dimension-repository_network_root_nwoweb-push-libs/webpush-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release488b30e96dfd057fbbe44c6665ccbc030b729dde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fweb-push-libs%2Fwebpush-java%2Fpull%2F62
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fweb-push-libs%2Fwebpush-java%2Fpull%2F62
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=web-push-libs%2Fwebpush-java
Reloadhttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
Reloadhttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
Reloadhttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
web-push-libs https://patch-diff.githubusercontent.com/web-push-libs
webpush-javahttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fweb-push-libs%2Fwebpush-java
Fork 117 https://patch-diff.githubusercontent.com/login?return_to=%2Fweb-push-libs%2Fwebpush-java
Star 349 https://patch-diff.githubusercontent.com/login?return_to=%2Fweb-push-libs%2Fwebpush-java
Code https://patch-diff.githubusercontent.com/web-push-libs/webpush-java
Issues 40 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/issues
Pull requests 16 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pulls
Actions https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/actions
Projects 0 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/projects
Wiki https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/wiki
Security 0 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/security
Insights https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pulse
Code https://patch-diff.githubusercontent.com/web-push-libs/webpush-java
Issues https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/issues
Pull requests https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pulls
Actions https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/actions
Projects https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/projects
Wiki https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/wiki
Security https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/security
Insights https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fweb-push-libs%2Fwebpush-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fweb-push-libs%2Fwebpush-java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#issue-comment-box
harmingcolahttps://patch-diff.githubusercontent.com/harmingcola
web-push-libs:masterhttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/tree/master
harmingcola:reuse_http_clienthttps://patch-diff.githubusercontent.com/harmingcola/webpush-java/tree/reuse_http_client
Reuse http client https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#top
harmingcolahttps://patch-diff.githubusercontent.com/harmingcola
web-push-libs:masterhttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/tree/master
harmingcola:reuse_http_clienthttps://patch-diff.githubusercontent.com/harmingcola/webpush-java/tree/reuse_http_client
Conversation 4 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
Commits 2 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62/commits
Checks 0 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62/checks
Files changed https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62/files
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/harmingcola
harmingcolahttps://patch-diff.githubusercontent.com/harmingcola
Jul 11, 2018https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#issue-340305645
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
July 11, 2018 16:41https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#commits-pushed-ae85414
Reusing http client to avoid building a new one for each request, des…https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62/commits/ae8541411f1218ce84d955998a14a24fe63c023e
ae85414https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62/commits/ae8541411f1218ce84d955998a14a24fe63c023e
Fixing overzealous import reorderinghttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62/commits/011bdc02ece45cf827b1ca9693fa51c1988afbe7
011bdc0https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62/commits/011bdc02ece45cf827b1ca9693fa51c1988afbe7
https://patch-diff.githubusercontent.com/martijndwars
martijndwarshttps://patch-diff.githubusercontent.com/martijndwars
Jul 11, 2018https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#issuecomment-404298621
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
https://patch-diff.githubusercontent.com/harmingcola
harmingcolahttps://patch-diff.githubusercontent.com/harmingcola
Jul 12, 2018https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#issuecomment-404422478
…https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
#62 (comment)https://github.com/web-push-libs/webpush-java/pull/62#issuecomment-404298621
https://github.com/notifications/unsubscribe-auth/AFBGPSGbhTSDunNU5Du8gL_jvAPi6k25ks5uFl8sgaJpZM4VLaachttps://github.com/notifications/unsubscribe-auth/AFBGPSGbhTSDunNU5Du8gL_jvAPi6k25ks5uFl8sgaJpZM4VLaac
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
https://patch-diff.githubusercontent.com/martijndwars
martijndwarshttps://patch-diff.githubusercontent.com/martijndwars
Jul 12, 2018https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#issuecomment-404613058
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
https://patch-diff.githubusercontent.com/harmingcola
harmingcolahttps://patch-diff.githubusercontent.com/harmingcola
Jul 16, 2018https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#issuecomment-405176261
…https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
#62 (comment)https://github.com/web-push-libs/webpush-java/pull/62#issuecomment-404613058
https://github.com/notifications/unsubscribe-auth/AFBGPXv9ytXsNCPawgFDyZho5Jy3NjcKks5uF5o9gaJpZM4VLaachttps://github.com/notifications/unsubscribe-auth/AFBGPXv9ytXsNCPawgFDyZho5Jy3NjcKks5uF5o9gaJpZM4VLaac
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
https://patch-diff.githubusercontent.com/luccotta
luccottahttps://patch-diff.githubusercontent.com/luccotta
Jul 28, 2022 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62#ref-issue-1310069613
Thread leak - too many open files #196 https://patch-diff.githubusercontent.com/web-push-libs/webpush-java/issues/196
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fweb-push-libs%2Fwebpush-java%2Fpull%2F62
Please reload this pagehttps://patch-diff.githubusercontent.com/web-push-libs/webpush-java/pull/62
https://patch-diff.githubusercontent.com/harmingcola
https://patch-diff.githubusercontent.com/martijndwars
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.