Title: Experimental Vim9 support by AndrewRadev · Pull Request #443 · vim-ruby/vim-ruby · GitHub
Open Graph Title: Experimental Vim9 support by AndrewRadev · Pull Request #443 · vim-ruby/vim-ruby
X Title: Experimental Vim9 support by AndrewRadev · Pull Request #443 · vim-ruby/vim-ruby
Description: Not planning to merge this, just playing around. Changes were mostly mechanical, so it wasn't a big deal to apply. I might do something like keep both versions of the code in separate files and if-clause them, which might actually make it mergeable. Performance-wise, I tested on a particularly annoying edge case, a list of 199 entries that looks like this: [ 'Test', 'Test', # ... 'Test', ] Every indent needs to find the "most significant line" with a linear search, going through every line above until the [. Anyway, here's a result of profile func GetRubyIndent on master: FUNCTION GetRubyIndent() Defined: ~/.vim/bundle/ruby/indent/ruby.vim:189 Called 201 times Total time: 16.409863 Self time: 0.055199 And here it is when it calls the vim9 function: FUNCTION GetRubyIndent() Defined: ~/.vim/bundle/ruby/indent/ruby.vim:53 Called 201 times Total time: 11.736142 Self time: 0.003108 It's nothing too dramatic, but it's not nothing, I guess.
Open Graph Description: Not planning to merge this, just playing around. Changes were mostly mechanical, so it wasn't a big deal to apply. I might do something like keep both versions of the code in separate files and...
X Description: Not planning to merge this, just playing around. Changes were mostly mechanical, so it wasn't a big deal to apply. I might do something like keep both versions of the code in separate files...
Opengraph URL: https://github.com/vim-ruby/vim-ruby/pull/443
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:da1d247e-42d6-34c0-3bbc-6c9148d6a139 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE3E:2E6996:12AADA23:130C8A9D:696E9930 |
| html-safe-nonce | ccb3c7fc9b59908de6a948e9e2fbdf81cd348767c108edb48fcea8397d0f1062 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTNFOjJFNjk5NjoxMkFBREEyMzoxMzBDOEE5RDo2OTZFOTkzMCIsInZpc2l0b3JfaWQiOiI4MzQ0Mzk3OTc0OTUwODExOTUyIiwicmVnaW9uX2VkZ2UiOiJzZWEiLCJyZWdpb25fcmVuZGVyIjoic2VhIn0= |
| visitor-hmac | 74e501b800f4574cdee5b45362f8c4b76dda6733479da407639583b74a1c43d2 |
| hovercard-subject-tag | pull_request:808316304 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/vim-ruby/vim-ruby/pull/443/files |
| twitter:image | https://avatars.githubusercontent.com/u/124255?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/124255?s=400&v=4 |
| og:image:alt | Not planning to merge this, just playing around. Changes were mostly mechanical, so it wasn't a big deal to apply. I might do something like keep both versions of the code in separate files and... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/vim-ruby/vim-ruby git https://github.com/vim-ruby/vim-ruby.git |
| octolytics-dimension-user_id | 17170 |
| octolytics-dimension-user_login | vim-ruby |
| octolytics-dimension-repository_id | 34465 |
| octolytics-dimension-repository_nwo | vim-ruby/vim-ruby |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 34465 |
| octolytics-dimension-repository_network_root_nwo | vim-ruby/vim-ruby |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 27b23bc056eb973d350fc95afc848757edb9e7a9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width