Title: Properly highlight docstrings by wmvanvliet · Pull Request #83 · vim-python/python-syntax · GitHub
Open Graph Title: Properly highlight docstrings by wmvanvliet · Pull Request #83 · vim-python/python-syntax
X Title: Properly highlight docstrings by wmvanvliet · Pull Request #83 · vim-python/python-syntax
Description: Another attempt at #45 and #57, namely to properly highlight docstrings as comments. For now, this implementation is very ugly, but it actually works. It only highlights things that should be docstrings without touching other types of multiline strings. This is accomplished by checking for : characters and combining that with nextgroup=pythonDocString to interpret the first directly following multiline string as a docstring. Another case is added for the first multiline string appearing at the top of the file. See https://gist.github.com/wmvanvliet/36471bb456151d93b86c402b64684b0a for a bunch of challenging test cases. The implementation is messy right now to work around a specific problem. Any pointers on how to solve this more elegantly are greatly appreciated. The problem is that nextgroup=pythonDocString skipempty will skip newlines, but not spaces in its search for the docstring, and so it will only find it when the docstring starts on the first column of a line. For now, the workaround is to match +^\s*"""+ as a docstring, i.e. also match the leading whitespace, but this causes the docstring rule to have precedence over the normal +"""+ multiline pattern. Ideally, the multiline rule should take precedence and have this precedence temporarily overwritten by the presence of a : mark.
Open Graph Description: Another attempt at #45 and #57, namely to properly highlight docstrings as comments. For now, this implementation is very ugly, but it actually works. It only highlights things that should be docst...
X Description: Another attempt at #45 and #57, namely to properly highlight docstrings as comments. For now, this implementation is very ugly, but it actually works. It only highlights things that should be docst...
Opengraph URL: https://github.com/vim-python/python-syntax/pull/83
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:15df963c-fee8-31a7-33bd-f9dc12bea5fd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9236:286A33:33D89F6:4585A7E:697AF169 |
| html-safe-nonce | 9c877805ada663f0551a7bce0d896ab1a7d2a9bdc6e215abde2f2a2a3a2401a7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjM2OjI4NkEzMzozM0Q4OUY2OjQ1ODVBN0U6Njk3QUYxNjkiLCJ2aXNpdG9yX2lkIjoiNDQwMDIwNjk4MDIwNzgwMDY4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 379f235b08d208f0a1db54586fa58cff9f03c6e6fc291cfc971065204fd236eb |
| hovercard-subject-tag | pull_request:614361199 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/vim-python/python-syntax/pull/83/files |
| twitter:image | https://avatars.githubusercontent.com/u/428273?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/428273?s=400&v=4 |
| og:image:alt | Another attempt at #45 and #57, namely to properly highlight docstrings as comments. For now, this implementation is very ugly, but it actually works. It only highlights things that should be docst... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/vim-python/python-syntax git https://github.com/vim-python/python-syntax.git |
| octolytics-dimension-user_id | 25825542 |
| octolytics-dimension-user_login | vim-python |
| octolytics-dimension-repository_id | 82203847 |
| octolytics-dimension-repository_nwo | vim-python/python-syntax |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 82203847 |
| octolytics-dimension-repository_network_root_nwo | vim-python/python-syntax |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d7bfc78137af9a4828305e52ab993fce981d7085 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width