René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"The example code for the new OO API isn't quite right","articleBody":"**Describe the issue**\r\nFor this main readme file: https://github.com/tinyobjloader/tinyobjloader/blob/master/README.md#example-code-new-object-oriented-api\r\n\r\nThis \"Example code (New Object Oriented API)\" code works well to read in cornell_box.obj. There's just one minor issue flagged by Visual Studio, that \"v\" and \"fv\" are of different types (size_t vs. int).\r\n\r\nBut, the access code:\r\n\r\n                tinyobj::index_t idx = shapes[s].mesh.indices[index_offset + v];\r\n                tinyobj::real_t vx = attrib.vertices[3 * idx.vertex_index + 0];\r\n                tinyobj::real_t vy = attrib.vertices[3 * idx.vertex_index + 1];\r\n                tinyobj::real_t vz = attrib.vertices[3 * idx.vertex_index + 2];\r\n                tinyobj::real_t nx = attrib.normals[3 * idx.normal_index + 0];\r\n                tinyobj::real_t ny = attrib.normals[3 * idx.normal_index + 1];\r\n                tinyobj::real_t nz = attrib.normals[3 * idx.normal_index + 2];\r\n\r\nfails and asserts when it tries to read the normals, because there are no normals computed.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Compile in some new, basic console app the example code https://github.com/tinyobjloader/tinyobjloader/blob/master/README.md#example-code-new-object-oriented-api\r\n2. Run\r\n3. See assert\r\n\r\n**Expected behavior**\r\nA clear and concise description of what you expected to happen.\r\n\r\nHere's the fixed code I suggest for the example:\r\n\r\n            for (size_t v = 0; v \u003c (size_t)fv; v++) {\r\n                // access to vertex\r\n                tinyobj::index_t idx = shapes[s].mesh.indices[index_offset + v];\r\n                tinyobj::real_t vx = attrib.vertices[3 * idx.vertex_index + 0];\r\n                tinyobj::real_t vy = attrib.vertices[3 * idx.vertex_index + 1];\r\n                tinyobj::real_t vz = attrib.vertices[3 * idx.vertex_index + 2];\r\n                if (idx.normal_index \u003e= 0) {\r\n                    tinyobj::real_t nx = attrib.normals[3 * idx.normal_index + 0];\r\n                    tinyobj::real_t ny = attrib.normals[3 * idx.normal_index + 1];\r\n                    tinyobj::real_t nz = attrib.normals[3 * idx.normal_index + 2];\r\n                }\r\n                if (idx.texcoord_index \u003e= 0) {\r\n                    tinyobj::real_t tx = attrib.texcoords[2 * idx.texcoord_index + 0];\r\n                    tinyobj::real_t ty = attrib.texcoords[2 * idx.texcoord_index + 1];\r\n                }\r\n                // Optional: vertex colors\r\n                // tinyobj::real_t red = attrib.colors[3*idx.vertex_index+0];\r\n                // tinyobj::real_t green = attrib.colors[3*idx.vertex_index+1];\r\n                // tinyobj::real_t blue = attrib.colors[3*idx.vertex_index+2];\r\n            }\r\n\r\n\r\n**Environment**\r\n - TinyObjLoader version v2-rc1\r\n - OS: Windows 10\r\n - Compiler Visual Studio\r\n - Other environment - none\r\n","author":{"url":"https://github.com/erich666","@type":"Person","name":"erich666"},"datePublished":"2021-03-17T21:15:26.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/300/tinyobjloader/issues/300"}