René's URL Explorer Experiment


Title: Setting all the optimizers to have useLocking = True by Craigacp · Pull Request #310 · tensorflow/java · GitHub

Open Graph Title: Setting all the optimizers to have useLocking = True by Craigacp · Pull Request #310 · tensorflow/java

X Title: Setting all the optimizers to have useLocking = True by Craigacp · Pull Request #310 · tensorflow/java

Description: I'm running into determinism issues when training models using TF-Java. This is one area which could be causing it, as in TF 2 all the optimizers have useLocking=true. We don't currently set this i...

Open Graph Description: I'm running into determinism issues when training models using TF-Java. This is one area which could be causing it, as in TF 2 all the optimizers have useLocking=true. We don't currently se...

X Description: I'm running into determinism issues when training models using TF-Java. This is one area which could be causing it, as in TF 2 all the optimizers have useLocking=true. We don't curr...

Opengraph URL: https://github.com/tensorflow/java/pull/310

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c6195d25-bb86-be7c-b254-42e0ffa42fa9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA4A:110520:9A1E7B:D73CDE:6971EE6E
html-safe-nonceba0964d2a791e393be3aa11a2863389e797ab4250be1064b96c0423480bdafe4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTRBOjExMDUyMDo5QTFFN0I6RDczQ0RFOjY5NzFFRTZFIiwidmlzaXRvcl9pZCI6IjI2ODE1NzUxNTUyODc4NDY1MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac465046ad4065487b903affca7d3f3df86246c0b93c96cead7f4501c19ef99bb2
hovercard-subject-tagpull_request:628011694
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/tensorflow/java/310/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b7d922b6d4eee19f28b94ad3ae1145cb2196c38d7cf06f327d7e2ac22ba1752b/tensorflow/java/pull/310
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b7d922b6d4eee19f28b94ad3ae1145cb2196c38d7cf06f327d7e2ac22ba1752b/tensorflow/java/pull/310
og:image:altI'm running into determinism issues when training models using TF-Java. This is one area which could be causing it, as in TF 2 all the optimizers have useLocking=true. We don't currently se...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCraigacp
hostnamegithub.com
expected-hostnamegithub.com
None683712716975b3393656edf09255a1d488d0e68ab7b9ac97e40ecf40036f696c
turbo-cache-controlno-preview
go-importgithub.com/tensorflow/java git https://github.com/tensorflow/java.git
octolytics-dimension-user_id15658638
octolytics-dimension-user_logintensorflow
octolytics-dimension-repository_id207384523
octolytics-dimension-repository_nwotensorflow/java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id207384523
octolytics-dimension-repository_network_root_nwotensorflow/java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseed99da4e2de688dd1056894c1eccd4c82c6bbbfe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftensorflow%2Fjava%2Fpull%2F310
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftensorflow%2Fjava%2Fpull%2F310
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=tensorflow%2Fjava
Reloadhttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
Reloadhttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
Reloadhttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
tensorflow https://patch-diff.githubusercontent.com/tensorflow
javahttps://patch-diff.githubusercontent.com/tensorflow/java
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Ftensorflow%2Fjava
Fork 223 https://patch-diff.githubusercontent.com/login?return_to=%2Ftensorflow%2Fjava
Star 913 https://patch-diff.githubusercontent.com/login?return_to=%2Ftensorflow%2Fjava
Code https://patch-diff.githubusercontent.com/tensorflow/java
Issues 150 https://patch-diff.githubusercontent.com/tensorflow/java/issues
Pull requests 23 https://patch-diff.githubusercontent.com/tensorflow/java/pulls
Actions https://patch-diff.githubusercontent.com/tensorflow/java/actions
Projects 0 https://patch-diff.githubusercontent.com/tensorflow/java/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/tensorflow/java/security
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
Insights https://patch-diff.githubusercontent.com/tensorflow/java/pulse
Code https://patch-diff.githubusercontent.com/tensorflow/java
Issues https://patch-diff.githubusercontent.com/tensorflow/java/issues
Pull requests https://patch-diff.githubusercontent.com/tensorflow/java/pulls
Actions https://patch-diff.githubusercontent.com/tensorflow/java/actions
Projects https://patch-diff.githubusercontent.com/tensorflow/java/projects
Security https://patch-diff.githubusercontent.com/tensorflow/java/security
Insights https://patch-diff.githubusercontent.com/tensorflow/java/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Ftensorflow%2Fjava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Ftensorflow%2Fjava%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issue-comment-box
karllessardhttps://patch-diff.githubusercontent.com/karllessard
tensorflow:masterhttps://patch-diff.githubusercontent.com/tensorflow/java/tree/master
Craigacp:locking-optimizer-fixeshttps://patch-diff.githubusercontent.com/Craigacp/tensorflow-java/tree/locking-optimizer-fixes
Setting all the optimizers to have useLocking = True https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#top
karllessardhttps://patch-diff.githubusercontent.com/karllessard
tensorflow:masterhttps://patch-diff.githubusercontent.com/tensorflow/java/tree/master
Craigacp:locking-optimizer-fixeshttps://patch-diff.githubusercontent.com/Craigacp/tensorflow-java/tree/locking-optimizer-fixes
Conversation 11 https://patch-diff.githubusercontent.com/tensorflow/java/pull/310
Commits 3 https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/commits
Checks 0 https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/checks
Files changed https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/tensorflow/java/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/Craigacp
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
Apr 30, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issue-873169523
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/Craigacp
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
Apr 30, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issuecomment-830337289
tensorflow/tensorflow#48855https://github.com/tensorflow/tensorflow/issues/48855
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/karllessard
karllessardhttps://patch-diff.githubusercontent.com/karllessard
Apr 30, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issuecomment-830353212
@rnetthttps://github.com/rnett
#306https://github.com/tensorflow/java/pull/306
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/karllessard
karllessardhttps://patch-diff.githubusercontent.com/karllessard
May 1, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issuecomment-830470433
@Craigacphttps://github.com/Craigacp
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
April 30, 2021 20:55https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#commits-pushed-5dd4b30
https://patch-diff.githubusercontent.com/Craigacp
Setting all the optimizers to have useLocking = True, like Keras. Add…https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/commits/5dd4b30a037369c6e73e8f2ef039c277d9a29ebd
5dd4b30https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/commits/5dd4b30a037369c6e73e8f2ef039c277d9a29ebd
https://patch-diff.githubusercontent.com/Craigacp
More work on the GradientDescentTest.https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/commits/c0fc3510837a07f55adf924c82ce4c4b2c50de6d
c0fc351https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/commits/c0fc3510837a07f55adf924c82ce4c4b2c50de6d
https://patch-diff.githubusercontent.com/Craigacp
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
force-pushedhttps://patch-diff.githubusercontent.com/tensorflow/java/compare/03402b30e271a46438c1feff12409095737f3d3e..c0fc3510837a07f55adf924c82ce4c4b2c50de6d
03402b3https://patch-diff.githubusercontent.com/tensorflow/java/commit/03402b30e271a46438c1feff12409095737f3d3e
c0fc351https://patch-diff.githubusercontent.com/tensorflow/java/commit/c0fc3510837a07f55adf924c82ce4c4b2c50de6d
Compare https://patch-diff.githubusercontent.com/tensorflow/java/compare/03402b30e271a46438c1feff12409095737f3d3e..c0fc3510837a07f55adf924c82ce4c4b2c50de6d
May 1, 2021 00:56https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#event-4672588861
https://patch-diff.githubusercontent.com/Craigacp
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
May 1, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issuecomment-830477972
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/Craigacp
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
May 1, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issuecomment-830480041
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/karllessard
karllessardhttps://patch-diff.githubusercontent.com/karllessard
May 1, 2021 https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#pullrequestreview-649785850
View reviewed changes https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files/c0fc3510837a07f55adf924c82ce4c4b2c50de6d
karllessardhttps://patch-diff.githubusercontent.com/karllessard
https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#pullrequestreview-649785850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Craigacphttps://github.com/Craigacp
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
tensorflow-framework/src/test/java/org/tensorflow/framework/optimizers/GradientDescentTest.javahttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files/c0fc3510837a07f55adf924c82ce4c4b2c50de6d#diff-c2dc23e481f29c520bd7cfc3351d9fa8d0fee3c0108369441e072e3bd355c1bb
karllessardhttps://patch-diff.githubusercontent.com/karllessard
May 1, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#discussion_r624506900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
tensorflow-framework/src/main/java/org/tensorflow/framework/optimizers/AdaGrad.javahttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files/c0fc3510837a07f55adf924c82ce4c4b2c50de6d#diff-d4c3fbaae0b1c86b82c7770dc75d3fe1f608e69b83349189dda36caa4095e54d
karllessardhttps://patch-diff.githubusercontent.com/karllessard
May 1, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#discussion_r624507332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
tensorflow-framework/src/test/java/org/tensorflow/framework/optimizers/GradientDescentTest.javahttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files/c0fc3510837a07f55adf924c82ce4c4b2c50de6d#diff-c2dc23e481f29c520bd7cfc3351d9fa8d0fee3c0108369441e072e3bd355c1bb
karllessardhttps://patch-diff.githubusercontent.com/karllessard
May 1, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#discussion_r624507792
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
tensorflow-framework/src/test/java/org/tensorflow/framework/optimizers/GradientDescentTest.javahttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files/c0fc3510837a07f55adf924c82ce4c4b2c50de6d#diff-c2dc23e481f29c520bd7cfc3351d9fa8d0fee3c0108369441e072e3bd355c1bb
karllessardhttps://patch-diff.githubusercontent.com/karllessard
May 1, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#discussion_r624508089
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/Craigacp
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
May 2, 2021https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#issuecomment-830717795
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/Craigacp
Tidying up the test.https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/commits/c11c911cb1180e3e225bd513ac8137588409f33c
c11c911https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/commits/c11c911cb1180e3e225bd513ac8137588409f33c
https://patch-diff.githubusercontent.com/Craigacp
Craigacphttps://patch-diff.githubusercontent.com/Craigacp
karllessardhttps://patch-diff.githubusercontent.com/karllessard
stale reviewhttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310#pullrequestreview-649785850
c11c911https://patch-diff.githubusercontent.com/tensorflow/java/commit/c11c911cb1180e3e225bd513ac8137588409f33c
May 4, 2021 01:41https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#event-4680919719
https://patch-diff.githubusercontent.com/karllessard
karllessardhttps://patch-diff.githubusercontent.com/karllessard
May 4, 2021 https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#pullrequestreview-650857451
View reviewed changes https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files/c11c911cb1180e3e225bd513ac8137588409f33c
https://patch-diff.githubusercontent.com/karllessard
karllessardhttps://patch-diff.githubusercontent.com/karllessard
a24b8cahttps://patch-diff.githubusercontent.com/tensorflow/java/commit/a24b8cae2481b4ed75d4444b344c385bcf1b2a15
May 4, 2021https://github.com/tensorflow/java/pull/310#event-4681073572
https://patch-diff.githubusercontent.com/zaleslaw
zaleslawhttps://patch-diff.githubusercontent.com/zaleslaw
Dec 15, 2021 https://patch-diff.githubusercontent.com/tensorflow/java/pull/310#ref-issue-1081140705
Set all the optimizers to have useLocking = True Kotlin/kotlindl#305 https://patch-diff.githubusercontent.com/Kotlin/kotlindl/issues/305
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftensorflow%2Fjava%2Fpull%2F310
https://patch-diff.githubusercontent.com/karllessard
karllessard https://patch-diff.githubusercontent.com/karllessard
https://patch-diff.githubusercontent.com/tensorflow/java/pull/310/files/c11c911cb1180e3e225bd513ac8137588409f33c
Please reload this pagehttps://patch-diff.githubusercontent.com/tensorflow/java/pull/310
https://patch-diff.githubusercontent.com/Craigacp
https://patch-diff.githubusercontent.com/karllessard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.