René's URL Explorer Experiment

Title: fromfile leaks file pointer in case parse raises exception · Issue #58 · techtonik/python-patch · GitHub

Open Graph Title: fromfile leaks file pointer in case parse raises exception · Issue #58 · techtonik/python-patch

X Title: fromfile leaks file pointer in case parse raises exception · Issue #58 · techtonik/python-patch

Description: the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.

Open Graph Description: the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.

X Description: the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.

Opengraph URL: https://github.com/techtonik/python-patch/issues/58

X: @github

direct link

Domain: patch-diff.githubusercontent.com

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fromfile leaks file pointer in case parse raises exception","articleBody":"the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.\r\n","author":{"url":"https://github.com/stefanoborini","@type":"Person","name":"stefanoborini"},"datePublished":"2019-01-14T14:20:29.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/58/python-patch/issues/58"}

Links:

Viewport: width=device-width