Title: fromfile() should either return None or raise an exception, not return False · Issue #57 · techtonik/python-patch · GitHub
Open Graph Title: fromfile() should either return None or raise an exception, not return False · Issue #57 · techtonik/python-patch
X Title: fromfile() should either return None or raise an exception, not return False · Issue #57 · techtonik/python-patch
Description: It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inconsistent.
Open Graph Description: It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inconsis...
X Description: It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inco...
Opengraph URL: https://github.com/techtonik/python-patch/issues/57
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fromfile() should either return None or raise an exception, not return False","articleBody":"It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inconsistent.\r\n","author":{"url":"https://github.com/stefanoborini","@type":"Person","name":"stefanoborini"},"datePublished":"2019-01-14T14:18:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/57/python-patch/issues/57"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:56f81f36-7e4a-7869-8201-604e6a365f83 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 86B8:2EB8B3:203482C:2D5A53F:696F615E |
| html-safe-nonce | 1fa1fb7837bc5e4a58109adc8be38b4b7322fc5c17780d384c0fa04d351d9449 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkI4OjJFQjhCMzoyMDM0ODJDOjJENUE1M0Y6Njk2RjYxNUUiLCJ2aXNpdG9yX2lkIjoiMTk5NDk2ODQyMDQ5MDEwOTI3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 699c8a21594df6cef97e25b91b1c3304056989f8962323f5095cb004b09e1b2b |
| hovercard-subject-tag | issue:398908099 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/techtonik/python-patch/57/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3cfa0b62d705324a4f9e2352fc01e487a0416a65e541dbe598199fe967b2b5de/techtonik/python-patch/issues/57 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3cfa0b62d705324a4f9e2352fc01e487a0416a65e541dbe598199fe967b2b5de/techtonik/python-patch/issues/57 |
| og:image:alt | It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inconsis... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | stefanoborini |
| hostname | github.com |
| expected-hostname | github.com |
| None | 774d0922d2c4577043d2dab90427344eb4c6ce1d5579acb1dd504cff1a7e46f8 |
| turbo-cache-control | no-preview |
| go-import | github.com/techtonik/python-patch git https://github.com/techtonik/python-patch.git |
| octolytics-dimension-user_id | 515889 |
| octolytics-dimension-user_login | techtonik |
| octolytics-dimension-repository_id | 34159484 |
| octolytics-dimension-repository_nwo | techtonik/python-patch |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 34159484 |
| octolytics-dimension-repository_network_root_nwo | techtonik/python-patch |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 650acea592f12d1bd8931d44546c209e0b06ed6e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width