René's URL Explorer Experiment


Title: WaitForJobDone() should wait until all tasks fully finished by 5kg · Pull Request #145 · taskgraph/taskgraph · GitHub

Open Graph Title: WaitForJobDone() should wait until all tasks fully finished by 5kg · Pull Request #145 · taskgraph/taskgraph

X Title: WaitForJobDone() should wait until all tasks fully finished by 5kg · Pull Request #145 · taskgraph/taskgraph

Description: Controller.WaitForJobDone() watches JobStatus in etcd to determine when the task job has finished. Now, JobStatus is set in Framework.ShutdownJob() -- a function called by task implementer to notif...

Open Graph Description: Controller.WaitForJobDone() watches JobStatus in etcd to determine when the task job has finished. Now, JobStatus is set in Framework.ShutdownJob() -- a function called by task implementer to notif...

X Description: Controller.WaitForJobDone() watches JobStatus in etcd to determine when the task job has finished. Now, JobStatus is set in Framework.ShutdownJob() -- a function called by task implementer to notif...

Opengraph URL: https://github.com/taskgraph/taskgraph/pull/145

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0c4f4dba-fe44-01f1-6299-a90149d704fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92FC:1BBE0B:B142508:E5F5A6F:69768C18
html-safe-nonceaa6be5756607d8f11c2bc48f3bc7a0133b7208952bdfcf30622a2e154490c939
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkZDOjFCQkUwQjpCMTQyNTA4OkU1RjVBNkY6Njk3NjhDMTgiLCJ2aXNpdG9yX2lkIjoiNjMzMDEwMTI3MTM5MDIyNzQ4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf96cb3fdd0a15eb6ebeab490f0c710d0eda55d16e73fc403d7cc4b2bd82bd8cb
hovercard-subject-tagpull_request:38722530
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/taskgraph/taskgraph/145/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/243cf2b8bb35d098f8c96983680e9374efc01398e241f76b647757420bf1b10a/taskgraph/taskgraph/pull/145
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/243cf2b8bb35d098f8c96983680e9374efc01398e241f76b647757420bf1b10a/taskgraph/taskgraph/pull/145
og:image:altController.WaitForJobDone() watches JobStatus in etcd to determine when the task job has finished. Now, JobStatus is set in Framework.ShutdownJob() -- a function called by task implementer to notif...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:username5kg
hostnamegithub.com
expected-hostnamegithub.com
None032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411
turbo-cache-controlno-preview
go-importgithub.com/taskgraph/taskgraph git https://github.com/taskgraph/taskgraph.git
octolytics-dimension-user_id9723611
octolytics-dimension-user_logintaskgraph
octolytics-dimension-repository_id30477948
octolytics-dimension-repository_nwotaskgraph/taskgraph
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id30477948
octolytics-dimension-repository_network_root_nwotaskgraph/taskgraph
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5b577f6be6482e336e3c30e8daefa30144947b17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftaskgraph%2Ftaskgraph%2Fpull%2F145
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftaskgraph%2Ftaskgraph%2Fpull%2F145
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=taskgraph%2Ftaskgraph
Reloadhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
Reloadhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
Reloadhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
taskgraph https://patch-diff.githubusercontent.com/taskgraph
taskgraphhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Ftaskgraph%2Ftaskgraph
Fork 20 https://patch-diff.githubusercontent.com/login?return_to=%2Ftaskgraph%2Ftaskgraph
Star 84 https://patch-diff.githubusercontent.com/login?return_to=%2Ftaskgraph%2Ftaskgraph
Code https://patch-diff.githubusercontent.com/taskgraph/taskgraph
Issues 16 https://patch-diff.githubusercontent.com/taskgraph/taskgraph/issues
Pull requests 6 https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pulls
Actions https://patch-diff.githubusercontent.com/taskgraph/taskgraph/actions
Projects 0 https://patch-diff.githubusercontent.com/taskgraph/taskgraph/projects
Wiki https://patch-diff.githubusercontent.com/taskgraph/taskgraph/wiki
Security 0 https://patch-diff.githubusercontent.com/taskgraph/taskgraph/security
Insights https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pulse
Code https://patch-diff.githubusercontent.com/taskgraph/taskgraph
Issues https://patch-diff.githubusercontent.com/taskgraph/taskgraph/issues
Pull requests https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pulls
Actions https://patch-diff.githubusercontent.com/taskgraph/taskgraph/actions
Projects https://patch-diff.githubusercontent.com/taskgraph/taskgraph/projects
Wiki https://patch-diff.githubusercontent.com/taskgraph/taskgraph/wiki
Security https://patch-diff.githubusercontent.com/taskgraph/taskgraph/security
Insights https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Ftaskgraph%2Ftaskgraph%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Ftaskgraph%2Ftaskgraph%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#issue-comment-box
5kghttps://patch-diff.githubusercontent.com/5kg
taskgraph:masterhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/tree/master
5kg:fix_early_quithttps://patch-diff.githubusercontent.com/5kg/taskgraph/tree/fix_early_quit
WaitForJobDone() should wait until all tasks fully finished https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#top
5kghttps://patch-diff.githubusercontent.com/5kg
taskgraph:masterhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/tree/master
5kg:fix_early_quithttps://patch-diff.githubusercontent.com/5kg/taskgraph/tree/fix_early_quit
Conversation 4 https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
Commits 2 https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145/commits
Checks 0 https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145/checks
Files changed https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145/files
Please reload this pagehttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/5kg
5kghttps://patch-diff.githubusercontent.com/5kg
Jun 28, 2015https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#issue-91574676
Please reload this pagehttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
https://patch-diff.githubusercontent.com/zifeitong
WaitForJobDone() should wait until task fully finishedhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145/commits/955c459a0dad6e60f670616c38ff9c534a3089fd
955c459https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145/commits/955c459a0dad6e60f670616c38ff9c534a3089fd
https://patch-diff.githubusercontent.com/hongchaodeng
hongchaodenghttps://patch-diff.githubusercontent.com/hongchaodeng
Jun 28, 2015https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#issuecomment-116294403
@5kghttps://github.com/5kg
https://github.com/fengjingchao/taskgraph/blob/a535cb4c3c613d8c0eb8046e33404a2f6f5e8afa/framework_interface.go#L29https://github.com/fengjingchao/taskgraph/blob/a535cb4c3c613d8c0eb8046e33404a2f6f5e8afa/framework_interface.go#L29
Please reload this pagehttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
https://patch-diff.githubusercontent.com/5kg
5kghttps://patch-diff.githubusercontent.com/5kg
force-pushedhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/compare/428674756b66a63d8d4732ea82554e377b5691f1..eb5f1e2aa471eae45878533e11ae47cc99032835
4286747https://patch-diff.githubusercontent.com/taskgraph/taskgraph/commit/428674756b66a63d8d4732ea82554e377b5691f1
eb5f1e2https://patch-diff.githubusercontent.com/taskgraph/taskgraph/commit/eb5f1e2aa471eae45878533e11ae47cc99032835
Compare https://patch-diff.githubusercontent.com/taskgraph/taskgraph/compare/428674756b66a63d8d4732ea82554e377b5691f1..eb5f1e2aa471eae45878533e11ae47cc99032835
June 29, 2015 05:39https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#event-342590540
https://patch-diff.githubusercontent.com/5kg
5kghttps://patch-diff.githubusercontent.com/5kg
Jun 29, 2015https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#event-342592843
https://patch-diff.githubusercontent.com/plutoshe
plutoshehttps://patch-diff.githubusercontent.com/plutoshe
Jun 29, 2015https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#issuecomment-116452336
@fengjingchaohttps://github.com/fengjingchao
Please reload this pagehttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
https://patch-diff.githubusercontent.com/5kg
5kghttps://patch-diff.githubusercontent.com/5kg
force-pushedhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/compare/eb5f1e2aa471eae45878533e11ae47cc99032835..e186ffb8c6d0eb224c09da23c90f4bbde9f026a8
eb5f1e2https://patch-diff.githubusercontent.com/taskgraph/taskgraph/commit/eb5f1e2aa471eae45878533e11ae47cc99032835
e186ffbhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/commit/e186ffb8c6d0eb224c09da23c90f4bbde9f026a8
Compare https://patch-diff.githubusercontent.com/taskgraph/taskgraph/compare/eb5f1e2aa471eae45878533e11ae47cc99032835..e186ffb8c6d0eb224c09da23c90f4bbde9f026a8
June 29, 2015 06:06https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#event-342608000
https://patch-diff.githubusercontent.com/5kg
5kghttps://patch-diff.githubusercontent.com/5kg
Jun 29, 2015https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#issuecomment-116476360
#140https://github.com/taskgraph/taskgraph/pull/140
Please reload this pagehttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
https://patch-diff.githubusercontent.com/zifeitong
WaitForJobDone() should wait until every task finishedhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145/commits/55216cfcb56e85b00e573b59931c297b00973761
55216cfhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145/commits/55216cfcb56e85b00e573b59931c297b00973761
955c459https://github.com/5kg/taskgraph/commit/955c459a0dad6e60f670616c38ff9c534a3089fd
https://patch-diff.githubusercontent.com/5kg
5kghttps://patch-diff.githubusercontent.com/5kg
force-pushedhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/compare/e186ffb8c6d0eb224c09da23c90f4bbde9f026a8..55216cfcb56e85b00e573b59931c297b00973761
e186ffbhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/commit/e186ffb8c6d0eb224c09da23c90f4bbde9f026a8
55216cfhttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/commit/55216cfcb56e85b00e573b59931c297b00973761
Compare https://patch-diff.githubusercontent.com/taskgraph/taskgraph/compare/e186ffb8c6d0eb224c09da23c90f4bbde9f026a8..55216cfcb56e85b00e573b59931c297b00973761
June 29, 2015 06:55https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#event-342648222
https://patch-diff.githubusercontent.com/5kg
5kghttps://patch-diff.githubusercontent.com/5kg
Jun 29, 2015https://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145#issuecomment-116504958
@fengjingchaohttps://github.com/fengjingchao
Please reload this pagehttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftaskgraph%2Ftaskgraph%2Fpull%2F145
Please reload this pagehttps://patch-diff.githubusercontent.com/taskgraph/taskgraph/pull/145
https://patch-diff.githubusercontent.com/5kg
https://patch-diff.githubusercontent.com/hongchaodeng
https://patch-diff.githubusercontent.com/plutoshe
https://patch-diff.githubusercontent.com/zifeitong
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.