Title: prevent parentheses in filenames being stripped out by davidjgoss · Pull Request #82 · stacktracejs/error-stack-parser · GitHub
Open Graph Title: prevent parentheses in filenames being stripped out by davidjgoss · Pull Request #82 · stacktracejs/error-stack-parser
X Title: prevent parentheses in filenames being stripped out by davidjgoss · Pull Request #82 · stacktracejs/error-stack-parser
Description: Description Prevent parentheses in filenames from being incorrectly stripped out when parsing the raw stack frame. This is done by changing extractLocation, which previously removed all parens from its input, and now just strips them from the start and end (including multiple, which can happen with nested evals) which I think was probably the original intent. Motivation and Context Fixes #62. How Has This Been Tested? Added a test with an example stack (thanks to @mattwynne work in #61) Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Checklist: npm run lint passes without errors npm run test passes without errors I have read the contribution guidelines I have updated the documentation accordingly I have added tests to cover my changes
Open Graph Description: Description Prevent parentheses in filenames from being incorrectly stripped out when parsing the raw stack frame. This is done by changing extractLocation, which previously removed all parens from...
X Description: Description Prevent parentheses in filenames from being incorrectly stripped out when parsing the raw stack frame. This is done by changing extractLocation, which previously removed all parens from...
Opengraph URL: https://github.com/stacktracejs/error-stack-parser/pull/82
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:803797b1-5f90-5d31-22b4-534658f4945a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E840:106C72:1C8E7E7:2683232:697079F8 |
| html-safe-nonce | 0c3bc5c0947a7a46ff06d28f64ab7193977dda0ed623939fc1b94e391355c44c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODQwOjEwNkM3MjoxQzhFN0U3OjI2ODMyMzI6Njk3MDc5RjgiLCJ2aXNpdG9yX2lkIjoiODMyOTQ4OTc1NjkxOTQ2MjM5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4a15b1b95924dc7b8bd60dbccc1ee07a5e15c091df71a43df411c289974dd526 |
| hovercard-subject-tag | pull_request:1036968123 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/stacktracejs/error-stack-parser/pull/82/files |
| twitter:image | https://avatars.githubusercontent.com/u/3192745?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3192745?s=400&v=4 |
| og:image:alt | Description Prevent parentheses in filenames from being incorrectly stripped out when parsing the raw stack frame. This is done by changing extractLocation, which previously removed all parens from... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/stacktracejs/error-stack-parser git https://github.com/stacktracejs/error-stack-parser.git |
| octolytics-dimension-user_id | 6131251 |
| octolytics-dimension-user_login | stacktracejs |
| octolytics-dimension-repository_id | 15014773 |
| octolytics-dimension-repository_nwo | stacktracejs/error-stack-parser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 15014773 |
| octolytics-dimension-repository_network_root_nwo | stacktracejs/error-stack-parser |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width