Title: Add support for setEvalOrigin by joews · Pull Request #37 · stacktracejs/error-stack-parser · GitHub
Open Graph Title: Add support for setEvalOrigin by joews · Pull Request #37 · stacktracejs/error-stack-parser
X Title: Add support for setEvalOrigin by joews · Pull Request #37 · stacktracejs/error-stack-parser
Description: Work in progress fix for #32. I'm opening the PR early to check the approach and ask some questions 😄
So far I have hacked in basic v8 support and tested on Chrome 58. I'll do the other engines and eval tests when i'm happy with the approach.
A few questions about setEvalOrigin. Given this program:
// index.js
function f() {
return g();
}
function g() {
return h();
}
function h() {
try {
eval(`
function willThrow() {
return doesNotExist;
}
willThrow();
`);
} catch (e) {
console.log(e.stack);
}
}
f();
Which is the "parent" stack frame - eval in index.js or willThrow in
Open Graph Description: Work in progress fix for #32. I'm opening the PR early to check the approach and ask some questions 😄 So far I have hacked in basic v8 support and tested on Chrome 58. I'll do the other eng...
X Description: Work in progress fix for #32. I'm opening the PR early to check the approach and ask some questions 😄 So far I have hacked in basic v8 support and tested on Chrome 58. I'll do the o...
Opengraph URL: https://github.com/stacktracejs/error-stack-parser/pull/37
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ca8ebcd6-4501-94d1-0b37-7c8ec553b18f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA32:2713AA:13357CC:19A357F:69703223 |
| html-safe-nonce | d9371ffad2b70b91aa682c5d8fc7fb71a37993622e5c50527a4f7581116c8f44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTMyOjI3MTNBQToxMzM1N0NDOjE5QTM1N0Y6Njk3MDMyMjMiLCJ2aXNpdG9yX2lkIjoiNjgyODk3Nzc2NDUyMzA2MTc5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 740968b77c199f9be3d5c6b72d8c8e7ce0ecd2cd05a0606755f675f4c753857c |
| hovercard-subject-tag | pull_request:122539115 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/stacktracejs/error-stack-parser/pull/37/files |
| twitter:image | https://avatars.githubusercontent.com/u/294383?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/294383?s=400&v=4 |
| og:image:alt | Work in progress fix for #32. I'm opening the PR early to check the approach and ask some questions 😄 So far I have hacked in basic v8 support and tested on Chrome 58. I'll do the other eng... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/stacktracejs/error-stack-parser git https://github.com/stacktracejs/error-stack-parser.git |
| octolytics-dimension-user_id | 6131251 |
| octolytics-dimension-user_login | stacktracejs |
| octolytics-dimension-repository_id | 15014773 |
| octolytics-dimension-repository_nwo | stacktracejs/error-stack-parser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 15014773 |
| octolytics-dimension-repository_network_root_nwo | stacktracejs/error-stack-parser |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f643964067a552f02067066d6a910b2f90a5721f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width