René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SyntaxError stack trace not generated","articleBody":"## Current Behavior\r\n\r\nWe have detected a problem when generating stack trace from a SyntaxError. This takes place when the error cause is due to a **malformed javascript code**, the output of the library is not consistent:\r\n\r\n- On chromium browsers it returns a malformed single stack trace element not containing the lineNumber property\r\n\r\n\u003cimg width=\"639\" alt=\"Screenshot 2022-06-15 at 14 46 00\" src=\"https://user-images.githubusercontent.com/15065076/173830214-cdcb3ed3-d6fd-4841-9793-53916d632896.png\"\u003e\r\n\r\n- On non-chromium browsers it throws an exception.\r\n\r\n\u003cimg width=\"388\" alt=\"Screenshot 2022-06-15 at 14 49 36\" src=\"https://user-images.githubusercontent.com/15065076/173830896-de799971-df1e-46d3-8c3e-f147f4bacf4f.png\"\u003e\r\n\r\n## Expected Behavior\r\nWe would expect one the following two behaviours, being **number 2** the preferred:\r\n\r\n1. Consistency across all browsers. In this case, we would expect the exception on all of them.\r\n2. Handle this case and return a well formed single stack trace element, for example:\r\n\r\n\u003cimg width=\"516\" alt=\"Screenshot 2022-06-15 at 15 31 58\" src=\"https://user-images.githubusercontent.com/15065076/173839759-e15f1f93-2914-43c7-9a0c-8738c16bc614.png\"\u003e\r\n\r\n## Steps to Reproduce (for bugs)\r\n\r\nThe code below reproduces the issue:\r\n\r\n```\r\n\u003chtml\u003e\r\n    \u003chead\u003e\r\n        \u003ctitle\u003eInline errors page test\u003c/title\u003e\r\n    \u003c/head\u003e\r\n    \u003cbody\u003e\r\n        \u003ch1\u003eInline errors page test\u003c/h1\u003e\r\n        \u003cscript type=\"text/javascript\" src=\"error-stack-parser.js\"\u003e\u003c/script\u003e\r\n        \u003cscript\u003e\r\n            window.addEventListener(\"error\", (errorEvent) =\u003e {\r\n                const stack = ErrorStackParser.parse(errorEvent.error)\r\n                console.log(\"stack\", stack);\r\n            })\r\n        \u003c/script\u003e\r\n        \u003cscript\u003e\r\n            var a: // the malformed javascript here\r\n        \u003c/script\u003e\r\n    \u003c/body\u003e\r\n\u003c/html\u003e\r\n```\r\n**Important**: A SyntaxError generated from a bad usage of a API like JSON.parse does not reproduce the issue\r\n```\r\n\u003chtml\u003e\r\n    \u003chead\u003e\r\n        \u003ctitle\u003eInline errors page test\u003c/title\u003e\r\n    \u003c/head\u003e\r\n    \u003cbody\u003e\r\n        \u003ch1\u003eInline errors page test\u003c/h1\u003e\r\n        \u003cscript type=\"text/javascript\" src=\"error-stack-parser.js\"\u003e\u003c/script\u003e\r\n        \u003cscript\u003e\r\n            window.addEventListener(\"error\", (errorEvent) =\u003e {\r\n                const stack = ErrorStackParser.parse(errorEvent.error);\r\n                console.log(\"stack\", stack);\r\n            })\r\n        \u003c/script\u003e\r\n        \u003cscript\u003e\r\n            JSON.parse('\u003cI am not a json\u003e') --\u003e wrong input\r\n        \u003c/script\u003e\r\n    \u003c/body\u003e\r\n\u003c/html\u003e\r\n```\r\n\r\n## Context\r\n\u003c!--- How has this issue affected you? What are you trying to accomplish? --\u003e\r\n\u003c!--- Providing context helps us come up with a solution that is most useful in the real world --\u003e\r\n\r\n## Your Environment\r\nThis happens on all versions of the library (including the latest one). \r\nTested on different OS, such as MacOS, Fedora Linux, and Windows 10\r\n\r\n## Possible Solution\r\nIt seems that the [parse](https://github.com/stacktracejs/error-stack-parser/blob/master/error-stack-parser.js#L28,L35) function it might be the good place to start with the fix. Presumably, there is new condition to be added or a change on the regex that needs to be done, or both. \r\nOn Chromium browsers the line [return this.parseFFOrSafari(error);](https://github.com/stacktracejs/error-stack-parser/blob/master/error-stack-parser.js#L33) is the one being executed, which is wrong.\r\n\r\nOn our product we have followed a defensive approach to overcome the issue:\r\n\r\nWe leverage the information available in [ErrorEvent](https://developer.mozilla.org/en-US/docs/Web/API/ErrorEvent). So, if the library throws an exception or generates a malformed stack trace what we do is to extract **lineno**, **colno**, and **filename** from such event.","author":{"url":"https://github.com/devcorpio","@type":"Person","name":"devcorpio"},"datePublished":"2022-06-15T14:13:46.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/81/error-stack-parser/issues/81"}