Title: Remove legacy STACKMAN_HAVE_CALL macro · Issue #16 · stackless-dev/stackman · GitHub
Open Graph Title: Remove legacy STACKMAN_HAVE_CALL macro · Issue #16 · stackless-dev/stackman
X Title: Remove legacy STACKMAN_HAVE_CALL macro · Issue #16 · stackless-dev/stackman
Description: Background All 10 current platform implementations support stackman_call(), making the STACKMAN_HAVE_CALL conditional compilation macro unnecessary. Current state Every platform header defines STACKMAN_HAVE_CALL 1 Only used in tests/test...
Open Graph Description: Background All 10 current platform implementations support stackman_call(), making the STACKMAN_HAVE_CALL conditional compilation macro unnecessary. Current state Every platform header defines STAC...
X Description: Background All 10 current platform implementations support stackman_call(), making the STACKMAN_HAVE_CALL conditional compilation macro unnecessary. Current state Every platform header defines STAC...
Opengraph URL: https://github.com/stackless-dev/stackman/issues/16
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove legacy STACKMAN_HAVE_CALL macro","articleBody":"## Background\nAll 10 current platform implementations support `stackman_call()`, making the `STACKMAN_HAVE_CALL` conditional compilation macro unnecessary.\n\n## Current state\n- Every platform header defines `STACKMAN_HAVE_CALL 1`\n- Only used in `tests/test.c` to conditionally compile test_04/test_05\n- Was defensive when not all platforms had `stackman_call` implemented\n\n## Proposal\nRemove the macro and always compile the `stackman_call` tests:\n\n1. Remove `#ifndef STACKMAN_HAVE_CALL` blocks from all platform headers\n2. Remove `#ifdef TEST_04` conditionals in tests/test.c\n3. Update documentation if needed\n\n## Benefits\n- Simplifies codebase\n- Reduces conditional compilation complexity\n- Makes API surface more consistent\n\n## Breaking changes\nNone - all platforms already have it, removing the macro just makes it unconditional.\n\n## Priority\nLow - cleanup/refactoring task, no functional impact.\n\nIdentified during RISC-V implementation review.","author":{"url":"https://github.com/kristjanvalur","@type":"Person","name":"kristjanvalur"},"datePublished":"2025-11-16T19:15:10.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/16/stackman/issues/16"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:115e6d11-c9c6-59fa-94a5-3002277e4e62 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A95C:E7EF:3409357:45748AB:6981BFB7 |
| html-safe-nonce | c5dfedb946b1f799fd545807ee6fc936bfe99a8e1b84b86ce07447eba9b2616a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTVDOkU3RUY6MzQwOTM1Nzo0NTc0OEFCOjY5ODFCRkI3IiwidmlzaXRvcl9pZCI6IjExMTc0MjM4MTY0MjM4ODI2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1f907671545086ec555c2c20a34b96155b87265e1be9aa2aab37ff764be550a3 |
| hovercard-subject-tag | issue:3631012264 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/stackless-dev/stackman/16/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b640343210905b376e4860733e7d8e40a5d2bf79c98bd758dc31989f5f9422cb/stackless-dev/stackman/issues/16 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b640343210905b376e4860733e7d8e40a5d2bf79c98bd758dc31989f5f9422cb/stackless-dev/stackman/issues/16 |
| og:image:alt | Background All 10 current platform implementations support stackman_call(), making the STACKMAN_HAVE_CALL conditional compilation macro unnecessary. Current state Every platform header defines STAC... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kristjanvalur |
| hostname | github.com |
| expected-hostname | github.com |
| None | e137814e266030874fd2c86863529d0622b13889eeda04148c57654b6ea84ad6 |
| turbo-cache-control | no-preview |
| go-import | github.com/stackless-dev/stackman git https://github.com/stackless-dev/stackman.git |
| octolytics-dimension-user_id | 27702805 |
| octolytics-dimension-user_login | stackless-dev |
| octolytics-dimension-repository_id | 230749353 |
| octolytics-dimension-repository_nwo | stackless-dev/stackman |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 230749353 |
| octolytics-dimension-repository_network_root_nwo | stackless-dev/stackman |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6be0b67eaa5007447f7efac54feabf8efa3e0840 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width