René's URL Explorer Experiment


Title: Synchronous Task.WaitAll() in LoqQueue causes async/await performance problems in .NET Core · Issue #84 · stackify/stackify-api-dotnet · GitHub

Open Graph Title: Synchronous Task.WaitAll() in LoqQueue causes async/await performance problems in .NET Core · Issue #84 · stackify/stackify-api-dotnet

X Title: Synchronous Task.WaitAll() in LoqQueue causes async/await performance problems in .NET Core · Issue #84 · stackify/stackify-api-dotnet

Description: I have an Azure function app that's performance-critical. After instrumenting it with NLog and a StackifyTarget with an AsyncWrapper, I was perplexed to be observing the following: As you can see, a request that I would have expected to ...

Open Graph Description: I have an Azure function app that's performance-critical. After instrumenting it with NLog and a StackifyTarget with an AsyncWrapper, I was perplexed to be observing the following: As you can see, ...

X Description: I have an Azure function app that's performance-critical. After instrumenting it with NLog and a StackifyTarget with an AsyncWrapper, I was perplexed to be observing the following: As you can s...

Opengraph URL: https://github.com/stackify/stackify-api-dotnet/issues/84

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Synchronous Task.WaitAll() in LoqQueue causes async/await performance problems in .NET Core","articleBody":"I have an Azure function app that's performance-critical. After instrumenting it with NLog and a StackifyTarget with an AsyncWrapper, I was perplexed to be observing the following:\r\n![stackify logging](https://user-images.githubusercontent.com/8496021/53379439-86427e80-3937-11e9-8e6f-e3cf3a9a022c.JPG)\r\n\r\nAs you can see, a request that I would have expected to execute in 20ms instead took 775ms (39x longer!) due to what looks like blocking code from the StackifyTarget. Thinking perhaps the NLog AsyncWrapper wasn't behaving as it should, I did some debugging and found that the wrapper itself is behaving as expected.\r\n\r\nDigging deeper, I found that the AsyncWrapper is pretty useless when used in conjunction with the StackifyTarget, as the StackifyTarget itself queues messages up for \"asynchronous\" uploading using [System.Threading.Timer](https://github.com/stackify/stackify-api-dotnet/blob/f04e9f12d61504dbc9dec7a66a7e8cbbc1f86058/CoreSrc/StackifyLib/Internal/Logs/LogQueue.cs#L52).\r\n\r\nThis would be great _if_ the timer function was actually asynchronous. [It's not.](https://github.com/stackify/stackify-api-dotnet/blob/f04e9f12d61504dbc9dec7a66a7e8cbbc1f86058/CoreSrc/StackifyLib/Internal/Logs/LogQueue.cs#L324)\r\n\r\nMy code, which uses async/await code for all I/O operations, is now sharing a threadpool with a synchronous, I/O-bound resource hog.","author":{"url":"https://github.com/AdamEssenmacher","@type":"Person","name":"AdamEssenmacher"},"datePublished":"2019-02-26T01:27:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/84/stackify-api-dotnet/issues/84"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4a21adb4-c5e7-b02b-5214-41c6084c065e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB328:202F53:32AA091:458AF5B:6973D02A
html-safe-nonce3e8c55abca8b0f702ec86d3aa5050d615c6d3bf49106567ef43bece8ab0959db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzI4OjIwMkY1MzozMkFBMDkxOjQ1OEFGNUI6Njk3M0QwMkEiLCJ2aXNpdG9yX2lkIjoiMzM4MzczNjk2NDU1MTUyODQ5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc7b9a46d24108456a6e6c17dd9636c96302db8a750c8773c9ff87b7c77d0dfa6
hovercard-subject-tagissue:414386110
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/stackify/stackify-api-dotnet/84/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b274c268598c799daad9f476635cbab19acac710ef2369e7e6a1933aed70cb54/stackify/stackify-api-dotnet/issues/84
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b274c268598c799daad9f476635cbab19acac710ef2369e7e6a1933aed70cb54/stackify/stackify-api-dotnet/issues/84
og:image:altI have an Azure function app that's performance-critical. After instrumenting it with NLog and a StackifyTarget with an AsyncWrapper, I was perplexed to be observing the following: As you can see, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAdamEssenmacher
hostnamegithub.com
expected-hostnamegithub.com
Nonecee21c7b1ab632710d33905bc72e5e9e520eab75c9a12e16c2ce9e8f6e031e06
turbo-cache-controlno-preview
go-importgithub.com/stackify/stackify-api-dotnet git https://github.com/stackify/stackify-api-dotnet.git
octolytics-dimension-user_id3323157
octolytics-dimension-user_loginstackify
octolytics-dimension-repository_id26443472
octolytics-dimension-repository_nwostackify/stackify-api-dotnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26443472
octolytics-dimension-repository_network_root_nwostackify/stackify-api-dotnet
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef5f1d4f67b002a74550b90d5c1c0f0899544c742
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/issues/84#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstackify%2Fstackify-api-dotnet%2Fissues%2F84
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstackify%2Fstackify-api-dotnet%2Fissues%2F84
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=stackify%2Fstackify-api-dotnet
Reloadhttps://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/issues/84
Reloadhttps://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/issues/84
Reloadhttps://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/issues/84
stackify https://patch-diff.githubusercontent.com/stackify
stackify-api-dotnethttps://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fstackify%2Fstackify-api-dotnet
Fork 32 https://patch-diff.githubusercontent.com/login?return_to=%2Fstackify%2Fstackify-api-dotnet
Star 58 https://patch-diff.githubusercontent.com/login?return_to=%2Fstackify%2Fstackify-api-dotnet
Code https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet
Issues 7 https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/issues
Pull requests 3 https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/pulls
Actions https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/actions
Projects 0 https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/projects
Wiki https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/wiki
Security 0 https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/security
Insights https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/pulse
Code https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet
Issues https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/issues
Pull requests https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/pulls
Actions https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/actions
Projects https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/projects
Wiki https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/wiki
Security https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/security
Insights https://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/stackify/stackify-api-dotnet/issues/84
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/stackify/stackify-api-dotnet/issues/84
Synchronous Task.WaitAll() in LoqQueue causes async/await performance problems in .NET Corehttps://patch-diff.githubusercontent.com/stackify/stackify-api-dotnet/issues/84#top
https://github.com/AdamEssenmacher
https://github.com/AdamEssenmacher
AdamEssenmacherhttps://github.com/AdamEssenmacher
on Feb 26, 2019https://github.com/stackify/stackify-api-dotnet/issues/84#issue-414386110
https://user-images.githubusercontent.com/8496021/53379439-86427e80-3937-11e9-8e6f-e3cf3a9a022c.JPG
System.Threading.Timerhttps://github.com/stackify/stackify-api-dotnet/blob/f04e9f12d61504dbc9dec7a66a7e8cbbc1f86058/CoreSrc/StackifyLib/Internal/Logs/LogQueue.cs#L52
It's not.https://github.com/stackify/stackify-api-dotnet/blob/f04e9f12d61504dbc9dec7a66a7e8cbbc1f86058/CoreSrc/StackifyLib/Internal/Logs/LogQueue.cs#L324
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.