Title: one frame per connection by xpusostomos · Pull Request #78 · squirrel-sql-client/squirrel-sql-code · GitHub
Open Graph Title: one frame per connection by xpusostomos · Pull Request #78 · squirrel-sql-client/squirrel-sql-code
X Title: one frame per connection by xpusostomos · Pull Request #78 · squirrel-sql-client/squirrel-sql-code
Description: Earlier in the year, I opened this request... https://sourceforge.net/p/squirrel-sql/feature-requests/619/ A quick recap... It is my belief that the future will be tiling window managers, and instead of each app having its own tab mechanism, your window manager will implement a grand unified tabbing scheme. With this in mind, I had a few requests, one is that the title bar reflected the database opened. And secondly that squirrel implemented one frame per connection enforced as an optional feature. Gerd Wagner very kindly implemented the title bar update mechanism, however as it happens, it doesn't help me, because it's only implemented for the main window, and not when tabs are detached into external windows. I don't think he was interested in the one frame per connection model, which is understandable, so that's what this pull request is about. It does the following: has a new General Preference - Use new Frame per connection. when the above is selected, new tabs on the main frame are forcibly ejected onto a new Frame. Not wanting tabs on the new Frame, when the option is turned on, tabs are disabled. (The mechanism is a bit of a kludge... the tab bar height is set to zero, and I interfere with the painting to effectively make the tab bar invisible. I then add a centered title to show the user what the connection is. The title of the new frame is set to the connection name. I did not make this conditional on the option, because this is for sure an oversight of the original implementation that should have accounted for all frames having the correct title. However I did not want to get involved in all that machinery, what I've done here works for me because there won't be multiple tabs when the option is on. The result of this is every time you click an Alias in the main frame, you get a sub frame for the new connection. If this patch is accepted, or something like it, I would probably make some further suggestions to make the mainframe more useful, because having its main area always blank with everything in the sidebar is weak, but that change could come later. I'm sure the maintainers here could probably achieve what I did more elegantly, so if they don't like what I've done, feel free to do it another way.
Open Graph Description: Earlier in the year, I opened this request... https://sourceforge.net/p/squirrel-sql/feature-requests/619/ A quick recap... It is my belief that the future will be tiling window managers, and inste...
X Description: Earlier in the year, I opened this request... https://sourceforge.net/p/squirrel-sql/feature-requests/619/ A quick recap... It is my belief that the future will be tiling window managers, and inste...
Opengraph URL: https://github.com/squirrel-sql-client/squirrel-sql-code/pull/78
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:75e67e94-ac9d-cb11-d5ce-4c3038f43595 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D1AA:24B73C:74BAB6:985FAE:697F613B |
| html-safe-nonce | bcb98c089e9bafdd76fa7feb04ac816a743e1e419f671f78c32660f0c7adeb4e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUFBOjI0QjczQzo3NEJBQjY6OTg1RkFFOjY5N0Y2MTNCIiwidmlzaXRvcl9pZCI6Ijc0NTg5MzU0MjY4NzU2MTM0OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 82c2c331d2c0ea0e8d83802647962cdbd7871f49352e8d5ab8c33bdf8110c8cf |
| hovercard-subject-tag | pull_request:2995606516 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/squirrel-sql-client/squirrel-sql-code/pull/78/files |
| twitter:image | https://avatars.githubusercontent.com/u/45857005?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/45857005?s=400&v=4 |
| og:image:alt | Earlier in the year, I opened this request... https://sourceforge.net/p/squirrel-sql/feature-requests/619/ A quick recap... It is my belief that the future will be tiling window managers, and inste... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/squirrel-sql-client/squirrel-sql-code git https://github.com/squirrel-sql-client/squirrel-sql-code.git |
| octolytics-dimension-user_id | 108697363 |
| octolytics-dimension-user_login | squirrel-sql-client |
| octolytics-dimension-repository_id | 510507055 |
| octolytics-dimension-repository_nwo | squirrel-sql-client/squirrel-sql-code |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 510507055 |
| octolytics-dimension-repository_network_root_nwo | squirrel-sql-client/squirrel-sql-code |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width