Title: feat: emit_module, emit_generators and emit_async flags by kevinvalk · Pull Request #15 · sqlc-dev/sqlc-gen-python · GitHub
Open Graph Title: feat: emit_module, emit_generators and emit_async flags by kevinvalk · Pull Request #15 · sqlc-dev/sqlc-gen-python
X Title: feat: emit_module, emit_generators and emit_async flags by kevinvalk · Pull Request #15 · sqlc-dev/sqlc-gen-python
Description: In my case, the class wrappers were not nice nor were the usage of generators. Hence I added three flags to change the generated code. During the feature/refactor I noticed it felt weird to generate both async and sync flavors at the same time as most codebases (us including) will use one over the other. Moreover, you can always generate multiple flavors by just running the codegen multiple times. So what I ended up doing isn to keep the exact same behavior when using emit_sync_querier or and emit_async_querier. If you keep both of these set to false you will go into the "new" flow in which you will only generate one flavor depending on emit_async (so default generates sync code). All generated code passes all end to end tests without any changes to the tests.
Open Graph Description: In my case, the class wrappers were not nice nor were the usage of generators. Hence I added three flags to change the generated code. During the feature/refactor I noticed it felt weird to generat...
X Description: In my case, the class wrappers were not nice nor were the usage of generators. Hence I added three flags to change the generated code. During the feature/refactor I noticed it felt weird to generat...
Opengraph URL: https://github.com/sqlc-dev/sqlc-gen-python/pull/15
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:4d59174a-5f29-8c99-aeeb-a73c3784a0ae |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A88A:10C5CB:92994D:C29F1F:696EA83F |
| html-safe-nonce | 5df60f4a7de1f72fa996a237b12a7a4d8efea1c641cadb77a95498ad8de022f7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODhBOjEwQzVDQjo5Mjk5NEQ6QzI5RjFGOjY5NkVBODNGIiwidmlzaXRvcl9pZCI6IjcyMzg4OTc4MDk4NDk0OTM1NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9117b6f6c6e63a67bfb0732ab6f5a6211d408f793625ca56b6626526abcd6849 |
| hovercard-subject-tag | pull_request:1485523361 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc-gen-python/pull/15/checks |
| twitter:image | https://avatars.githubusercontent.com/u/3524694?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3524694?s=400&v=4 |
| og:image:alt | In my case, the class wrappers were not nice nor were the usage of generators. Hence I added three flags to change the generated code. During the feature/refactor I noticed it felt weird to generat... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7 |
| turbo-cache-control | no-preview |
| go-import | github.com/sqlc-dev/sqlc-gen-python git https://github.com/sqlc-dev/sqlc-gen-python.git |
| octolytics-dimension-user_id | 136738596 |
| octolytics-dimension-user_login | sqlc-dev |
| octolytics-dimension-repository_id | 548530161 |
| octolytics-dimension-repository_nwo | sqlc-dev/sqlc-gen-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 548530161 |
| octolytics-dimension-repository_network_root_nwo | sqlc-dev/sqlc-gen-python |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 27b23bc056eb973d350fc95afc848757edb9e7a9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width