René's URL Explorer Experiment


Title: file: rework saving and loading for correctness and to avoid copying by iscgar · Pull Request #1538 · solvespace/solvespace · GitHub

Open Graph Title: file: rework saving and loading for correctness and to avoid copying by iscgar · Pull Request #1538 · solvespace/solvespace

X Title: file: rework saving and loading for correctness and to avoid copying by iscgar · Pull Request #1538 · solvespace/solvespace

Description: Rework the object attributes to avoid needlessly iterating over all of them when needing to save a specific object or load a specific attribute of an object. While at it, add type verification for ...

Open Graph Description: Rework the object attributes to avoid needlessly iterating over all of them when needing to save a specific object or load a specific attribute of an object. While at it, add type verification for ...

X Description: Rework the object attributes to avoid needlessly iterating over all of them when needing to save a specific object or load a specific attribute of an object. While at it, add type verification for ...

Opengraph URL: https://github.com/solvespace/solvespace/pull/1538

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:50c2e9a6-7459-3729-dc0a-a1c333711db5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC4BA:20CD18:EDFBCC:1463F2F:696E9074
html-safe-nonce3ee937909f23956191835575b47c823d1f2d583556592745e947aaa979d7f778
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEJBOjIwQ0QxODpFREZCQ0M6MTQ2M0YyRjo2OTZFOTA3NCIsInZpc2l0b3JfaWQiOiI1NDU1NTM3NDIxODcwMzM4MTY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac031ee64fd0b65605522273063050d769f426282e124a41aab40a0fa7b0b8e5b8
hovercard-subject-tagpull_request:2366342815
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/solvespace/solvespace/1538/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/94b2a310bac4479af5c775613bd2cbce54eb66e16bad6188b77abcf0b4db30e0/solvespace/solvespace/pull/1538
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/94b2a310bac4479af5c775613bd2cbce54eb66e16bad6188b77abcf0b4db30e0/solvespace/solvespace/pull/1538
og:image:altRework the object attributes to avoid needlessly iterating over all of them when needing to save a specific object or load a specific attribute of an object. While at it, add type verification for ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiscgar
hostnamegithub.com
expected-hostnamegithub.com
Nonefdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7
turbo-cache-controlno-preview
go-importgithub.com/solvespace/solvespace git https://github.com/solvespace/solvespace.git
octolytics-dimension-user_id18541596
octolytics-dimension-user_loginsolvespace
octolytics-dimension-repository_id32905910
octolytics-dimension-repository_nwosolvespace/solvespace
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id32905910
octolytics-dimension-repository_network_root_nwosolvespace/solvespace
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release27b23bc056eb973d350fc95afc848757edb9e7a9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F1538
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F1538
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=solvespace%2Fsolvespace
Reloadhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
Reloadhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
Reloadhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
solvespace https://patch-diff.githubusercontent.com/solvespace
solvespacehttps://patch-diff.githubusercontent.com/solvespace/solvespace
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace
Fork 541 https://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace
Star 3.7k https://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace
Code https://patch-diff.githubusercontent.com/solvespace/solvespace
Issues 262 https://patch-diff.githubusercontent.com/solvespace/solvespace/issues
Pull requests 27 https://patch-diff.githubusercontent.com/solvespace/solvespace/pulls
Actions https://patch-diff.githubusercontent.com/solvespace/solvespace/actions
Projects 0 https://patch-diff.githubusercontent.com/solvespace/solvespace/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/solvespace/solvespace/security
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
Insights https://patch-diff.githubusercontent.com/solvespace/solvespace/pulse
Code https://patch-diff.githubusercontent.com/solvespace/solvespace
Issues https://patch-diff.githubusercontent.com/solvespace/solvespace/issues
Pull requests https://patch-diff.githubusercontent.com/solvespace/solvespace/pulls
Actions https://patch-diff.githubusercontent.com/solvespace/solvespace/actions
Projects https://patch-diff.githubusercontent.com/solvespace/solvespace/projects
Security https://patch-diff.githubusercontent.com/solvespace/solvespace/security
Insights https://patch-diff.githubusercontent.com/solvespace/solvespace/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fsolvespace%2Fsolvespace%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#issue-comment-box
iscgarhttps://patch-diff.githubusercontent.com/iscgar
solvespace:masterhttps://patch-diff.githubusercontent.com/solvespace/solvespace/tree/master
iscgar:iscgar/file-cleanuphttps://patch-diff.githubusercontent.com/iscgar/solvespace/tree/iscgar/file-cleanup
file: rework saving and loading for correctness and to avoid copying https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#top
iscgarhttps://patch-diff.githubusercontent.com/iscgar
solvespace:masterhttps://patch-diff.githubusercontent.com/solvespace/solvespace/tree/master
iscgar:iscgar/file-cleanuphttps://patch-diff.githubusercontent.com/iscgar/solvespace/tree/iscgar/file-cleanup
Conversation 3 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
Commits 1 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538/commits
Checks 4 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538/checks
Files changed https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538/files
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Mar 1, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#issue-2889153723
@ruevshttps://github.com/ruevs
@phkahlerhttps://github.com/phkahler
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
file: rework saving and loading for correctness and to avoid copyinghttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538/commits/88f79eaeaad59bfa14c41c36b0c30086e3c9bd23
88f79eahttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538/commits/88f79eaeaad59bfa14c41c36b0c30086e3c9bd23
https://patch-diff.githubusercontent.com/phkahler
phkahlerhttps://patch-diff.githubusercontent.com/phkahler
Mar 4, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#issuecomment-2697898192
@rpavlikhttps://github.com/rpavlik
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
https://patch-diff.githubusercontent.com/ruevs
ruevshttps://patch-diff.githubusercontent.com/ruevs
Mar 7, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#issuecomment-2705883552
@rpavlikhttps://github.com/rpavlik
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
https://patch-diff.githubusercontent.com/ruevs
ruevshttps://patch-diff.githubusercontent.com/ruevs
rpavlikhttps://patch-diff.githubusercontent.com/rpavlik
March 7, 2025 08:55https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#event-16628958687
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Mar 7, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538#issuecomment-2706254207
copy needed during savehttps://github.com/solvespace/solvespace/blob/f9e564cbdcbb045abc614b20f5997fe0206ee2a7/src/file.cpp#L310
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F1538
https://patch-diff.githubusercontent.com/rpavlik
rpavlik https://patch-diff.githubusercontent.com/rpavlik
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1538
https://patch-diff.githubusercontent.com/iscgar
https://patch-diff.githubusercontent.com/phkahler
https://patch-diff.githubusercontent.com/ruevs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.