René's URL Explorer Experiment


Title: ui: rename `CHECK_TRUE` and `CHECK_FALSE` to avoid name conflicts by iscgar · Pull Request #1537 · solvespace/solvespace · GitHub

Open Graph Title: ui: rename `CHECK_TRUE` and `CHECK_FALSE` to avoid name conflicts by iscgar · Pull Request #1537 · solvespace/solvespace

X Title: ui: rename `CHECK_TRUE` and `CHECK_FALSE` to avoid name conflicts by iscgar · Pull Request #1537 · solvespace/solvespace

Description: Currently the test harness needs to undefine them when including ui.h in order to avoid a name conflict with its own definitions. Rename them so we can do away with this hack, and have better names...

Open Graph Description: Currently the test harness needs to undefine them when including ui.h in order to avoid a name conflict with its own definitions. Rename them so we can do away with this hack, and have better names...

X Description: Currently the test harness needs to undefine them when including ui.h in order to avoid a name conflict with its own definitions. Rename them so we can do away with this hack, and have better names...

Opengraph URL: https://github.com/solvespace/solvespace/pull/1537

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b7cbcf8-6d74-fd94-42d9-f45f3cc6ceaa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2B2:101C23:133E66A:19A4F90:696EC3FB
html-safe-nonce66da481d50303fa172d22fd4f4dc785332207391bce794ebbb4864a942455a2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkIyOjEwMUMyMzoxMzNFNjZBOjE5QTRGOTA6Njk2RUMzRkIiLCJ2aXNpdG9yX2lkIjoiODIwNDA0NTc5OTczNjQ1MzA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac041ae0f1beed88e78d9a74921a98d66cb6db70a41056f43ece906937f7b5c4de
hovercard-subject-tagpull_request:2357276171
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/solvespace/solvespace/1537/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/25a8ea466e452144923370f28686d68911d82bacf793bcec49f02ffde082833b/solvespace/solvespace/pull/1537
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/25a8ea466e452144923370f28686d68911d82bacf793bcec49f02ffde082833b/solvespace/solvespace/pull/1537
og:image:altCurrently the test harness needs to undefine them when including ui.h in order to avoid a name conflict with its own definitions. Rename them so we can do away with this hack, and have better names...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiscgar
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/solvespace/solvespace git https://github.com/solvespace/solvespace.git
octolytics-dimension-user_id18541596
octolytics-dimension-user_loginsolvespace
octolytics-dimension-repository_id32905910
octolytics-dimension-repository_nwosolvespace/solvespace
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id32905910
octolytics-dimension-repository_network_root_nwosolvespace/solvespace
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F1537
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F1537
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=solvespace%2Fsolvespace
Reloadhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
Reloadhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
Reloadhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
solvespace https://patch-diff.githubusercontent.com/solvespace
solvespacehttps://patch-diff.githubusercontent.com/solvespace/solvespace
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace
Fork 541 https://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace
Star 3.7k https://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace
Code https://patch-diff.githubusercontent.com/solvespace/solvespace
Issues 262 https://patch-diff.githubusercontent.com/solvespace/solvespace/issues
Pull requests 27 https://patch-diff.githubusercontent.com/solvespace/solvespace/pulls
Actions https://patch-diff.githubusercontent.com/solvespace/solvespace/actions
Projects 0 https://patch-diff.githubusercontent.com/solvespace/solvespace/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/solvespace/solvespace/security
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
Insights https://patch-diff.githubusercontent.com/solvespace/solvespace/pulse
Code https://patch-diff.githubusercontent.com/solvespace/solvespace
Issues https://patch-diff.githubusercontent.com/solvespace/solvespace/issues
Pull requests https://patch-diff.githubusercontent.com/solvespace/solvespace/pulls
Actions https://patch-diff.githubusercontent.com/solvespace/solvespace/actions
Projects https://patch-diff.githubusercontent.com/solvespace/solvespace/projects
Security https://patch-diff.githubusercontent.com/solvespace/solvespace/security
Insights https://patch-diff.githubusercontent.com/solvespace/solvespace/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fsolvespace%2Fsolvespace%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fsolvespace%2Fsolvespace%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issue-comment-box
iscgarhttps://patch-diff.githubusercontent.com/iscgar
solvespace:masterhttps://patch-diff.githubusercontent.com/solvespace/solvespace/tree/master
iscgar:iscgar/check-renamehttps://patch-diff.githubusercontent.com/iscgar/solvespace/tree/iscgar/check-rename
ui: rename CHECK_TRUE and CHECK_FALSE to avoid name conflicts https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#top
iscgarhttps://patch-diff.githubusercontent.com/iscgar
solvespace:masterhttps://patch-diff.githubusercontent.com/solvespace/solvespace/tree/master
iscgar:iscgar/check-renamehttps://patch-diff.githubusercontent.com/iscgar/solvespace/tree/iscgar/check-rename
Conversation 9 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
Commits 1 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537/commits
Checks 4 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537/checks
Files changed https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537/files
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Feb 25, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issue-2879023121
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
ui: rename CHECK_TRUE and CHECK_FALSE to avoid name conflictshttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537/commits/f2ebb3eac336dd5ea4fd91220d689c99f8655a21
f2ebb3ehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537/commits/f2ebb3eac336dd5ea4fd91220d689c99f8655a21
https://patch-diff.githubusercontent.com/ruevs
ruevshttps://patch-diff.githubusercontent.com/ruevs
Feb 26, 2025 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#pullrequestreview-2643864964
View reviewed changes https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537/files/f2ebb3eac336dd5ea4fd91220d689c99f8655a21
ruevshttps://patch-diff.githubusercontent.com/ruevs
https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#pullrequestreview-2643864964
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
undef statementshttps://github.com/solvespace/solvespace/blob/a5d40f81e3c2fccf9fd1cf28de6b4d4485fde068/test/harness.h#L9
solvespace/test/harness.hhttps://github.com/solvespace/solvespace/blob/a5d40f81e3c2fccf9fd1cf28de6b4d4485fde068/test/harness.h#L58
a5d40f8https://patch-diff.githubusercontent.com/solvespace/solvespace/commit/a5d40f81e3c2fccf9fd1cf28de6b4d4485fde068
solvespace/src/ui.hhttps://github.com/solvespace/solvespace/blob/a5d40f81e3c2fccf9fd1cf28de6b4d4485fde068/src/ui.h#L206
a5d40f8https://patch-diff.githubusercontent.com/solvespace/solvespace/commit/a5d40f81e3c2fccf9fd1cf28de6b4d4485fde068
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/ruevs
ruevshttps://patch-diff.githubusercontent.com/ruevs
Feb 26, 2025 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#ref-pullrequest-2878454637
Minor refactoring of surface curve data into its own struct #1536 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1536
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Feb 26, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2686106413
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/phkahler
phkahlerhttps://patch-diff.githubusercontent.com/phkahler
Feb 26, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2686173012
@ruevshttps://github.com/ruevs
@iscgarhttps://github.com/iscgar
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Feb 26, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2686229963
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
@phkahlerhttps://github.com/phkahler
#1536 (comment)https://github.com/solvespace/solvespace/pull/1536#issuecomment-2686155239
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Mar 1, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2692401070
@ruevshttps://github.com/ruevs
@phkahlerhttps://github.com/phkahler
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Mar 1, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#event-16523261450
https://patch-diff.githubusercontent.com/ruevs
ruevshttps://patch-diff.githubusercontent.com/ruevs
Mar 3, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2695462279
#359https://github.com/solvespace/solvespace/pull/359
#1503https://github.com/solvespace/solvespace/pull/1503
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Mar 3, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2695523358
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/rpavlik
rpavlikhttps://patch-diff.githubusercontent.com/rpavlik
Mar 3, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2695828590
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Mar 4, 2025https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#issuecomment-2698500961
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
@ruevshttps://github.com/ruevs
#1536 (comment)https://github.com/solvespace/solvespace/pull/1536#issuecomment-2686223615
2bc945bhttps://github.com/solvespace/solvespace/commit/2bc945bf13a8338cc1b0e0ee2ce65bbda0bc820f
herehttps://github.com/solvespace/solvespace/compare/master...iscgar:solvespace:11965c5c7e9e703bcd7d7bd9c700e6387aaebe2a
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
March 4, 2025 18:11https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#event-16568185618
https://patch-diff.githubusercontent.com/iscgar
iscgarhttps://patch-diff.githubusercontent.com/iscgar
Jul 2, 2025 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537#ref-pullrequest-3195598869
general: rework the way files are included for better maintainability #1607 https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1607
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F1537
https://patch-diff.githubusercontent.com/ruevs
ruevs https://patch-diff.githubusercontent.com/ruevs
https://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537/files/f2ebb3eac336dd5ea4fd91220d689c99f8655a21
Please reload this pagehttps://patch-diff.githubusercontent.com/solvespace/solvespace/pull/1537
https://patch-diff.githubusercontent.com/iscgar
https://patch-diff.githubusercontent.com/phkahler
https://patch-diff.githubusercontent.com/ruevs
https://patch-diff.githubusercontent.com/rpavlik
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.